-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates for Run-3 CSC trigger primitives #34245
Updates for Run-3 CSC trigger primitives #34245
Conversation
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5958ab/16246/summary.html Comparison SummarySummary:
|
There are quite a bit of failures in the CSC DQM plots. This could be because only the first 2 CLCTs/LCTs should be written out (like in the firmware), instead of all of them. The CSC trigger tends to make copies of patterns at later BX's (typically BX+1). |
+l1 |
@dildick I am confused by this statement and the actual changes in some of the DQM workflows: |
I ran WF 11634.0 in CMSSW_12_0_X_2021-06-28-1100 to study it in more detail. Fewer CLCTs are present in some chambers with this PR: [1] Apparently duplicate CLCTs, which definitely must be removed. In fact, the LCTQualityControl should have a feature to remove duplicate CLCTs. CMSSW_12_0_X_2021-06-28-1100
CMSSW_12_0_X_2021-06-28-1100 + #34245
|
@jfernan2 The results look good to me. The agreement with recent cosmic is not going to be perfect either. At P5 we're still running Run-2 CSC trigger primitive firmware, but in the emulator, parts of Run-3 and Phase-2 are already enabled. |
+1 |
@civanch Do you have any comments? |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR is a collection of updates for Run-3 CSC trigger primitives (actually Phase-2 which we're moving forward by several years).
PR validation:
Code was tested on 10k events of B904 cosmic data (to test Run-3 algorithm), and on 26k events of 2018D ZeroBias data Run 322022 (to test Run-2 algorithm). Chambers ME+1/1/9, ME+1/1/10 and ME+1/1/11 were excluded in this comparison because we had loaded prototype Phase-2 firmware on those chambers.
Plots are added below.
Data vs emulator for B904 data: DataVsEmulatorComparison_June2021.pdf
Data vs emulator for ZeroBias data: CSC_dataVsEmul_CMS_Run_322022.pdf
An improvement is seen for the B904 data. No change is seen for the 2018D ZeroBias data.
There are minor discrepancies in the ZeroBias data I'm still trying to understand. Second attached PDF file.
a) fewer ALCTs in emulation for ME1/1. It's about 1 every 1000 ALCTs (see page 11)
b) emulation seems to be promoting 4- and 5-layer ALCTs to 6-layer (see page 2)
c) fewer CLCTs in emulation. Also about in every 1000 CLCTs (see page 29)
if this PR is a backport please specify the original PR and why you need to backport that PR:
N/A
Before submitting your pull requests, make sure you followed this checklist: