Fork Update #1
Merged
Fork Update #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Missed acctest.Randoms, add support for skipIfVcr * Add skip_vcr to tests, more fixes for failing vcr tests * Fix compile * Comment on why / path replace is needed * Rubocop line length * Ignores for instance template tests with generated ids, multiple fine-grained resources in single step * Add more ignores, rework VCR file writing to only write when test succeeds * Add notes on why specific tests fail VCR * Spaces...
* add window based SLI * comment
* Added new data source for iam_testable_permissions * Added tests and docs * Fixed linter errors * Use sdk validation package and allow case-insensitive * Changed stage to stages list and concat results
* Create works, update needs help * non-plural name for set items * Add sql and web server ip cidr blocks * Test passes * Remove schema from ga version, fix lint erro * Add note to composer docs linking to private environment setup * Computed web server access as it has default values set by API. Ignore during import tests * Add computed to new cidr blocks as they get default values based on the region they exist in
…E_APPLICATION_CREDENTIALS` (#3522) Co-authored-by: Damian Myerscough <Damian.Myerscough@gmail.com>
… with one field (#3519)
* Check for diffs in allowed ranges set, checking in parent object produces incorrect changes due to sets internal representation * Add comment
…auto_provisioning_defaults (#3383)
* update of node pool workload metadata * fix forcenew for nested field as well * add set to util for forcenewing field schema, move to utils * add back forcenew for sandbox config
* GA secret manager * Fixing some issues with ga version * GA datasource as well
* Add skip enum value generation * Fix default * Fix reader * Fix line spacing on enum values
Co-authored-by: Muhammad Hamza Zaib <hamzazaib3202@gmail.com>
Co-authored-by: Cameron Thornton <camthornton@google.com> Co-authored-by: eric-hole <eric.hole@gmail.com>
* Add ability to set global network endpoint group as backend for backend service. Make health_checks optional * PR fixes * Add encoder to remove max_utilization when neg backend * Check for global NEG in group to remove max_utilization * Add another nil check * Spacing * Docs fix
Co-authored-by: Edward Sun <sunedward@google.com>
This patch makes the `defaultClientScopes` variable publicly accessible to allow for code that depends on the provider to have the ability to programmatically determine the default OAuth2 scopes used by the provider, and to add to it if necessary.
* AD Domain resource added * fmt issue fixed * validation regex and input flag added * made domain_name field not updatable * validationfunc added * validationfunc error message modified
* add firewall logging controls * make backward compatible * check enable_logging in expand * update docs * update expand logic to fix failing test
* Add support for cloudrun ports * Typo in comments * Add link to api docs to explain optional port parameters * Use existing description convention * Default protcol is TCP, not http * Set default_from_api to true for ports * Make container_port required * Update products/cloudrun/api.yaml Co-authored-by: Sam Levenick <slevenick@google.com> Co-authored-by: Sam Levenick <slevenick@google.com>
…re are no changes (#3786) This patch fixes a bug in source_repo_repository where a diff was always being generated for the TypeSet field `pubsub_configs` since its Set hashing function was not accounting for the fact that `pubsub_configs[].topic` can contain either a topic's name or relative path.
…3802) * Add a random string to ad directory so tests can be run in parallel * Add import
upodroid
pushed a commit
that referenced
this pull request
Aug 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Note Template for Downstream PRs (will be copied)