Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error checking to location load in endpoints service #3781

Merged

Conversation

slevenick
Copy link
Contributor

@slevenick slevenick commented Jul 23, 2020

Fixes: hashicorp/terraform-provider-google#6840

Release Note Template for Downstream PRs (will be copied)

endpoints: Fixed a crash when `google_endpoints_service` is used on a machine without timezone data

@google-cla google-cla bot added the cla: yes label Jul 23, 2020
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 5 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 1 file changed, 5 insertions(+), 1 deletion(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=135154"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Terraform crashes while creating Google cloud Endpoint using Cloud build
3 participants