fix philosphy typo #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! |
nat-henderson
added a commit
that referenced
this pull request
Mar 8, 2018
This sets up the CI system by which changes can flow from MagicModules down to Terraform. In its current form it only does Terraform, but a major goal is to extend it to all generated repositories. The code here refers to a handful of docker containers I had to create - one of them has its Dockerfile checked in here, but the rest are built from other, existing repositories. Still working to get my changes to those upstream repos merged, but in the meantime I've built my own versions and am using those. This isn't all the way done: I've commented out "trigger: true" in a few places here because I don't think this is ready to be fully automated yet. It also currently does all the work in a user's own forks rather than the main repos. I want to review it as-is (since it's approximately the minimum viable proof-of-concept), and I'll try to make smaller changes from here on in.
nat-henderson
added a commit
that referenced
this pull request
Jan 2, 2019
c2thorn
pushed a commit
that referenced
this pull request
May 11, 2020
edwardmedia
added a commit
that referenced
this pull request
May 15, 2020
nathkn
pushed a commit
to nathkn/magic-modules
that referenced
this pull request
May 18, 2020
nathkn
pushed a commit
to nathkn/magic-modules
that referenced
this pull request
May 18, 2020
…#3507) * add descriptions to the schema * add descriptions to schema * run go fmt Co-authored-by: Edward Sun <sunedward@google.com>
5 tasks
drebes
pushed a commit
to drebes/magic-modules
that referenced
this pull request
Nov 11, 2020
Add example/test
gfxcc
pushed a commit
to gfxcc/magic-modules
that referenced
this pull request
Nov 16, 2021
…_url_param_only * Use url_param_only instead of virtual field * Rename new field includeMaxPathLength to includeMaxIssuerPathLength for local consistence
5 tasks
SarahFrench
pushed a commit
that referenced
this pull request
Sep 26, 2024
Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com> Co-authored-by: karolgorc <karol.gorczyk@infogain.com> Co-authored-by: Augusto Hidalgo <ahidalgo94@gmail.com> Co-authored-by: Thomas Rodgers <thomasrodgers@google.com> Co-authored-by: Nick Elliot <nickelliot@google.com> Co-authored-by: Ilia Lazebnik <Ilia.lazebnik@gmail.com> Co-authored-by: vijaykanthm <vijaykanthm@google.com> Co-authored-by: Abhijeet Jha <abhijeetkjha@google.com> Co-authored-by: bcreddy-gcp <123543489+bcreddy-gcp@users.noreply.github.com> Co-authored-by: Cameron Thornton <camthornton@google.com> Co-authored-by: Riley Karson <rileykarson@google.com> Co-authored-by: Zhenhua Li <zhenhuali@google.com> Co-authored-by: Ron Gal <125445217+ron-gal@users.noreply.github.com>
SarahFrench
added a commit
that referenced
this pull request
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.