Add tests for DICOM store pubsub topic removal. #3442

xingao267 · 2020-04-29T22:32:26Z

Release Note Template for Downstream PRs (will be copied)

healthcare: added tests for pubsub topic removal in `google_healthcare_dicom_store`

modular-magician · 2020-04-29T22:40:08Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 8 insertions(+), 9 deletions(-))
Terraform Beta: Diff ( 1 file changed, 8 insertions(+), 9 deletions(-))

danawillow · 2020-06-18T00:18:45Z

Cloud build is failing because resource_healthcare_dicom_store_test.go needs to be gofmt-ted

xingao267 · 2020-06-18T16:59:48Z

/gcbrun

modular-magician · 2020-06-18T17:00:34Z

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@SirGitsalot, please review this PR or find an appropriate assignee.

modular-magician · 2020-06-18T17:05:34Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 8 insertions(+), 9 deletions(-))
Terraform Beta: Diff ( 1 file changed, 8 insertions(+), 9 deletions(-))

modular-magician · 2020-06-18T17:05:40Z

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=121427"

xingao267 · 2020-06-18T17:10:23Z

@danawillow thanks! fixed the format.

danawillow · 2020-06-18T19:27:22Z

I ran the test and it failed, so there might be some code changes that need to be made also. Let me know if you want some help investigating.

Here's the failure:

------- Stdout: -------
=== RUN   TestAccHealthcareDicomStore_basic
=== PAUSE TestAccHealthcareDicomStore_basic
=== CONT  TestAccHealthcareDicomStore_basic
TestAccHealthcareDicomStore_basic: testing.go:674: Step 4 error: After applying this step, the plan was not empty:
DIFF:
UPDATE: google_healthcare_dicom_store.default
dataset:                            "projects/ci-test-project-188019/locations/us-central1/datasets/tf-test-dataset-wnuetotr4w" => "projects/ci-test-project-188019/locations/us-central1/datasets/tf-test-dataset-wnuetotr4w"
id:                                 "projects/ci-test-project-188019/locations/us-central1/datasets/tf-test-dataset-wnuetotr4w/dicomStores/tf-test-dicom-store-i2iw0wucns" => "projects/ci-test-project-188019/locations/us-central1/datasets/tf-test-dataset-wnuetotr4w/dicomStores/tf-test-dicom-store-i2iw0wucns"
labels.label1:                      "labelvalue1" => ""
name:                               "tf-test-dicom-store-i2iw0wucns" => "tf-test-dicom-store-i2iw0wucns"
notification_config.#:              "1" => "0"
notification_config.0.pubsub_topic: "projects/ci-test-project-188019/topics/tf-test-topic-cmj2b4sjbu" => ""
self_link:                          "projects/ci-test-project-188019/locations/us-central1/datasets/tf-test-dataset-wnuetotr4w/dicomStores/tf-test-dicom-store-i2iw0wucns" => "projects/ci-test-project-188019/locations/us-central1/datasets/tf-test-dataset-wnuetotr4w/dicomStores/tf-test-dicom-store-i2iw0wucns"
STATE:
google_healthcare_dataset.dataset:
ID = projects/ci-test-project-188019/locations/us-central1/datasets/tf-test-dataset-wnuetotr4w
provider = provider.google
location = us-central1
name = tf-test-dataset-wnuetotr4w
project = ci-test-project-188019
self_link = projects/ci-test-project-188019/locations/us-central1/datasets/tf-test-dataset-wnuetotr4w
time_zone = UTC
google_healthcare_dicom_store.default:
ID = projects/ci-test-project-188019/locations/us-central1/datasets/tf-test-dataset-wnuetotr4w/dicomStores/tf-test-dicom-store-i2iw0wucns
provider = provider.google
dataset = projects/ci-test-project-188019/locations/us-central1/datasets/tf-test-dataset-wnuetotr4w
labels.label1 = labelvalue1
name = tf-test-dicom-store-i2iw0wucns
notification_config.# = 1
notification_config.0.pubsub_topic = projects/ci-test-project-188019/topics/tf-test-topic-cmj2b4sjbu
self_link = projects/ci-test-project-188019/locations/us-central1/datasets/tf-test-dataset-wnuetotr4w/dicomStores/tf-test-dicom-store-i2iw0wucns
Dependencies:
google_healthcare_dataset.dataset
--- FAIL: TestAccHealthcareDicomStore_basic (12.94s)
FAIL

modular-magician · 2020-07-20T15:37:42Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 10 insertions(+), 11 deletions(-))
Terraform Beta: Diff ( 3 files changed, 10 insertions(+), 11 deletions(-))

xingao267 · 2020-07-20T17:30:53Z

@danawillow could you help rerun the test? The underlying dicom bug should now be fixed.

I tried to run it myself, but got the following error even with a clean copy of the terraform-provider-google.

$ make testacc TEST=./google TESTARGS='-run=TestAccHealthcareFhirStore*'
==> Checking source code against gofmt...
==> Checking that code complies with gofmt requirements...
go generate  ./...
TF_ACC=1 TF_SCHEMA_PANIC_ON_ERROR=1 go test ./google -v -run=TestAccHealthcareFhirStore* -timeout 240m -ldflags="-X=github.com/terraform-providers/terraform-provider-google/version.ProviderVersion=acc"
=== RUN   TestAccHealthcareFhirStore_healthcareFhirStoreBasicExample
=== PAUSE TestAccHealthcareFhirStore_healthcareFhirStoreBasicExample
=== RUN   TestAccHealthcareFhirStore_healthcareFhirStoreStreamingConfigExample
=== PAUSE TestAccHealthcareFhirStore_healthcareFhirStoreStreamingConfigExample
=== RUN   TestAccHealthcareFhirStoreIamBinding
=== PAUSE TestAccHealthcareFhirStoreIamBinding
=== RUN   TestAccHealthcareFhirStoreIamMember
=== PAUSE TestAccHealthcareFhirStoreIamMember
=== RUN   TestAccHealthcareFhirStoreIamPolicy
=== PAUSE TestAccHealthcareFhirStoreIamPolicy
=== RUN   TestAccHealthcareFhirStoreIdParsing
=== PAUSE TestAccHealthcareFhirStoreIdParsing
=== RUN   TestAccHealthcareFhirStore_basic
=== PAUSE TestAccHealthcareFhirStore_basic
=== CONT  TestAccHealthcareFhirStore_healthcareFhirStoreBasicExample
=== CONT  TestAccHealthcareFhirStoreIamPolicy
=== CONT  TestAccHealthcareFhirStore_healthcareFhirStoreStreamingConfigExample
=== CONT  TestAccHealthcareFhirStoreIdParsing
=== CONT  TestAccHealthcareFhirStoreIamBinding
=== CONT  TestAccHealthcareFhirStore_basic
=== CONT  TestAccHealthcareFhirStoreIamMember
--- PASS: TestAccHealthcareFhirStoreIdParsing (0.01s)
panic: nil context

goroutine 776 [running]:
net/http.(*Request).WithContext(...)
	/usr/lib/google-golang/src/net/http/request.go:358
golang.org/x/net/context/ctxhttp.Do(0x0, 0x0, 0x4930580, 0xc001147000, 0x77df37dbca5083da, 0x10, 0x284a3e0)
	/usr/local/google/home/xingao/gitrepos/pkg/mod/golang.org/x/net@v0.0.0-20200324143707-d3edc9973b7e/context/ctxhttp/ctxhttp.go:27 +0x324
golang.org/x/oauth2/internal.doTokenRoundTrip(0x0, 0x0, 0xc001147000, 0x48, 0xc00342dc40, 0x18)
	/usr/local/google/home/xingao/gitrepos/pkg/mod/golang.org/x/oauth2@v0.0.0-20200107190931-bf48bf16ab8d/internal/token.go:232 +0x7b
golang.org/x/oauth2/internal.RetrieveToken(0x0, 0x0, 0xc0034b6000, 0x48, 0xc00342dc40, 0x18, 0x2f0465a, 0x23, 0xc002163380, 0x1, ...)
	/usr/local/google/home/xingao/gitrepos/pkg/mod/golang.org/x/oauth2@v0.0.0-20200107190931-bf48bf16ab8d/internal/token.go:202 +0xdf
golang.org/x/oauth2.retrieveToken(0x0, 0x0, 0xc002018150, 0xc002163380, 0xc002163450, 0xc006855ebb, 0x1)
	/usr/local/google/home/xingao/gitrepos/pkg/mod/golang.org/x/oauth2@v0.0.0-20200107190931-bf48bf16ab8d/token.go:157 +0x92
golang.org/x/oauth2.(*tokenRefresher).Token(0xc0067cf230, 0x5f13ad, 0x2eb3162, 0x6)
	/usr/local/google/home/xingao/gitrepos/pkg/mod/golang.org/x/oauth2@v0.0.0-20200107190931-bf48bf16ab8d/oauth2.go:270 +0x1de
golang.org/x/oauth2.(*reuseTokenSource).Token(0xc000d41a20, 0x0, 0x0, 0x0)
	/usr/local/google/home/xingao/gitrepos/pkg/mod/golang.org/x/oauth2@v0.0.0-20200107190931-bf48bf16ab8d/oauth2.go:304 +0xa8
golang.org/x/oauth2.(*Transport).RoundTrip(0xc000d41a60, 0xc001146f00, 0x0, 0x0, 0x0)
	/usr/local/google/home/xingao/gitrepos/pkg/mod/golang.org/x/oauth2@v0.0.0-20200107190931-bf48bf16ab8d/transport.go:45 +0x9e
github.com/hashicorp/terraform-plugin-sdk/helper/logging.(*transport).RoundTrip(0xc000d41a80, 0xc001146f00, 0xc0021636f0, 0x1, 0x1)
	/usr/local/google/home/xingao/gitrepos/pkg/mod/github.com/hashicorp/terraform-plugin-sdk@v1.11.0/helper/logging/transport.go:27 +0x164
github.com/terraform-providers/terraform-provider-google/google.(*retryTransport).RoundTrip(0xc0067cf530, 0xc0015f8900, 0x0, 0x0, 0x0)
	/usr/local/google/home/xingao/gitrepos/src/github.com/terraform-providers/terraform-provider-google/google/retry_transport.go:125 +0x2c5
net/http.send(0xc0015f8800, 0x3579b40, 0xc0067cf530, 0xbfbd9307a3945b21, 0x70e11c26f, 0x4930920, 0xc00217f3b0, 0xbfbd9307a3945b21, 0x1, 0x0)
	/usr/lib/google-golang/src/net/http/client.go:252 +0x43e
net/http.(*Client).send(0xc0067cf4a0, 0xc0015f8800, 0xbfbd9307a3945b21, 0x70e11c26f, 0x4930920, 0xc00217f3b0, 0x0, 0x1, 0xc000fc20a0)
	/usr/lib/google-golang/src/net/http/client.go:176 +0xfa
net/http.(*Client).do(0xc0067cf4a0, 0xc0015f8800, 0x0, 0x0, 0x0)
	/usr/lib/google-golang/src/net/http/client.go:699 +0x44a
net/http.(*Client).Do(...)
	/usr/lib/google-golang/src/net/http/client.go:567
github.com/terraform-providers/terraform-provider-google/google.sendRequestWithTimeout.func1(0xc001a10168, 0xc0010bc6a4)
	/usr/local/google/home/xingao/gitrepos/src/github.com/terraform-providers/terraform-provider-google/google/transport.go:82 +0x249
github.com/terraform-providers/terraform-provider-google/google.retryTimeDuration.func1(0x5dfc40)
	/usr/local/google/home/xingao/gitrepos/src/github.com/terraform-providers/terraform-provider-google/google/retry_utils.go:21 +0x32
github.com/hashicorp/terraform-plugin-sdk/helper/resource.Retry.func1(0x0, 0x0, 0x0, 0x0, 0x0, 0x0)
	/usr/local/google/home/xingao/gitrepos/pkg/mod/github.com/hashicorp/terraform-plugin-sdk@v1.11.0/helper/resource/wait.go:22 +0x5e
github.com/hashicorp/terraform-plugin-sdk/helper/resource.(*StateChangeConf).WaitForState.func1(0xc00089f980, 0xc001361500, 0xc003906100, 0xc000b20000, 0xc001e60930, 0xc001e60928)
	/usr/local/google/home/xingao/gitrepos/pkg/mod/github.com/hashicorp/terraform-plugin-sdk@v1.11.0/helper/resource/state.go:103 +0x298
created by github.com/hashicorp/terraform-plugin-sdk/helper/resource.(*StateChangeConf).WaitForState
	/usr/local/google/home/xingao/gitrepos/pkg/mod/github.com/hashicorp/terraform-plugin-sdk@v1.11.0/helper/resource/state.go:80 +0x1bf
FAIL	github.com/terraform-providers/terraform-provider-google/google	0.576s
FAIL
make: *** [GNUmakefile:14: testacc] Error 1

danawillow · 2020-07-25T00:17:04Z

Hey, just wanted to pop in and let you know I haven't forgotten about this! I've had a bunch of other things on my plate, but I should be able to look at this again next week.

danawillow

Tests pass, thanks @xingao267!

googlebot added the cla: yes label Apr 29, 2020

xingao267 force-pushed the patch-12 branch from 016b792 to 78486ab Compare June 18, 2020 16:59

modular-magician requested a review from SirGitsalot June 18, 2020 17:00

danawillow requested review from danawillow and removed request for SirGitsalot June 18, 2020 17:02

xingao267 and others added 2 commits July 20, 2020 11:04

Add tests for DICOM store pubsub topic removal.

de1b14b

fix format

d0e7eea

xingao267 force-pushed the patch-12 branch from 78486ab to d0e7eea Compare July 20, 2020 15:30

danawillow approved these changes Jul 30, 2020

View reviewed changes

danawillow merged commit 50e59be into GoogleCloudPlatform:master Jul 30, 2020

xingao267 deleted the patch-12 branch July 30, 2020 16:51

This was referenced Jul 30, 2020

Add tests for DICOM store pubsub topic removal. hashicorp/terraform-provider-google#6893

Merged

Add tests for DICOM store pubsub topic removal. hashicorp/terraform-provider-google-beta#2319

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add tests for DICOM store pubsub topic removal. #3442

Add tests for DICOM store pubsub topic removal. #3442

xingao267 commented Apr 29, 2020

modular-magician commented Apr 29, 2020

danawillow commented Jun 18, 2020

xingao267 commented Jun 18, 2020

modular-magician commented Jun 18, 2020

modular-magician commented Jun 18, 2020

modular-magician commented Jun 18, 2020

xingao267 commented Jun 18, 2020

danawillow commented Jun 18, 2020

modular-magician commented Jul 20, 2020

xingao267 commented Jul 20, 2020

danawillow commented Jul 25, 2020

danawillow left a comment

Add tests for DICOM store pubsub topic removal. #3442

Add tests for DICOM store pubsub topic removal. #3442

Conversation

xingao267 commented Apr 29, 2020

modular-magician commented Apr 29, 2020

Diff report:

danawillow commented Jun 18, 2020

xingao267 commented Jun 18, 2020

modular-magician commented Jun 18, 2020

modular-magician commented Jun 18, 2020

Diff report:

modular-magician commented Jun 18, 2020

xingao267 commented Jun 18, 2020

danawillow commented Jun 18, 2020

modular-magician commented Jul 20, 2020

Diff report:

xingao267 commented Jul 20, 2020

danawillow commented Jul 25, 2020

danawillow left a comment

Choose a reason for hiding this comment