Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make defaultClientScopes publicly accessible #3785

Merged
merged 1 commit into from
Jul 27, 2020

Conversation

jcanseco
Copy link
Member

This patch makes the defaultClientScopes variable publicly accessible
to allow for code that depends on the provider to have the ability to
programmatically determine the default OAuth2 scopes used by the
provider, and to add to it if necessary.

Release Note Template for Downstream PRs (will be copied)


This patch makes the `defaultClientScopes` variable publicly accessible
to allow for code that depends on the provider to have the ability to
programmatically determine the default OAuth2 scopes used by the
provider, and to add to it if necessary.
@google-cla google-cla bot added the cla: yes label Jul 27, 2020
@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@slevenick, please review this PR or find an appropriate assignee.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 2 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 1 file changed, 2 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 2 insertions(+), 2 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=135964"

@jcanseco
Copy link
Member Author

The Cloud Build Trigger is failing, though it doesn't seem like I have permissions to view the results:

image

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 2 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 1 file changed, 2 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 2 insertions(+), 2 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=135976"

@slevenick
Copy link
Contributor

The Cloud Build Trigger is failing, though it doesn't seem like I have permissions to view the results:

image

Looks like it was a temporary CI issue. Amending the commit and re-pushing should fix it

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccEndpointsService_basic|TestAccFolderIamAuditConfig_multiple You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=135980"

@jcanseco
Copy link
Member Author

Thanks!

@jcanseco jcanseco deleted the defaultclientscopes branch July 30, 2020 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants