Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for diffs in allowed ranges set #3529

Merged

Conversation

slevenick
Copy link
Contributor

@slevenick slevenick commented May 18, 2020

Checking the parent object for HasChange produces incorrect results.

No changes as this has not been released yet

See hashicorp/terraform-plugin-sdk#98

Release Note Template for Downstream PRs (will be copied)


…uces incorrect changes due to sets internal representation
@emilymye emilymye self-requested a review May 18, 2020 21:21
Copy link
Contributor

@emilymye emilymye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to add a comment in case people in the future add more nested fields to the parent block about why we are checking the nested field? but composer requires careful thought anyways so it's probably not the end of the world

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))
Terraform Beta: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 3 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 1 file changed, 3 insertions(+), 1 deletion(-))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants