-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Desktop Layout #5139
Merged
Merged
New Desktop Layout #5139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/app/containers/FrontPageSection/utilities/storySplitter.jsx
Outdated
Show resolved
Hide resolved
…nto use-grid-front-page-layout
…imorgh into use-grid-front-page-layout
…imorgh into use-grid-front-page-layout
Looks good to me but a complete device testing can be done properly when its on test env. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4562 and #4500
Overall change:
Build the new Front Page desktop layout.
Screenshots
Section with 1 item
![Section slice with 1 item](https://user-images.githubusercontent.com/3028997/74035092-86edec80-49b1-11ea-81b6-544ebfecece7.png)
Section with 2 items
![Section slice with 2 items](https://user-images.githubusercontent.com/3028997/74035058-73db1c80-49b1-11ea-8058-420368a0bc99.png)
Section with 4 items
![Screenshot 2020-02-07 at 13 58 21](https://user-images.githubusercontent.com/3028997/74035296-eea43780-49b1-11ea-861a-63e49f0eda00.png)
Section with 5 items (plus index alsos)
![Section with 5 items (plus index alsos)](https://user-images.githubusercontent.com/3028997/74035053-70479580-49b1-11ea-847f-beca011d2a8a.png)
Section with 6 items
![Section slice with 6 items](https://user-images.githubusercontent.com/3028997/74035091-85bcbf80-49b1-11ea-9bae-cf9acd2686f1.png)
Section slice with TV promo
![Screenshot 2020-02-07 at 13 59 36](https://user-images.githubusercontent.com/3028997/74035466-34610000-49b2-11ea-9e68-66c7279df21a.png)
Section slice with Radio promo
![Screenshot 2020-02-07 at 14 00 26](https://user-images.githubusercontent.com/3028997/74035489-3fb42b80-49b2-11ea-9bca-a4deafa584dd.png)
Top Stories
...
Code changes:
FrontPageSection
to create an array of all the rows that are needed for the sectionFrontPageStoryRow
container that renders the different types of row required for the UX designsdir
prop to Grid to fix RTL layoutsFrontPageGrid
gooes up to 1008pxStoryPromo
promoType
prop oftop
,leading
andregular
in theStoryPromo
containerImagePlaceholder
in theBulletin
if this doesn't have image valuesNo Image Radio Bulletin
storyRelated PR's
Testing:
CYPRESS_APP_ENV=local CYPRESS_SMOKE=false npm run test:e2e:interactive
)