Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Desktop Layout #5139

Merged
merged 232 commits into from
Feb 25, 2020
Merged

New Desktop Layout #5139

merged 232 commits into from
Feb 25, 2020

Conversation

sareh
Copy link
Contributor

@sareh sareh commented Jan 14, 2020

Resolves #4562 and #4500

Overall change:
Build the new Front Page desktop layout.

Screenshots

Section with 1 item
Section slice with 1 item

Section with 2 items
Section slice with 2 items

Section with 4 items
Screenshot 2020-02-07 at 13 58 21

Section with 5 items (plus index alsos)
Section with 5 items (plus index alsos)

Section with 6 items
Section slice with 6 items

Section slice with TV promo
Screenshot 2020-02-07 at 13 59 36

Section slice with Radio promo
Screenshot 2020-02-07 at 14 00 26

Top Stories
...

Code changes:

  • Uses a new logic utility in the FrontPageSection to create an array of all the rows that are needed for the section
  • Create a new FrontPageStoryRow container that renders the different types of row required for the UX designs
  • Grid layouts for top stories in another container (Top story row, four-row, four-row no images, leading row)
  • Add dir prop to Grid to fix RTL layouts
  • FrontPageGrid gooes up to 1008px
  • Use the generalized version of the StoryPromo
  • Use promoType prop of top, leading and regular in the StoryPromo container
  • Do not use the ImagePlaceholder in the Bulletin if this doesn't have image values
  • Add No Image Radio Bulletin story
  • Add docs/screenshots of layouts
  • Update snapshots

Related PR's


  • I have assigned myself to this PR and the corresponding issues
  • I have added labels to this PR for the relevant pod(s) affected by these changes
  • I have assigned this PR to the Simorgh project

Testing:

  • Automated (jest and/or cypress) tests added (for new features) or updated (for existing features)
  • If necessary, I have run the local E2E non-smoke tests relevant to my changes (CYPRESS_APP_ENV=local CYPRESS_SMOKE=false npm run test:e2e:interactive)
  • This PR requires manual testing

@sareh sareh added the ws-home label Jan 14, 2020
@sareh sareh self-assigned this Jan 14, 2020
@sareh sareh changed the title Desktop Front Page Layout Use Psammead Storypromo V4 for FrontPageSection Jan 22, 2020
@sareh sareh changed the title Use Psammead Storypromo V4 for FrontPageSection New Desktop Layout Jan 22, 2020
@PriyaKR PriyaKR self-assigned this Feb 25, 2020
@PriyaKR
Copy link
Contributor

PriyaKR commented Feb 25, 2020

Looks good to me but a complete device testing can be done properly when its on test env.

@sareh sareh changed the title Do not merge - New Desktop Layout New Desktop Layout Feb 25, 2020
@sareh sareh merged commit 582d91d into latest Feb 25, 2020
@sareh sareh deleted the use-grid-front-page-layout branch February 25, 2020 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Frontpage layout iteration
8 participants