Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Story promo generalisation #2937

Merged
merged 36 commits into from
Jan 22, 2020
Merged

Story promo generalisation #2937

merged 36 commits into from
Jan 22, 2020

Conversation

sareh
Copy link
Contributor

@sareh sareh commented Jan 14, 2020 •
edited by DenisHdz
Loading

Resolves #2931

Overall change: Generalises the Story Promo

Code changes:

  • RemovetopStory prop from StoryPromo - replace with promoType
  • Move Image and Text styles to different files
  • Refactor headline styles
  • Update headline styling to work for IE (removes nested media queries)
  • Add and clean up stories
  • Update prop in tests from topStory to promoType
  • Remove obsolete test (top story without image) and update snapshots
  • Integrate Leading Story Promo in the psammead-story-promo package
  • Update README
  • Remove pammed-leading-story-promo package
  • I have assigned myself to this PR and the corresponding issues
  • Automated jest tests added (for new features) or updated (for existing features)
  • This PR requires manual testing

@sareh sareh added the ws-home Tasks for the WS Home Team label Jan 14, 2020
@AlistairGempf AlistairGempf mentioned this pull request Jan 16, 2020
Closed
3 tasks
@DenisHdz DenisHdz marked this pull request as ready for review January 16, 2020 12:32
@paruchurisilpa paruchurisilpa self-assigned this Jan 22, 2020
@paruchurisilpa
Copy link
Contributor

Looks good to me...

@DenisHdz DenisHdz merged commit 0f37755 into latest Jan 22, 2020
@DenisHdz DenisHdz deleted the story-promo-generalisation branch January 22, 2020 15:11
@sareh sareh mentioned this pull request Feb 7, 2020
Merged
6 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmcculloch mmcculloch mmcculloch approved these changes

@Bopchy Bopchy Bopchy approved these changes

Assignees

@paruchurisilpa paruchurisilpa

@sareh sareh

@AlistairGempf AlistairGempf

@DenisHdz DenisHdz

Labels
ws-front-page-layout ws-home Tasks for the WS Home Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Export 3 variants of Story Promo
7 participants
@sareh @paruchurisilpa @mmcculloch @Bopchy @AlistairGempf @DenisHdz @oluoluoxenfree