Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write Cypress tests for the updated Front Page Top Story component #4056

Closed
jamesbrumpton opened this issue Oct 1, 2019 · 1 comment · Fixed by #5282
Closed

Write Cypress tests for the updated Front Page Top Story component #4056

jamesbrumpton opened this issue Oct 1, 2019 · 1 comment · Fixed by #5282
Assignees
Labels
cypress Cypress changes are required
Milestone

Comments

@jamesbrumpton
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Once the updated Front Page Top Story component design has been merged, we must write Cypress tests for the Desktop variant. An annotated image of the redesign has been added below.

We should check that the following is tested...

Section No.1

  • Headline
  • Summary
  • Image
  • Time/Datestamp

Section No.2

  • Headline
  • No Summary
  • Image
  • Time/Datestamp

Section No.3

  • Headline
  • No Summary
  • No Image
  • Time/Datestamp

Describe the solution you'd like
We need to implement Cypress tests that test for the presence of the components on the screen. Any granular testing such as styling, etc. should be done within the unit tests.

Testing notes
Making sure that the e2es pass on local, test & live.

image

This is currently blocked on this milestone - https://github.com/bbc/psammead/milestone/5
Once this has been finished the designs will then need to be implemented into Simorgh, which is when we can begin to write the Cypress tests.

@jamesbrumpton jamesbrumpton added blocked This issue should not be worked on until another internal issue is completed - see desc for details Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. cypress Cypress changes are required ws-frontpage-stream labels Oct 1, 2019
@jamesbrumpton jamesbrumpton added this to the Cypress milestone Oct 1, 2019
@sareh
Copy link
Contributor

sareh commented Jan 23, 2020

As a result of discussion with @PriyaKR

  • we will have storybook examples for slice with 1, 5, 9, 13 for the first slice and 2, 6, 10 for other slices. (New Desktop Layout #5139)
  • There will be unit tests covering all possible input values and layouts, so this does not need to be replicated at the cypress integration level. (New Desktop Layout #5139)
  • Then Cypress tests can just cover the existance of at least one promo within a slice, with the image/headline/timestamp.

@sareh sareh removed Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. ws-fp-phase3 blocked This issue should not be worked on until another internal issue is completed - see desc for details labels Jan 23, 2020
@sareh sareh added the blocked This issue should not be worked on until another internal issue is completed - see desc for details label Jan 23, 2020
@PriyaKR PriyaKR removed the blocked This issue should not be worked on until another internal issue is completed - see desc for details label Jan 27, 2020
@PriyaKR PriyaKR assigned PriyaKR and unassigned jamesbrumpton Jan 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cypress Cypress changes are required
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants