Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Spacing updates on the Story Promo List and Section Label #3058

Merged
merged 9 commits into from
Feb 5, 2020

Conversation

DenisHdz
Copy link
Contributor

@DenisHdz DenisHdz commented Feb 4, 2020

Resolves #3055

Overall change:
Update Story Promo List and Section Label spacings, raised as a part of the Desktop Front Page UX review.

Code changes:

  • Update StoryPromoList padding-top to 0 above 1008px
  • Add a margin-top of 1.5rem to the SectionLabel above 1008px

  • I have assigned myself to this PR and the corresponding issues
  • Automated jest tests added (for new features) or updated (for existing features)
  • This PR requires manual testing

@DenisHdz DenisHdz added ws-home Tasks for the WS Home Team ws-front-page-layout labels Feb 4, 2020
@DenisHdz DenisHdz self-assigned this Feb 4, 2020
Copy link
Contributor

@sareh sareh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good. My only concern is having these changes as patch versions - they'll be pulled into Simorgh and then spacing between items on the existing layout will be suboptimal:

e.g. this is what the section label change will be like:
Screenshot 2020-02-04 at 17 20 05

And this is what the Story Promo List changes will look like with the single-column layout - this page will have the headline text intersecting the keyline between promos.
Screenshot 2020-02-04 at 17 26 42

We should consider making these a breaking change so they don't automatically get pulled in.

@DenisHdz
Copy link
Contributor Author

DenisHdz commented Feb 5, 2020

These changes look good. My only concern is having these changes as patch versions - they'll be pulled into Simorgh and then spacing between items on the existing layout will be suboptimal:

e.g. this is what the section label change will be like:
Screenshot 2020-02-04 at 17 20 05

And this is what the Story Promo List changes will look like with the single-column layout - this page will have the headline text intersecting the keyline between promos.
Screenshot 2020-02-04 at 17 26 42

We should consider making these a breaking change so they don't automatically get pulled in.

Thanks for flagging this, I've bumped them to a major version 👍

Copy link
Contributor

@sareh sareh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks for the update. Looks good!

@sareh sareh mentioned this pull request Feb 5, 2020
6 tasks
Copy link
Contributor

@OlgaLyubin OlgaLyubin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ws-front-page-layout ws-home Tasks for the WS Home Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spacing updates - Story Promo List & Section Label
3 participants