-
Notifications
You must be signed in to change notification settings - Fork 54
Spacing updates on the Story Promo List and Section Label #3058
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look good. My only concern is having these changes as patch versions - they'll be pulled into Simorgh and then spacing between items on the existing layout will be suboptimal:
e.g. this is what the section label change will be like:
And this is what the Story Promo List changes will look like with the single-column layout - this page will have the headline text intersecting the keyline between promos.
We should consider making these a breaking change so they don't automatically get pulled in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Thanks for the update. Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Resolves #3055
Overall change:
Update Story Promo List and Section Label spacings, raised as a part of the Desktop Front Page UX review.
Code changes:
StoryPromoList
padding-top to 0 above 1008pxSectionLabel
above 1008px