This repository has been archived by the owner on Aug 13, 2023. It is now read-only.
Media Indicator - Pass script #3075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sareh
approved these changes
Feb 6, 2020
There was a problem hiding this comment.
👍 Thanks for this fix. When looking locally in Storybook, I see the script-specific font-size and line-height applied.
e.g. http://localhost:8180/?path=/story/components-mediaindicator-video--video-with-duration
thekp
reviewed
Feb 6, 2020
There was a problem hiding this comment.
https://github.com/bbc/psammead/pull/3075/files#diff-9caff7f606acc564ecc5cea4ea7173e6R37-R41
in this example ^ should we add an example of importing scripts and passing it as a prop, since it is a required prop?
Done :) |
thekp
approved these changes
Feb 6, 2020
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #NUMBER
Overall change:
Pass script to Media Indicator to apply the right typography.
Code changes:
scriptprop to theMediaIndicatorcomponent