Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate Top, Regular and Leading story promos in the new Frontpage layout #4500

Closed
1 task done
DenisHdz opened this issue Oct 31, 2019 · 1 comment
Closed
1 task done

Integrate Top, Regular and Leading story promos in the new Frontpage layout #4500

DenisHdz opened this issue Oct 31, 2019 · 1 comment
Assignees
@sareh @AlistairGempf @DenisHdz
Labels
ux To be reviewed by UX before merging

Comments

@DenisHdz
Copy link
Contributor

DenisHdz commented Oct 31, 2019 •
edited
Loading

Is your feature request related to a problem? Please describe.
Once the new Grid is included in Simorgh, we should integrate the Top, Regular and Leading story promos to build the new Frontpages layout.

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Testing notes
[Tester to complete]

Dev insight: Will Cypress tests be required or are unit tests sufficient? Will there be any potential regression? etc

  • This feature is expected to need manual testing.

Additional context
Add any other context or screenshots about the feature request here.
@DenisHdz DenisHdz added blocked This issue should not be worked on until another internal issue is completed - see desc for details Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. ws-frontpage-stream ux To be reviewed by UX before merging labels Oct 31, 2019
@DenisHdz DenisHdz changed the title Integrate Leading and Regular story promos Integrate Leading and Regular story promos on the new Frontpage layout Oct 31, 2019
@DenisHdz DenisHdz mentioned this issue Nov 6, 2019
Closed
1 task
@DenisHdz DenisHdz changed the title Integrate Leading and Regular story promos on the new Frontpage layout Integrate Top, Regular and Leading story promos on the new Frontpage layout Jan 20, 2020
@DenisHdz DenisHdz changed the title Integrate Top, Regular and Leading story promos on the new Frontpage layout Integrate Top, Regular and Leading story promos in the new Frontpage layout Jan 20, 2020
@DenisHdz DenisHdz removed Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. blocked This issue should not be worked on until another internal issue is completed - see desc for details labels Jan 27, 2020
This was referenced Jan 29, 2020
Merged
Closed
@sareh
Copy link
Contributor

sareh commented Feb 20, 2020

Closing this issue in favour of the main frontpage layout issue (#4562) and PR (#5139) in which it is covered.

@sareh sareh closed this as completed Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sareh sareh

@AlistairGempf AlistairGempf

@DenisHdz DenisHdz

Labels
ux To be reviewed by UX before merging
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sareh @AlistairGempf @DenisHdz