fix(accel_brake_map_calibrator): modify build error in rolling #755

wep21 · 2022-04-21T17:43:48Z

Signed-off-by: wep21 border_goldenmarket@yahoo.co.jp

Description

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

I've confirmed the contribution guidelines.
The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

The PR follows the pull request guidelines.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

codecov · 2022-04-21T17:54:47Z

Codecov Report

Merging #755 (a6ae29b) into main (a96cbd0) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##            main    #755      +/-   ##
========================================
- Coverage   9.64%   9.64%   -0.01%     
========================================
  Files        907     907              
  Lines      56521   56523       +2     
  Branches    6694    6694              
========================================
  Hits        5450    5450              
- Misses     46576   46578       +2     
  Partials    4495    4495

Flag	Coverage Δ		*Carryforward flag
differential	`0.00% <0.00%> (?)`
total	`9.64% <0.00%> (ø)`		Carriedforward from a96cbd0

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files	Coverage Δ
...map_calibrator/accel_brake_map_calibrator_node.hpp	`0.00% <ø> (ø)`
...calibrator/src/accel_brake_map_calibrator_node.cpp	`0.00% <0.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a96cbd0...a6ae29b. Read the comment docs.

* [accel brake map calibrator] sync main / .auto porting (#697) * Feature/add accel brake map calib (autowarefoundation#2287) (autowarefoundation#2342) * Feature/add accel brake map calib (autowarefoundation#2287) * add accel brake map calibrator * UpdateAccelBrakeMap:calibration_msgs->vehicle_msgs * remove dependency * remove dependency * add dependency * remove pitch reader * Update vehicle/accel_brake_map_calibrator/accel_brake_map_calibrator/README.md Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> * Update vehicle/accel_brake_map_calibrator/accel_brake_map_calibrator/README.md Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> * Update vehicle/accel_brake_map_calibrator/accel_brake_map_calibrator/README.md Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> * Update vehicle/accel_brake_map_calibrator/accel_brake_map_calibrator/README.md Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> * Update vehicle/accel_brake_map_calibrator/accel_brake_map_calibrator/README.md Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> * Update vehicle/accel_brake_map_calibrator/accel_brake_map_calibrator/README.md Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> * Update vehicle/accel_brake_map_calibrator/accel_brake_map_calibrator_button_panel/src/accel_brake_map_calibrator_button_panel.hpp Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> * Update vehicle/accel_brake_map_calibrator/accel_brake_map_calibrator/README.md Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> * unify Rviz description * remove compile option * Rviz -> RViz * Update vehicle/accel_brake_map_calibrator/accel_brake_map_calibrator/README.md Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> * add compile options * add compile options * use [[maybe_unused]] and add compile options * Update vehicle/accel_brake_map_calibrator/accel_brake_map_calibrator/README.md Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> * Update vehicle/accel_brake_map_calibrator/accel_brake_map_calibrator/launch/accel_brake_map_calibrator.launch.xml * Update vehicle/accel_brake_map_calibrator/accel_brake_map_calibrator/launch/accel_brake_map_calibrator.launch.xml * Update vehicle/accel_brake_map_calibrator/accel_brake_map_calibrator/launch/accel_brake_map_calibrator.launch.xml Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> * Fix format * Use autoware_lint_common * Use using-declarations Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp> Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> * add diagnostics to accel brake map calibrator (autowarefoundation#2308) * fix dependency (autowarefoundation#2316) * .auto porting * fix readme * fix comment Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com> Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> * [accel brake map]update readme (autowarefoundation#755) * update readme Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com> Co-authored-by: Tomoya Kimura <tomoya.kimura@tier4.jp> Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com> Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* release v0.4.0 * Support G29 controller in autoware_joy_controller (#699) * Add map for G29 controller * Add new line at end of file * Change structure of JoyConverterBase class * Rename PS4 -> DS4 * Rename controler_type -> joy_type * Set joy_type by console input * Change doc * Remap g29 controller * Remap AccelPedal -> accel, BrakePedal -> brake * Remove [autoware_joy_controller] from ROS_INFO Co-authored-by: Fumiya Watanabe <fumiya.watanabe@tier4.jp> * Change key map for G29 controller and set deadzone parameter (autowarefoundation#740) * Add missing dependencies of autoware_joy_controller (autowarefoundation#755) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * remove ROS1 packages temporarily Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * add sample ros2 packages Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * remove ROS1 packages Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * Revert "remove ROS1 packages temporarily" This reverts commit c98294b0b159fb98cd3091d34a626d06f29fdece. Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * add COLCON_IGNORE to ros1 packages Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * Rename launch files to launch.xml (#28) * Rename h files to hpp (#142) * Change includes * Rename files * Adjustments to make things compile * Other packages * Adjust copyright notice on 532 out of 699 source files (#143) * Use quotes for includes where appropriate (#144) * Use quotes for includes where appropriate * Fix lint tests * Make tests pass hopefully * Port autoware joy controller (#124) * Port Signed-off-by: Servando German Serrano <servando.german.serrano@linaro.org> * Fixed package.xml * now() to use node clock Signed-off-by: Servando German Serrano <servando.german.serrano@linaro.org> * Fix include Signed-off-by: Servando German Serrano <servando.german.serrano@linaro.org> * Clear compilation warnings Signed-off-by: Servando German Serrano <servando.german.serrano@linaro.org> * Run uncrustify on the entire Pilot.Auto codebase (#151) * Run uncrustify on the entire Pilot.Auto codebase * Exclude open PRs * [update to v0.8.0] autoware joy controller (#251) * restore filename to original for version update Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * Enable to change sensitivity (autowarefoundation#868) * Improve remote emergency stop (autowarefoundation#900) * Apply format Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Rename emergency to system_emergency in vehicle_cmd_gate Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Add emergency stop feature to vehicle_cmd_gate Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix frame_id of vehicle_cmd_gate output Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Rename /remote/emergency to /remote/emergency_stop in autoware_joy_controller Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Rename /remote/emergency to /remote/emergency_stop in remote_cmd_converter Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Rename /remote/emergency to /remote/emergency_stop in autoware_api Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Check emergency_stop timeout in remote_cmd_converter Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Ignore timeout = 0.0 Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Add config_file to arg Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Rename emergency_stop to external_emergency_stop Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Remove unnecessary lines Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Wait for first heartbeat Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Add clear_emergency_stop service Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Call clear_external_emegency_stop service from autoware_joy_controller Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Rename function Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Revert: Wait for first heartbeat Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix console messages Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Move emergency_stop diag to vehicle_cmd_gate Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Add heartbeat to vehicle_cmd_gate Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Revert: Move emergency_stop diag to vehicle_cmd_gate Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * patch in real-vehicle * Apply format Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Change default parameter Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> Co-authored-by: jpntaxi4943-autoware <proj-jpntaxi@tier4.jp> * restore file name Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * [tmp] fix build error Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * fix service Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * fix format Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * fix service usage Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * fix launch var Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> Co-authored-by: jpntaxi4943-autoware <proj-jpntaxi@tier4.jp> * Rename ROS-related .yaml to .param.yaml (#352) * Rename ROS-related .yaml to .param.yaml Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Remove prefix 'default_' of yaml files Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Rename vehicle_info.yaml to vehicle_info.param.yaml Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Rename diagnostic_aggregator's param files Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix overlooked parameters Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * remove using in global namespace (#379) * remove using in global namespace (autowarefoundation#1166) * remove using in global namespace * Revert "remove using in global namespace" This reverts commit 7f120509c9e3a036a38e84883868f6036bca23ad. * Add package namespace Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> Co-authored-by: Kenji Miyake <kenji.miyake@tier4.jp> * [autoware_joy_controller] add lint tests Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> Co-authored-by: Kenji Miyake <kenji.miyake@tier4.jp> * fix namespace (#414) * add use_sim-time option (#454) * Fix for rolling (autowarefoundation#1226) * Replace doc by description Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Replace ns by push-ros-namespace Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Make control modules components (autowarefoundation#1262) Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Remove use_sim_time for set_parameter (autowarefoundation#1260) Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Remove autoware_debug_msgs from autoware_joy_controller (autowarefoundation#1303) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Porting remote cmd selector (autowarefoundation#1286) * Feature/add remote cmd selector (autowarefoundation#1179) * Add in/out args of remote_cmd_converter.launch Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Change remote input topic of vehicle_cmd_gate Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Add msgs for remote_cmd_selector Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Add remote_cmd_selector Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Rename remote_cmd_selector to external_cmd_selector Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Remove VehicleCommand support in autoware_joy_controller Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Support external_cmd_source in autoware_joy_controller.launch (autowarefoundation#1194) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix porting miss Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * fix missing function * modify xml format * fix include guard * add callback group * modify remap name * Revert "modify remap name" This reverts commit 169cc8d28442825b1d61b0439b9892c913304527. * change topic name * use rclcpp_component * Remove autoware_debug_msgs from autoware_joy_controller Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Change default mode of autoware_joy_controller Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> Co-authored-by: Kenji Miyake <kenji.miyake@tier4.jp> * Ros2/create/external commands (autowarefoundation#1299) * add remote message * add remote commands * fix topic * remove unnecessary topic * remove unused topic * add external cmd instead * ToExternalComd * fix topic in joy con * Fix -Wunused-parameter (autowarefoundation#1836) * Fix -Wunused-parameter Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix mistake Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * fix spell * Fix lint issues Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Ignore flake8 warnings Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp> * Add autoware api (autowarefoundation#1979) * Use EmergencyState instead of deprecated EmergencyMode (autowarefoundation#2030) * Use EmergencyState instead of deprecated EmergencyMode Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Use stamped type Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * add sort-package-xml hook in pre-commit (autowarefoundation#1881) * add sort xml hook in pre-commit * change retval to exit_status * rename * add prettier plugin-xml * use early return * add license note * add tier4 license * restore prettier * change license order * move local hooks to public repo * move prettier-xml to pre-commit-hooks-ros * update version for bug-fix * apply pre-commit * Add selected external command API (autowarefoundation#2053) * submit engage with api service from joy controller (autowarefoundation#2320) * fix engagew with api * delete unused * fix for uncrustify * revive vehicle_engage * some fix * revive autoware name * fix service name * Change formatter to clang-format and black (autowarefoundation#2332) * Revert "Temporarily comment out pre-commit hooks" This reverts commit 748e9cdb145ce12f8b520bcbd97f5ff899fc28a3. * Replace ament_lint_common with autoware_lint_common Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Remove ament_cmake_uncrustify and ament_clang_format Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Apply Black Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Apply clang-format Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix build errors Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix for cpplint * Fix include double quotes to angle brackets Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Apply clang-format Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix build errors Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Add COLCON_IGNORE (#500) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * port autoware joy controller (#588) * port autoware joy controller * fix compile error * use odometry instead of twist * update launch Co-authored-by: Takayuki Murooka <takayuki.murooka@tier4.jp> * update README.md in autoware_joy_controller (#593) * update README.md * update README.md * fix typo * Update control/autoware_joy_controller/README.md Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com> * update README.md Co-authored-by: Takayuki Murooka <takayuki.murooka@tier4.jp> Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com> * fix format * ci(pre-commit): autofix Co-authored-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com> Co-authored-by: Fumiya Watanabe <fumiya.watanabe@tier4.jp> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> Co-authored-by: Nikolai Morin <nnmmgit@gmail.com> Co-authored-by: Servando <43142004+sgermanserrano@users.noreply.github.com> Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com> Co-authored-by: jpntaxi4943-autoware <proj-jpntaxi@tier4.jp> Co-authored-by: Ryohsuke Mitsudome <43976834+mitsudome-r@users.noreply.github.com> Co-authored-by: Kenji Miyake <kenji.miyake@tier4.jp> Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp> Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> Co-authored-by: Keisuke Shima <keisuke.shima@tier4.jp> Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp> Co-authored-by: Takagi, Isamu <43976882+isamu-takagi@users.noreply.github.com> Co-authored-by: Keisuke Shima <19993104+KeisukeShima@users.noreply.github.com> Co-authored-by: Takayuki Murooka <takayuki5168@gmail.com> Co-authored-by: Takayuki Murooka <takayuki.murooka@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Takeshi Miura <57553950+1222-takeshi@users.noreply.github.com>

…#755) Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

chore: sync upstream

fix(accel_brake_map_calibrator): modify build error in rolling

a6ae29b

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

wep21 requested review from esteve and kenji-miyake April 21, 2022 17:43

wep21 added ros:rolling Continuous ROS Rolling Ridley release. ros:humble ROS Humble Hawksbill release. labels Apr 21, 2022

kenji-miyake approved these changes Apr 24, 2022

View reviewed changes

wep21 merged commit 091031d into autowarefoundation:main Apr 24, 2022

wep21 deleted the fix/rolling-accel-brake-map-calibrator branch April 24, 2022 11:45

tier4-autoware-public-bot bot mentioned this pull request Apr 25, 2022

chore: sync upstream tier4/autoware.universe#39

Merged

boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022

fix(accel_brake_map_calibrator): modify build error in rolling (tier4…

a489420

…#755) Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022

fix(accel_brake_map_calibrator): modify build error in rolling (tier4…

2d50cc0

…#755) Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022

fix(accel_brake_map_calibrator): modify build error in rolling (tier4…

1b48a13

…#755) Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022

fix(accel_brake_map_calibrator): modify build error in rolling (tier4…

da7f0ff

…#755) Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

yn-mrse referenced this pull request in tier4/autoware.universe Dec 22, 2022

fix(accel_brake_map_calibrator): modify build error in rolling (#755)

63b0a55

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

kyoichi-sugahara pushed a commit to kyoichi-sugahara/autoware.universe that referenced this pull request Sep 3, 2023

Merge pull request autowarefoundation#755 from tier4/sync-upstream

2eef4c7

chore: sync upstream

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(accel_brake_map_calibrator): modify build error in rolling #755

fix(accel_brake_map_calibrator): modify build error in rolling #755

wep21 commented Apr 21, 2022

codecov bot commented Apr 21, 2022

fix(accel_brake_map_calibrator): modify build error in rolling #755

fix(accel_brake_map_calibrator): modify build error in rolling #755

Conversation

wep21 commented Apr 21, 2022

Description

Pre-review checklist for the PR author

In-review checklist for the PR reviewers

Post-review checklist for the PR author

codecov bot commented Apr 21, 2022

Codecov Report