fix(pointcloud_preprocessor): remove unused definition #2342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai>
xmfcx
requested review from
amc-nu,
miursh,
yukkysaito and
a team
as code owners
github-actions
bot
added
the
component:sensing
Codecov ReportBase: 10.45% // Head: 10.45% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2342 +/- ##
==========================================
- Coverage 10.45% 10.45% -0.01%
==========================================
Files 1252 1252
Lines 91231 91234 +3
Branches 20922 20922
==========================================
Hits 9537 9537
- Misses 71557 71560 +3
Partials 10137 10137
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
kaancolak
approved these changes
Nov 21, 2022
HansRobo
pushed a commit
to HansRobo/autoware.universe
that referenced
this pull request
Dec 16, 2022
…ation#2342) Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai> Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
kminoda
pushed a commit
to kminoda/autoware.universe
that referenced
this pull request
Jan 6, 2023
…ation#2342) Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai> Signed-off-by: kminoda <koji.minoda@tier4.jp>
YoshiRi
pushed a commit
to YoshiRi/autoware.universe
that referenced
this pull request
Jan 11, 2023
…ation#2342) Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai> Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: M. Fatih Cırıt mfc@leodrive.ai
Description
I was going through uses of
PointXYZIRADRTin the code base and found this unused definition. It doesn't change anything, small fix. If it compiles, it should be merged.Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.