feat: add CRC error monitoring to net_monitor #638

v-nakayama7440-esol · 2022-04-06T04:46:56Z

Description

Add CRC error monitoring in net_monitor.
The net_monitor monitors CRC error on Ethernet and reports Warning if error.

Tests performed

Preparation

Prepare a jig to short RxD+ and RxD- line on a network cable or connector.
Setup network as follows:

Verify `net_monitor: Network CRC Error` reports `OK` in normal operation.

Run Autoware.

Run rqt_runtime_monitor.

ros2 run rqt_runtime_monitor rqt_runtime_monitor

Verify net_monitor: Network CRC Error reports OK.

Verify no warning and error messages in a normal run.

Verify `network_crc_error` is aggregated in `resource_monitoring`.

Run rqt_robot_monitor.

ros2 run rqt_robot_monitor rqt_robot_monitor

Verify `net_monitor: Network CRC Error` reports `Warning` in abnormal operation.

Run iperf server on Autoware ECU.
```
iperf -s -u
```

Run iperf client on the host machine.

iperf -c 192.168.10.2 -u -b 30M -i 1 -t 300

Short RxD+ and RxD- and observe an error occurs by using ip command.
```
watch -n 0.1 ip -s link show
```
Verify net_monitor: Network CRC Error reports Warning.

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

I've confirmed the contribution guidelines.
The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

The PR follows the pull request guidelines.
The PR has been properly tested.
The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

There are no open discussions or they are tracked via tickets.
The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

yukkysaito · 2022-04-06T06:40:52Z

@v-nakayama7440-esol @ito-san cc @kenji-miyake
I would like to write a little more description in the readme

what can errors be detected?
when can errors be detected?

v-nakayama7440-esol · 2022-04-11T04:34:07Z

@yukkysaito cc @ito-san @kenji-miyake

・what can errors be detected?
・when can errors be detected?

Added the above information to README.md.
71c55ca

* Ros2 v0.8.0 tensorrt yolo (autowarefoundation#301) * Rename ROS-related .yaml to .param.yaml (autowarefoundation#352) * Rename ROS-related .yaml to .param.yaml Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Remove prefix 'default_' of yaml files Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Rename vehicle_info.yaml to vehicle_info.param.yaml Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Rename diagnostic_aggregator's param files Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix overlooked parameters Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * add use_sim-time option (autowarefoundation#454) * Unify Apache-2.0 license name (autowarefoundation#1242) * Remove use_sim_time for set_parameter (autowarefoundation#1260) Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Add pre-commit (autowarefoundation#1560) * add pre-commit * add pre-commit-config * add additional settings for private repository * use default pre-commit-config * update pre-commit setting * Ignore whitespace for line breaks in markdown * Update .github/workflows/pre-commit.yml Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> * exclude svg * remove pretty-format-json * add double-quote-string-fixer * consider COLCON_IGNORE file when seaching modified package * format file * pre-commit fixes * Update pre-commit.yml * Update .pre-commit-config.yaml Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> Co-authored-by: pre-commit <pre-commit@example.com> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> * Fix build error with TensorRT v8 (autowarefoundation#1612) * Fix build error with TensorRT v8 Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Fix typo Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Add markdownlint and prettier (autowarefoundation#1661) * Add markdownlint and prettier Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Ignore .param.yaml Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Apply format Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * suppress warnings for tensorrt yolo (autowarefoundation#1759) * add Werror * fix unused-parameter * Fix -Wunused-parameter (autowarefoundation#1836) * Fix -Wunused-parameter Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix mistake Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * fix spell * Fix lint issues Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Ignore flake8 warnings Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp> * Fix compiler warnings (autowarefoundation#1837) * Fix -Wunused-private-field Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix -Wunused-variable Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix -Wformat-security Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix -Winvalid-constexpr Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix -Wdelete-non-abstract-non-virtual-dtor Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix -Wdelete-abstract-non-virtual-dtor Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix -Winconsistent-missing-override Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix -Wrange-loop-construct Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix "invalid application of 'sizeof' to an incomplete type" Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Ignore -Wgnu-anonymous-struct and -Wnested-anon-types Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix lint Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Ignore -Wno-deprecated-declarations in CUDA-related packages Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix mistake Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix -Wunused-parameter Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Feature/tiny yolov4 (autowarefoundation#2193) * Add param for tiny yolov4 Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Fix missing install Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Download tiny yolov4 model Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Change formatter to clang-format and black (autowarefoundation#2332) * Revert "Temporarily comment out pre-commit hooks" This reverts commit 748e9cdb145ce12f8b520bcbd97f5ff899fc28a3. * Replace ament_lint_common with autoware_lint_common Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Remove ament_cmake_uncrustify and ament_clang_format Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Apply Black Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Apply clang-format Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix build errors Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix for cpplint * Fix include double quotes to angle brackets Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Apply clang-format Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix build errors Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Add COLCON_IGNORE (autowarefoundation#500) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Port tensorrt yolo to .auto (autowarefoundation#569) Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Update document for tensorrt yolo (autowarefoundation#619) * Update document for tensorrt yolo Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Update perception/object_recognition/detection/tensorrt_yolo/README.md * Update perception/object_recognition/detection/tensorrt_yolo/README.md * Update perception/object_recognition/detection/tensorrt_yolo/README.md * Address review: Fix citation style Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Fix build failure on jetson (autowarefoundation#638) * Fix invalid vector access (autowarefoundation#648) * Fix invalid vector access * Run pre-cmmoit Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * set image subscription qos as SensorDataQoS() explicitly (autowarefoundation#718) Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp> Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> Co-authored-by: Keisuke Shima <19993104+KeisukeShima@users.noreply.github.com> Co-authored-by: pre-commit <pre-commit@example.com> Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp> Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com>

Signed-off-by: noriyuki.h <n-hamaike@esol.co.jp> Signed-off-by: v-nakayama7440-esol <v-nakayama7440@esol.co.jp>

Signed-off-by: v-nakayama7440-esol <v-nakayama7440@esol.co.jp>

codecov · 2022-05-06T11:43:00Z

Codecov Report

Merging #638 (7f108fb) into main (0c90293) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #638      +/-   ##
==========================================
- Coverage   10.40%   10.38%   -0.03%     
==========================================
  Files        1218     1218              
  Lines       87309    87489     +180     
  Branches    20227    20227              
==========================================
  Hits         9083     9083              
- Misses      68888    69068     +180     
  Partials     9338     9338

Flag	Coverage Δ		*Carryforward flag
differential	`0.00% <0.00%> (?)`
total	`10.38% <0.00%> (ø)`		Carriedforward from 0c90293

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files	Coverage Δ
...include/system_monitor/net_monitor/net_monitor.hpp	`0.00% <0.00%> (ø)`
...tem/system_monitor/src/net_monitor/net_monitor.cpp	`0.00% <0.00%> (ø)`

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

stale · 2022-07-26T00:11:59Z

This pull request has been automatically marked as stale because it has not had recent activity.

ito-san

LGTM

ito-san · 2022-09-04T15:29:39Z

Verified in bus project with humble.

OK
Warning

* feat: add CRC error monitoring to net_monitor Signed-off-by: noriyuki.h <n-hamaike@esol.co.jp> Signed-off-by: v-nakayama7440-esol <v-nakayama7440@esol.co.jp> * add CRC error monitoring information to README.md Signed-off-by: v-nakayama7440-esol <v-nakayama7440@esol.co.jp> * ci(pre-commit): autofix Signed-off-by: noriyuki.h <n-hamaike@esol.co.jp> Signed-off-by: v-nakayama7440-esol <v-nakayama7440@esol.co.jp> Co-authored-by: noriyuki.h <n-hamaike@esol.co.jp> Co-authored-by: ito-san <57388357+ito-san@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

…n#4151) (autowarefoundation#638) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

chore: sync awf-latest

v-nakayama7440-esol force-pushed the feature/add_crc_error_monitoring branch from a4268be to ccf03c7 Compare April 6, 2022 04:55

ito-san requested review from ito-san and yukkysaito April 6, 2022 05:12

v-nakayama7440-esol force-pushed the feature/add_crc_error_monitoring branch from ccf03c7 to bf82519 Compare April 6, 2022 05:33

n-hamaike-esol and others added 2 commits May 6, 2022 20:30

feat: add CRC error monitoring to net_monitor

1476437

Signed-off-by: noriyuki.h <n-hamaike@esol.co.jp> Signed-off-by: v-nakayama7440-esol <v-nakayama7440@esol.co.jp>

add CRC error monitoring information to README.md

90bc4d0

Signed-off-by: v-nakayama7440-esol <v-nakayama7440@esol.co.jp>

wep21 force-pushed the feature/add_crc_error_monitoring branch from 71c55ca to 90bc4d0 Compare May 6, 2022 11:30

wep21 added the component:system System design and integration. (auto-assigned) label May 26, 2022

stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label Jul 26, 2022

ito-san mentioned this pull request Sep 2, 2022

Add some diagnostic information to be monitored in system_monitor #1770

Closed

3 tasks

ito-san assigned v-nakayama7440-esol Sep 2, 2022

stale bot removed the status:stale Inactive or outdated issues. (auto-assigned) label Sep 2, 2022

ito-san added status:stale Inactive or outdated issues. (auto-assigned) type:new-feature New functionalities or additions, feature requests. and removed status:stale Inactive or outdated issues. (auto-assigned) labels Sep 2, 2022

ito-san approved these changes Sep 4, 2022

View reviewed changes

ito-san and others added 2 commits September 5, 2022 00:36

Merge branch 'main' into feature/add_crc_error_monitoring

db0b8a5

ci(pre-commit): autofix

7f108fb

ito-san merged commit 728875e into autowarefoundation:main Sep 4, 2022

tier4-autoware-public-bot bot mentioned this pull request Sep 5, 2022

chore: sync upstream tier4/autoware.universe#100

Merged

TomohitoAndo pushed a commit to TomohitoAndo/autoware.universe that referenced this pull request Jul 28, 2023

feat(start_planner): add option for lane departure (autowarefoundatio…

29db340

…n#4151) (autowarefoundation#638) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

kyoichi-sugahara pushed a commit that referenced this pull request Sep 16, 2023

Merge pull request #638 from tier4/sync-awf-latest

1f8d51c

chore: sync awf-latest

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add CRC error monitoring to net_monitor #638

feat: add CRC error monitoring to net_monitor #638

v-nakayama7440-esol commented Apr 6, 2022 •

edited by ito-san

Loading

yukkysaito commented Apr 6, 2022

v-nakayama7440-esol commented Apr 11, 2022

codecov bot commented May 6, 2022 •

edited

Loading

stale bot commented Jul 26, 2022

ito-san left a comment

ito-san commented Sep 4, 2022

feat: add CRC error monitoring to net_monitor #638

feat: add CRC error monitoring to net_monitor #638

Conversation

v-nakayama7440-esol commented Apr 6, 2022 • edited by ito-san Loading

Description

Related links

Tests performed

Preparation

Verify net_monitor: Network CRC Error reports OK in normal operation.

Verify no warning and error messages in a normal run.

Verify network_crc_error is aggregated in resource_monitoring.

Verify net_monitor: Network CRC Error reports Warning in abnormal operation.

Notes for reviewers

Pre-review checklist for the PR author

In-review checklist for the PR reviewers

Post-review checklist for the PR author

yukkysaito commented Apr 6, 2022

v-nakayama7440-esol commented Apr 11, 2022

codecov bot commented May 6, 2022 • edited Loading

Codecov Report

stale bot commented Jul 26, 2022

ito-san left a comment

Choose a reason for hiding this comment

ito-san commented Sep 4, 2022

v-nakayama7440-esol commented Apr 6, 2022 •

edited by ito-san

Loading

Verify `net_monitor: Network CRC Error` reports `OK` in normal operation.

Verify `network_crc_error` is aggregated in `resource_monitoring`.

Verify `net_monitor: Network CRC Error` reports `Warning` in abnormal operation.

codecov bot commented May 6, 2022 •

edited

Loading