Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pointpainting): add a pointpainting package for the perception #569

Closed

Conversation

tzhong518
Copy link
Contributor

Description

We would like to add a pointpainting package for the perception.
At present, we plan to develop it as an independent package for convenience. In the camera_lidar_fusion_based_detection.lauch, choosing 'pointpainting' as 'lidar_detection_model' would call the pointpainting.launch.
But since part of the code will be duplicate with lidar_centerpoint and roi_cluster_fusion package, there might be better solutions.
Please give us your advice. Thank you very much.

Related links

Tests performed

Notes for reviewers

Pre-review checklist for the PR author

PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

Reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has the write access can merge the PR.

TakumiKozaka-T4 pushed a commit to TakumiKozaka-T4/autoware.universe that referenced this pull request Mar 23, 2022
* Ros2 v0.8.0 tensorrt yolo (autowarefoundation#301)

* Rename ROS-related .yaml to .param.yaml (autowarefoundation#352)

* Rename ROS-related .yaml to .param.yaml

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Remove prefix 'default_' of yaml files

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Rename vehicle_info.yaml to vehicle_info.param.yaml

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Rename diagnostic_aggregator's param files

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix overlooked parameters

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* add use_sim-time option (autowarefoundation#454)

* Unify Apache-2.0 license name (autowarefoundation#1242)

* Remove use_sim_time for set_parameter (autowarefoundation#1260)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Add pre-commit (autowarefoundation#1560)

* add pre-commit

* add pre-commit-config

* add additional settings for private repository

* use default pre-commit-config

* update pre-commit setting

* Ignore whitespace for line breaks in markdown

* Update .github/workflows/pre-commit.yml

Co-authored-by: Kazuki Miyahara <kmiya@outlook.com>

* exclude svg

* remove pretty-format-json

* add double-quote-string-fixer

* consider COLCON_IGNORE file when seaching modified package

* format file

* pre-commit fixes

* Update pre-commit.yml

* Update .pre-commit-config.yaml

Co-authored-by: Kazuki Miyahara <kmiya@outlook.com>
Co-authored-by: pre-commit <pre-commit@example.com>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

* Fix build error with TensorRT v8 (autowarefoundation#1612)

* Fix build error with TensorRT v8

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Fix typo

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Add markdownlint and prettier (autowarefoundation#1661)

* Add markdownlint and prettier

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Ignore .param.yaml

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Apply format

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* suppress warnings for tensorrt yolo (autowarefoundation#1759)

* add Werror

* fix unused-parameter

* Fix -Wunused-parameter (autowarefoundation#1836)

* Fix -Wunused-parameter

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix mistake

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* fix spell

* Fix lint issues

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Ignore flake8 warnings

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp>

* Fix compiler warnings (autowarefoundation#1837)

* Fix -Wunused-private-field

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix -Wunused-variable

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix -Wformat-security

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix -Winvalid-constexpr

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix -Wdelete-non-abstract-non-virtual-dtor

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix -Wdelete-abstract-non-virtual-dtor

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix -Winconsistent-missing-override

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix -Wrange-loop-construct

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix "invalid application of 'sizeof' to an incomplete type"

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Ignore -Wgnu-anonymous-struct and -Wnested-anon-types

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix lint

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Ignore -Wno-deprecated-declarations in CUDA-related packages

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix mistake

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix -Wunused-parameter

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Feature/tiny yolov4 (autowarefoundation#2193)

* Add param for tiny yolov4

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Fix missing install

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Download tiny yolov4 model

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Change formatter to clang-format and black (autowarefoundation#2332)

* Revert "Temporarily comment out pre-commit hooks"

This reverts commit 748e9cdb145ce12f8b520bcbd97f5ff899fc28a3.

* Replace ament_lint_common with autoware_lint_common

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Remove ament_cmake_uncrustify and ament_clang_format

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Apply Black

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Apply clang-format

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix build errors

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix for cpplint

* Fix include double quotes to angle brackets

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Apply clang-format

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix build errors

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Add COLCON_IGNORE (autowarefoundation#500)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Port tensorrt yolo to .auto (autowarefoundation#569)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Update document for tensorrt yolo (autowarefoundation#619)

* Update document for tensorrt yolo

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Update perception/object_recognition/detection/tensorrt_yolo/README.md

* Update perception/object_recognition/detection/tensorrt_yolo/README.md

* Update perception/object_recognition/detection/tensorrt_yolo/README.md

* Address review: Fix citation style

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Fix build failure on jetson (autowarefoundation#638)

* Fix invalid vector access (autowarefoundation#648)

* Fix invalid vector access

* Run pre-cmmoit

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* set image subscription qos as SensorDataQoS() explicitly (autowarefoundation#718)

Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp>
Co-authored-by: Kazuki Miyahara <kmiya@outlook.com>
Co-authored-by: Keisuke Shima <19993104+KeisukeShima@users.noreply.github.com>
Co-authored-by: pre-commit <pre-commit@example.com>
Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp>
Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Mar 23, 2022

Codecov Report

Merging #569 (99b7877) into main (580565a) will decrease coverage by 9.55%.
The diff coverage is 0.00%.

❗ Current head 99b7877 differs from pull request most recent head bd9b28b. Consider uploading reports for the commit bd9b28b to get more accurate results

@@           Coverage Diff            @@
##            main    #569      +/-   ##
========================================
- Coverage   9.55%   0.00%   -9.56%     
========================================
  Files        921       2     -919     
  Lines      57196     110   -57086     
  Branches    6830       0    -6830     
========================================
- Hits        5465       0    -5465     
+ Misses     47229     110   -47119     
+ Partials    4502       0    -4502     
Flag Coverage Δ
total ?
Impacted Files Coverage Δ
...ption/pointpainting/include/pointpainting/node.hpp 0.00% <0.00%> (ø)
perception/pointpainting/src/node.cpp 0.00% <0.00%> (ø)
...tlier_filter/voxel_grid_outlier_filter_nodelet.cpp
localization/stop_filter/src/stop_filter_node.cpp
...ion/lidar_centerpoint/lib/src/tensorrt_wrapper.cpp
...joy_controller/joy_converter/p65_joy_converter.hpp
...de/behavior_path_planner/behavior_tree_manager.hpp
...acle_avoidance_planner/src/debug_visualization.cpp
...ents/node_main_detected_object_feature_remover.cpp
...ollision_checker/util/create_vehicle_footprint.hpp
... and 913 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 580565a...bd9b28b. Read the comment docs.

@miursh miursh requested review from yukkysaito, miursh and yukke42 March 23, 2022 10:53
@miursh
Copy link
Contributor

miursh commented Mar 23, 2022

@yukkysaito @yukke42
As described in PR comment, we'are planning to implement Pointpainting package with launchers created in this PR.
At this time, pointpaintig package is separated from centerpoint, roi_cluster_fusion since centerpoint and roi fusion have also being changed. If you have any suggestions, please make a comment.

@yukkysaito
Copy link
Contributor

Thank you
Since roi_cluster_fusion, roi_object_fusion and pointpaing are almost the same code, pls integrate them into a package called image_projection_based_fusion. @yukke42 is currently working on it, so please share your work with each other.

@yukke42
Copy link
Contributor

yukke42 commented Mar 24, 2022

@miursh
I will create a new package image_projection_based_fusion and plan that poinpainting is in this package and uses lidar_centerpoint as a shared library. But, both packages aren't merged yet, so it's better to implement it by reference to roi_cluster_fusion and here and integrate after both packages are merged.

@yukke42
Copy link
Contributor

yukke42 commented Mar 28, 2022

@tzhong518 cc. @miursh
I created a new package image_projection_based_fusion and please take a plan to add pointpainting to this package. #548

@aohsato aohsato added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Apr 14, 2022
tzhong518 and others added 12 commits April 20, 2022 17:07
Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>
Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>
Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>
Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>
Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>
Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>
Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>
Signed-off-by: tzhong518 <sworgun@gmail.com>
@tzhong518 tzhong518 force-pushed the feature/pointpainting branch from d219d04 to 85d7e07 Compare May 20, 2022 07:08
tzhong518 added 3 commits May 20, 2022 16:27
Signed-off-by: tzhong518 <sworgun@gmail.com>
Signed-off-by: tzhong518 <sworgun@gmail.com>
Signed-off-by: tzhong518 <sworgun@gmail.com>
@miursh
Copy link
Contributor

miursh commented Jun 1, 2022

Close this PR since it get old and the new PR is created

@miursh miursh closed this Jun 1, 2022
0x126 pushed a commit to mkuri/autoware.universe that referenced this pull request Jun 14, 2023
…utowarefoundation#569)

chore: change yaw_rate_diff_threshold from 0.07 to 0.14

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
kyoichi-sugahara pushed a commit that referenced this pull request Sep 16, 2023
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
iwatake2222 pushed a commit to iwatake2222/autoware.universe that referenced this pull request Jan 17, 2025
…owarefoundation#569)

* hysteresis_factor_expand_rate

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* style(pre-commit): autofix

* add hysteresis_factor_expand_rate in SafetyCheckParams

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* delete setting files

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* revert unnecessary change

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

---------

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants