-
Notifications
You must be signed in to change notification settings - Fork 664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(ekf_localizer): add a warning class #1837
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1837 +/- ##
==========================================
- Coverage 10.44% 10.41% -0.03%
==========================================
Files 1221 1222 +1
Lines 87728 87926 +198
Branches 20493 20653 +160
==========================================
Hits 9160 9160
- Misses 69091 69274 +183
- Partials 9477 9492 +15
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Would you mind explaining the aim of this PR more concretely? I personally think that the original warnings using RCLCPP_WARNs is also not too bad. What do you think? |
For people who read the code, for example, the line RCLCPP_WARN_THROTTLE(
get_logger(), *get_clock(), std::chrono::milliseconds(1000).count(),
"Twist delay exceeds the compensation limit, ignored. delay: %f[s], limit = "
"extend_state_step * ekf_dt : %f [s]",
delay_time, extend_state_step_ * ekf_dt_); is too noisy. For readers, it is not necessary to know how to obtain the logger from the node and clock, i.e., The basic strategy to improve readability and maintainability is to improve cohesion, and it is what I did here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
* refactor(ekf_localizer): add a warning class to simplify displaying messages
* refactor(ekf_localizer): add a warning class to simplify displaying messages
* refactor(ekf_localizer): add a warning class to simplify displaying messages
* refactor(ekf_localizer): add a warning class to simplify displaying messages
Description
Add a warning class to simplify displaying messages
Related links
Tests performed
Tests need to be performed to validate the displayed messages, but they should be done in another PR.
Notes for reviewers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.