Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(avoidance): can set stop/move judge threshold for each object class #3998

Merged

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Jun 16, 2023

Description

The avoidance module has flags whether avoid or not for each object class. In this PR, I added following threshold to judge the object is moveing or not for each object class.

  • stopped_speed_threshold
  • moving_time_threshold
    // if following condition are satisfied, ignored the objects as moving objects.
    // 1. speed is higher than threshold.
    // 2. keep that speed longer than the time threshold.

Tests performed

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jun 16, 2023
@codecov
Copy link

codecov bot commented Jun 16, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (15325f6) 14.41% compared to head (0c96010) 14.41%.

❗ Current head 0c96010 differs from pull request most recent head c959db2. Consider uploading reports for the commit c959db2 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3998      +/-   ##
==========================================
- Coverage   14.41%   14.41%   -0.01%     
==========================================
  Files        1456     1456              
  Lines      102763   102763              
  Branches    29785    29783       -2     
==========================================
- Hits        14815    14814       -1     
- Misses      71765    71767       +2     
+ Partials    16183    16182       -1     
Flag Coverage Δ *Carryforward flag
differential 12.82% <0.00%> (?)
total 14.41% <ø> (+<0.01%) ⬆️ Carriedforward from 2465bbf

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
..._planner/utils/avoidance/avoidance_module_data.hpp 0.00% <ø> (ø)
...or_path_planner/src/behavior_path_planner_node.cpp 18.35% <0.00%> (+0.04%) ⬆️
...ehavior_path_planner/src/utils/avoidance/utils.cpp 2.73% <0.00%> (-0.02%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@satoshi-ota satoshi-ota force-pushed the feat/set-threshold-independently branch from 0c96010 to c959db2 Compare June 19, 2023 04:25
@satoshi-ota satoshi-ota enabled auto-merge (squash) June 19, 2023 04:41
@kosuke55 kosuke55 disabled auto-merge June 19, 2023 04:51
@kosuke55 kosuke55 merged commit 7354014 into autowarefoundation:main Jun 19, 2023
@satoshi-ota satoshi-ota deleted the feat/set-threshold-independently branch June 19, 2023 04:51
satoshi-ota added a commit to satoshi-ota/autoware.universe that referenced this pull request Jun 20, 2023
…ass (autowarefoundation#3998)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
satoshi-ota added a commit to tier4/autoware.universe that referenced this pull request Jun 23, 2023
…ass (autowarefoundation#3998)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
tkimura4 pushed a commit to tier4/autoware.universe that referenced this pull request Jun 26, 2023
* feat(avoidance): add hysteresis to avoidance necessity check (autowarefoundation#3880)

* feat(avoidance): add hysteresis factor to avoid necessity check

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* feat(avoidance_by_lc): add hysteresis factor to avoid necessity check

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* refactor(utils): use lambda

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

---------

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* feat(avoidance): improve stop behavior under decel/jerk constraints option (autowarefoundation#3978)

* feat(avoidance): add option to decel within constraints

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* chore(avoidance): add comments

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* refactor(utils): merge similar functions

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

---------

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* feat(avoidance): can set stop/move judge threshold for each object class (autowarefoundation#3998)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* feat(avoidance): ignore behind unavoidable objects (autowarefoundation#4034)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* feat(avoidance): improve avoidance judgement logic for pedestrian & bicycle (autowarefoundation#4016)

* feat(avoidance): don't avoid pedestrian and bicycle on crosswalk

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* feat(avoidance): avoid pedestrian/bicycle near centerline

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* feat(utils): use geometry distance

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* chore(avoidance): add comment

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

---------

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(avoidance): ignore objects less than execution threshold (autowarefoundation#3595)

fix(avoidance): ignore objects whose shift length is less than execution threshold

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(avoidance): not init rtc status at onProcessEntry (autowarefoundation#3804)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(avoidance): update logic to keep waiting approval (autowarefoundation#4059)

* revert "fix(avoidance): don't clear waiting approval if raw shift line exists (autowarefoundation#4012)"

This reverts commit 8577563.

* fix(avoidance): update logic to keep waiting approval

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

---------

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(avoidance): fix invalid cherry pick

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

---------

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants