-
Notifications
You must be signed in to change notification settings - Fork 667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(avoidance): ignore objects less than execution threshold #3595
Merged
satoshi-ota
merged 1 commit into
autowarefoundation:main
from
satoshi-ota:fix/ignore-objects-less-than-execution-threshold
May 19, 2023
Merged
fix(avoidance): ignore objects less than execution threshold #3595
satoshi-ota
merged 1 commit into
autowarefoundation:main
from
satoshi-ota:fix/ignore-objects-less-than-execution-threshold
May 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
label
Apr 29, 2023
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #3595 +/- ##
==========================================
- Coverage 15.53% 15.49% -0.05%
==========================================
Files 1333 1333
Lines 94707 94978 +271
Branches 30064 30254 +190
==========================================
+ Hits 14711 14715 +4
- Misses 63908 64168 +260
- Partials 16088 16095 +7
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
satoshi-ota
changed the title
Fix/ignore objects less than execution threshold
fix(avoidance): ignore objects less than execution threshold
Apr 30, 2023
satoshi-ota
force-pushed
the
fix/ignore-objects-less-than-execution-threshold
branch
from
May 8, 2023 01:57
1a922e7
to
a2abc68
Compare
satoshi-ota
requested review from
rej55,
kosuke55,
kyoichi-sugahara,
shmpwk,
taikitanaka3,
TakaHoribe,
takayuki5168,
tkimura4,
purewater0901,
zulfaqar-azmi-t4 and
a team
as code owners
May 8, 2023 01:57
rej55
approved these changes
May 19, 2023
…ion threshold Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
satoshi-ota
force-pushed
the
fix/ignore-objects-less-than-execution-threshold
branch
from
May 19, 2023 06:31
a2abc68
to
acea264
Compare
satoshi-ota
added a commit
to tier4/autoware.universe
that referenced
this pull request
Jun 23, 2023
…efoundation#3595) fix(avoidance): ignore objects whose shift length is less than execution threshold Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
tkimura4
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Jun 26, 2023
* feat(avoidance): add hysteresis to avoidance necessity check (autowarefoundation#3880) * feat(avoidance): add hysteresis factor to avoid necessity check Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * feat(avoidance_by_lc): add hysteresis factor to avoid necessity check Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * refactor(utils): use lambda Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> --------- Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * feat(avoidance): improve stop behavior under decel/jerk constraints option (autowarefoundation#3978) * feat(avoidance): add option to decel within constraints Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * chore(avoidance): add comments Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * refactor(utils): merge similar functions Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> --------- Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * feat(avoidance): can set stop/move judge threshold for each object class (autowarefoundation#3998) Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * feat(avoidance): ignore behind unavoidable objects (autowarefoundation#4034) Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * feat(avoidance): improve avoidance judgement logic for pedestrian & bicycle (autowarefoundation#4016) * feat(avoidance): don't avoid pedestrian and bicycle on crosswalk Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * feat(avoidance): avoid pedestrian/bicycle near centerline Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * feat(utils): use geometry distance Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * chore(avoidance): add comment Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> --------- Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * fix(avoidance): ignore objects less than execution threshold (autowarefoundation#3595) fix(avoidance): ignore objects whose shift length is less than execution threshold Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * fix(avoidance): not init rtc status at onProcessEntry (autowarefoundation#3804) Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * fix(avoidance): update logic to keep waiting approval (autowarefoundation#4059) * revert "fix(avoidance): don't clear waiting approval if raw shift line exists (autowarefoundation#4012)" This reverts commit 8577563. * fix(avoidance): update logic to keep waiting approval Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> --------- Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * fix(avoidance): fix invalid cherry pick Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> --------- Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The avoidance module has the parameter
lateral_execution_threshold
, and it never throws RTC request for shift lines that are less than this threshold.On the other hand, the module doesn't ignore object whose shift line is smaller than threshold and keeps stopping in front of it until the RTC request is approved. It is inconsistent and causes stuck.
In this PR, the module ignore objects whose shift length is less than
avoidance_execution_lateral_threshold
explicitly.Tests performed
Effects on system behavior
Nothing.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.