Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(avoidance): ignore objects less than execution threshold #3595

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Apr 29, 2023

Description

The avoidance module has the parameter lateral_execution_threshold, and it never throws RTC request for shift lines that are less than this threshold.

On the other hand, the module doesn't ignore object whose shift line is smaller than threshold and keeps stopping in front of it until the RTC request is approved. It is inconsistent and causes stuck.

rviz_screenshot_2023_04_29-16_24_31

In this PR, the module ignore objects whose shift length is less than avoidance_execution_lateral_threshold explicitly.

rviz_screenshot_2023_04_29-16_13_09

Tests performed

  • PASS avoidance scenarios.
  • PASS TIER IV internal scenairos.

Effects on system behavior

Nothing.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Apr 29, 2023
@codecov
Copy link

codecov bot commented Apr 29, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.05 ⚠️

Comparison is base (2cd0bcb) 15.53% compared to head (acea264) 15.49%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3595      +/-   ##
==========================================
- Coverage   15.53%   15.49%   -0.05%     
==========================================
  Files        1333     1333              
  Lines       94707    94978     +271     
  Branches    30064    30254     +190     
==========================================
+ Hits        14711    14715       +4     
- Misses      63908    64168     +260     
- Partials    16088    16095       +7     
Flag Coverage Δ *Carryforward flag
differential 13.22% <0.00%> (?)
total 15.53% <ø> (+<0.01%) ⬆️ Carriedforward from 2cd0bcb

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
..._interface/include/qp_interface/osqp_interface.hpp 0.00% <ø> (ø)
...qp_interface/include/qp_interface/qp_interface.hpp 0.00% <ø> (ø)
common/qp_interface/src/osqp_interface.cpp 30.81% <ø> (ø)
common/qp_interface/src/qp_interface.cpp 38.88% <ø> (ø)
common/qp_interface/test/test_osqp_interface.cpp 13.92% <ø> (ø)
...th_planner/scene_module/scene_module_interface.hpp 30.59% <ø> (ø)
...er/src/scene_module/avoidance/avoidance_module.cpp 3.64% <0.00%> (-0.01%) ⬇️
...ehavior_path_planner/src/utils/avoidance/utils.cpp 3.55% <0.00%> (-0.04%) ⬇️
...lude/obstacle_cruise_planner/planner_interface.hpp 19.23% <ø> (ø)
planning/obstacle_cruise_planner/src/node.cpp 13.36% <ø> (+0.08%) ⬆️
... and 1 more

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@satoshi-ota satoshi-ota changed the title Fix/ignore objects less than execution threshold fix(avoidance): ignore objects less than execution threshold Apr 30, 2023
@satoshi-ota satoshi-ota force-pushed the fix/ignore-objects-less-than-execution-threshold branch from 1a922e7 to a2abc68 Compare May 8, 2023 01:57
@satoshi-ota satoshi-ota marked this pull request as ready for review May 8, 2023 01:57
…ion threshold

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@satoshi-ota satoshi-ota force-pushed the fix/ignore-objects-less-than-execution-threshold branch from a2abc68 to acea264 Compare May 19, 2023 06:31
@satoshi-ota satoshi-ota enabled auto-merge (squash) May 19, 2023 06:32
@satoshi-ota satoshi-ota merged commit d8029ef into autowarefoundation:main May 19, 2023
@satoshi-ota satoshi-ota deleted the fix/ignore-objects-less-than-execution-threshold branch May 19, 2023 07:36
satoshi-ota added a commit to tier4/autoware.universe that referenced this pull request Jun 23, 2023
…efoundation#3595)

fix(avoidance): ignore objects whose shift length is less than execution threshold

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
tkimura4 pushed a commit to tier4/autoware.universe that referenced this pull request Jun 26, 2023
* feat(avoidance): add hysteresis to avoidance necessity check (autowarefoundation#3880)

* feat(avoidance): add hysteresis factor to avoid necessity check

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* feat(avoidance_by_lc): add hysteresis factor to avoid necessity check

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* refactor(utils): use lambda

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

---------

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* feat(avoidance): improve stop behavior under decel/jerk constraints option (autowarefoundation#3978)

* feat(avoidance): add option to decel within constraints

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* chore(avoidance): add comments

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* refactor(utils): merge similar functions

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

---------

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* feat(avoidance): can set stop/move judge threshold for each object class (autowarefoundation#3998)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* feat(avoidance): ignore behind unavoidable objects (autowarefoundation#4034)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* feat(avoidance): improve avoidance judgement logic for pedestrian & bicycle (autowarefoundation#4016)

* feat(avoidance): don't avoid pedestrian and bicycle on crosswalk

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* feat(avoidance): avoid pedestrian/bicycle near centerline

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* feat(utils): use geometry distance

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* chore(avoidance): add comment

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

---------

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(avoidance): ignore objects less than execution threshold (autowarefoundation#3595)

fix(avoidance): ignore objects whose shift length is less than execution threshold

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(avoidance): not init rtc status at onProcessEntry (autowarefoundation#3804)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(avoidance): update logic to keep waiting approval (autowarefoundation#4059)

* revert "fix(avoidance): don't clear waiting approval if raw shift line exists (autowarefoundation#4012)"

This reverts commit 8577563.

* fix(avoidance): update logic to keep waiting approval

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

---------

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(avoidance): fix invalid cherry pick

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

---------

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants