-
Notifications
You must be signed in to change notification settings - Fork 667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(avoidance): improve stop behavior under decel/jerk constraints option #3978
feat(avoidance): improve stop behavior under decel/jerk constraints option #3978
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #3978 +/- ##
=======================================
Coverage 14.40% 14.40%
=======================================
Files 1456 1456
Lines 102750 102769 +19
Branches 29784 29787 +3
=======================================
+ Hits 14801 14808 +7
- Misses 71771 71777 +6
- Partials 16178 16184 +6
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
1549ca3
to
a6893d1
Compare
planning/behavior_path_planner/include/behavior_path_planner/utils/avoidance/helper.hpp
Outdated
Show resolved
Hide resolved
planning/behavior_path_planner/src/scene_module/avoidance/avoidance_module.cpp
Show resolved
Hide resolved
planning/behavior_path_planner/src/scene_module/avoidance/avoidance_module.cpp
Show resolved
Hide resolved
planning/behavior_path_planner/src/scene_module/avoidance/avoidance_module.cpp
Show resolved
Hide resolved
planning/behavior_path_planner/src/scene_module/avoidance/avoidance_module.cpp
Show resolved
Hide resolved
planning/behavior_path_planner/src/scene_module/avoidance/avoidance_module.cpp
Show resolved
Hide resolved
planning/behavior_path_planner/src/scene_module/avoidance/avoidance_module.cpp
Outdated
Show resolved
Hide resolved
planning/behavior_path_planner/include/behavior_path_planner/utils/avoidance/utils.hpp
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
a6893d1
to
0d099f4
Compare
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
964095c
to
23940ea
Compare
…ption (autowarefoundation#3978) * feat(avoidance): add option to decel within constraints Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * chore(avoidance): add comments Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * refactor(utils): merge similar functions Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> --------- Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
…ption (autowarefoundation#3978) * feat(avoidance): add option to decel within constraints Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * chore(avoidance): add comments Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * refactor(utils): merge similar functions Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> --------- Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
* feat(avoidance): add hysteresis to avoidance necessity check (autowarefoundation#3880) * feat(avoidance): add hysteresis factor to avoid necessity check Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * feat(avoidance_by_lc): add hysteresis factor to avoid necessity check Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * refactor(utils): use lambda Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> --------- Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * feat(avoidance): improve stop behavior under decel/jerk constraints option (autowarefoundation#3978) * feat(avoidance): add option to decel within constraints Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * chore(avoidance): add comments Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * refactor(utils): merge similar functions Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> --------- Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * feat(avoidance): can set stop/move judge threshold for each object class (autowarefoundation#3998) Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * feat(avoidance): ignore behind unavoidable objects (autowarefoundation#4034) Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * feat(avoidance): improve avoidance judgement logic for pedestrian & bicycle (autowarefoundation#4016) * feat(avoidance): don't avoid pedestrian and bicycle on crosswalk Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * feat(avoidance): avoid pedestrian/bicycle near centerline Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * feat(utils): use geometry distance Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * chore(avoidance): add comment Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> --------- Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * fix(avoidance): ignore objects less than execution threshold (autowarefoundation#3595) fix(avoidance): ignore objects whose shift length is less than execution threshold Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * fix(avoidance): not init rtc status at onProcessEntry (autowarefoundation#3804) Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * fix(avoidance): update logic to keep waiting approval (autowarefoundation#4059) * revert "fix(avoidance): don't clear waiting approval if raw shift line exists (autowarefoundation#4012)" This reverts commit 8577563. * fix(avoidance): update logic to keep waiting approval Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> --------- Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * fix(avoidance): fix invalid cherry pick Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> --------- Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Description
The avoidance module has option
use_constraints_for_decel
to decelerate within decel/jerk constrains but sometimes the ego doesn't stop at expected position even if stop distance is feasible because of the control error.simplescreenrecorder-2023-06-15_08.01.17.mp4
So, in this PR, I added latch logic to judge whether the ego can stop at the expected position or not.
simplescreenrecorder-2023-06-15_10.14.16.mp4
simplescreenrecorder-2023-06-15_10.14.59.mp4
Tests performed
use_constraints_for_decel=fasle
)Effects on system behavior
Nothing.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.