Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(simulator_compatibility_test): test codes adjustments #1439

Conversation

SoohyeokPark-MORAI
Copy link
Contributor

Description

Two test cases are redefined in the simulation working group to eliminate some ambiguities.

Related links

issue link

Test performed

Run the test codes with MORAI SIM: Drive

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

1. organizing test structure
2. renaming modules

Signed-off-by: SoohyeokPark-MORAI <shpark.morai@gmail.com>
This reverts commit e79f976.

Signed-off-by: SoohyeokPark-MORAI <shpark.morai@gmail.com>
@SoohyeokPark-MORAI SoohyeokPark-MORAI force-pushed the feature/sim_compatibility_test_adjustments branch from cbb2b37 to 6742873 Compare July 27, 2022 04:37
@SoohyeokPark-MORAI SoohyeokPark-MORAI force-pushed the feature/sim_compatibility_test_adjustments branch from 6742873 to a2e35ae Compare July 27, 2022 04:51
Signed-off-by: SoohyeokPark-MORAI <shpark.morai@gmail.com>
@WJaworskiRobotec WJaworskiRobotec self-requested a review August 2, 2022 09:57
@WJaworskiRobotec
Copy link
Contributor

Code looks fine. I've tested set of tests with AWSIM, everything passed.

Copy link
Contributor

@WJaworskiRobotec WJaworskiRobotec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. Successfully tested with AWSIM

@WJaworskiRobotec WJaworskiRobotec merged commit c8eb712 into autowarefoundation:main Aug 2, 2022
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
* [refactoring] simulator compatibility test

1. organizing test structure
2. renaming modules

Signed-off-by: SoohyeokPark-MORAI <shpark.morai@gmail.com>

* Revert "[refactoring] simulator compatibility test"

This reverts commit e79f976.

Signed-off-by: SoohyeokPark-MORAI <shpark.morai@gmail.com>

* test codes adjustments

Signed-off-by: SoohyeokPark-MORAI <shpark.morai@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
* [refactoring] simulator compatibility test

1. organizing test structure
2. renaming modules

Signed-off-by: SoohyeokPark-MORAI <shpark.morai@gmail.com>

* Revert "[refactoring] simulator compatibility test"

This reverts commit e79f976.

Signed-off-by: SoohyeokPark-MORAI <shpark.morai@gmail.com>

* test codes adjustments

Signed-off-by: SoohyeokPark-MORAI <shpark.morai@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
* [refactoring] simulator compatibility test

1. organizing test structure
2. renaming modules

Signed-off-by: SoohyeokPark-MORAI <shpark.morai@gmail.com>

* Revert "[refactoring] simulator compatibility test"

This reverts commit e79f976.

Signed-off-by: SoohyeokPark-MORAI <shpark.morai@gmail.com>

* test codes adjustments

Signed-off-by: SoohyeokPark-MORAI <shpark.morai@gmail.com>
yukke42 pushed a commit to tzhong518/autoware.universe that referenced this pull request Oct 14, 2022
…oundation#1439)

* [refactoring] simulator compatibility test

1. organizing test structure
2. renaming modules

Signed-off-by: SoohyeokPark-MORAI <shpark.morai@gmail.com>

* Revert "[refactoring] simulator compatibility test"

This reverts commit e79f976.

Signed-off-by: SoohyeokPark-MORAI <shpark.morai@gmail.com>

* test codes adjustments

Signed-off-by: SoohyeokPark-MORAI <shpark.morai@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
* [refactoring] simulator compatibility test

1. organizing test structure
2. renaming modules

Signed-off-by: SoohyeokPark-MORAI <shpark.morai@gmail.com>

* Revert "[refactoring] simulator compatibility test"

This reverts commit e79f976.

Signed-off-by: SoohyeokPark-MORAI <shpark.morai@gmail.com>

* test codes adjustments

Signed-off-by: SoohyeokPark-MORAI <shpark.morai@gmail.com>
technolojin pushed a commit to technolojin/autoware.universe that referenced this pull request Oct 28, 2024
chore: sync tier4/autoware.universe:awf-latest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants