-
Notifications
You must be signed in to change notification settings - Fork 665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(simulator_compatibility_test): test codes adjustments #1439
Merged
WJaworskiRobotec
merged 5 commits into
autowarefoundation:main
from
SoohyeokPark-MORAI:feature/sim_compatibility_test_adjustments
Aug 2, 2022
Merged
feat(simulator_compatibility_test): test codes adjustments #1439
WJaworskiRobotec
merged 5 commits into
autowarefoundation:main
from
SoohyeokPark-MORAI:feature/sim_compatibility_test_adjustments
Aug 2, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. organizing test structure 2. renaming modules Signed-off-by: SoohyeokPark-MORAI <shpark.morai@gmail.com>
This reverts commit e79f976. Signed-off-by: SoohyeokPark-MORAI <shpark.morai@gmail.com>
SoohyeokPark-MORAI
force-pushed
the
feature/sim_compatibility_test_adjustments
branch
from
July 27, 2022 04:37
cbb2b37
to
6742873
Compare
SoohyeokPark-MORAI
force-pushed
the
feature/sim_compatibility_test_adjustments
branch
from
July 27, 2022 04:51
6742873
to
a2e35ae
Compare
Signed-off-by: SoohyeokPark-MORAI <shpark.morai@gmail.com>
Code looks fine. I've tested set of tests with AWSIM, everything passed. |
WJaworskiRobotec
approved these changes
Aug 2, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine. Successfully tested with AWSIM
2 tasks
boyali
referenced
this pull request
in boyali/autoware.universe
Sep 28, 2022
* [refactoring] simulator compatibility test 1. organizing test structure 2. renaming modules Signed-off-by: SoohyeokPark-MORAI <shpark.morai@gmail.com> * Revert "[refactoring] simulator compatibility test" This reverts commit e79f976. Signed-off-by: SoohyeokPark-MORAI <shpark.morai@gmail.com> * test codes adjustments Signed-off-by: SoohyeokPark-MORAI <shpark.morai@gmail.com>
boyali
referenced
this pull request
in boyali/autoware.universe
Oct 3, 2022
* [refactoring] simulator compatibility test 1. organizing test structure 2. renaming modules Signed-off-by: SoohyeokPark-MORAI <shpark.morai@gmail.com> * Revert "[refactoring] simulator compatibility test" This reverts commit e79f976. Signed-off-by: SoohyeokPark-MORAI <shpark.morai@gmail.com> * test codes adjustments Signed-off-by: SoohyeokPark-MORAI <shpark.morai@gmail.com>
boyali
referenced
this pull request
in boyali/autoware.universe
Oct 3, 2022
* [refactoring] simulator compatibility test 1. organizing test structure 2. renaming modules Signed-off-by: SoohyeokPark-MORAI <shpark.morai@gmail.com> * Revert "[refactoring] simulator compatibility test" This reverts commit e79f976. Signed-off-by: SoohyeokPark-MORAI <shpark.morai@gmail.com> * test codes adjustments Signed-off-by: SoohyeokPark-MORAI <shpark.morai@gmail.com>
yukke42
pushed a commit
to tzhong518/autoware.universe
that referenced
this pull request
Oct 14, 2022
…oundation#1439) * [refactoring] simulator compatibility test 1. organizing test structure 2. renaming modules Signed-off-by: SoohyeokPark-MORAI <shpark.morai@gmail.com> * Revert "[refactoring] simulator compatibility test" This reverts commit e79f976. Signed-off-by: SoohyeokPark-MORAI <shpark.morai@gmail.com> * test codes adjustments Signed-off-by: SoohyeokPark-MORAI <shpark.morai@gmail.com>
boyali
referenced
this pull request
in boyali/autoware.universe
Oct 19, 2022
* [refactoring] simulator compatibility test 1. organizing test structure 2. renaming modules Signed-off-by: SoohyeokPark-MORAI <shpark.morai@gmail.com> * Revert "[refactoring] simulator compatibility test" This reverts commit e79f976. Signed-off-by: SoohyeokPark-MORAI <shpark.morai@gmail.com> * test codes adjustments Signed-off-by: SoohyeokPark-MORAI <shpark.morai@gmail.com>
technolojin
pushed a commit
to technolojin/autoware.universe
that referenced
this pull request
Oct 28, 2024
chore: sync tier4/autoware.universe:awf-latest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Two test cases are redefined in the simulation working group to eliminate some ambiguities.
Related links
issue link
Test performed
Run the test codes with MORAI SIM: Drive
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.