-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-35884][mysql-pipeline-connector] MySQL pipeline support snapshot chunk key-column #3490
Conversation
@ruanhang1993 PTAL |
...ysql/src/main/java/org/apache/flink/cdc/connectors/mysql/factory/MySqlDataSourceFactory.java
Outdated
Show resolved
Hide resolved
...ysql/src/main/java/org/apache/flink/cdc/connectors/mysql/factory/MySqlDataSourceFactory.java
Show resolved
Hide resolved
@ruanhang1993 PTAL, thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
compile_and_test
|
…line-connector-mysql/src/main/java/org/apache/flink/cdc/connectors/mysql/factory/MySqlDataSourceFactory.java Co-authored-by: Hang Ruan <ruanhang1993@hotmail.com>
@leonardBang PTAL, thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @beryllw for the contribution and @ruanhang1993 for the review, LGTM, wait the CI green
@leonardBang It seems that the failure of CI has nothing to do with this pr. Could we retrigger CI?Thanks. |
…ports to set chunk key-column (apache#3490) Co-authored-by: wangjunbo <wangjunbo@qiyi.com> Co-authored-by: Hang Ruan <ruanhang1993@hotmail.com>
…ports to set chunk key-column (apache#3490) Co-authored-by: wangjunbo <wangjunbo@qiyi.com> Co-authored-by: Hang Ruan <ruanhang1993@hotmail.com>
Flink-connector-mysql-cdc
MySqlSourceOptions
supports specifying the parameter scan.incremental.snapshot.chunk.key-column to divide chunks, pipeline connector should also support.