[FLINK-35984][transform] Fix: Job crashes when metadata column names present in transform rules #3528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @yuxiqian |
leonardBang
reviewed
Aug 9, 2024
There was a problem hiding this comment.
Thanks @MOBIN-F for the contribution, I only left two minor comments
flink-cdc-runtime/src/main/java/org/apache/flink/cdc/runtime/parser/TransformParser.java
Outdated
Show resolved
Hide resolved
...test/java/org/apache/flink/cdc/runtime/operators/transform/UnifiedTransformOperatorTest.java
Outdated
Show resolved
Hide resolved
yuxiqian
approved these changes
Aug 10, 2024
flink-cdc-runtime/src/main/java/org/apache/flink/cdc/runtime/parser/TransformParser.java
Outdated
Show resolved
Hide resolved
Co-authored-by: yuxiqian <34335406+yuxiqian@users.noreply.github.com>
leonardBang
approved these changes
Aug 11, 2024
qiaozongmi
pushed a commit
to qiaozongmi/flink-cdc
that referenced
this pull request
Sep 23, 2024
…be used in transform rule This closes apache#3528. Co-authored-by: yuxiqian <34335406+yuxiqian@users.noreply.github.com>
ChaomingZhangCN
pushed a commit
to ChaomingZhangCN/flink-cdc
that referenced
this pull request
Jan 13, 2025
…be used in transform rule This closes apache#3528. Co-authored-by: yuxiqian <34335406+yuxiqian@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since metadata column existence check was done by searching identifier string in statement, without considering any syntax info
In the transform rule (projection: *, 'namespace_nameschema_nametable_name' AS string_literal) mentioned in FLINK-35984, Caused by: java.lang.IllegalArgumentException: wrong number of arguments is thrown because of the "*" symbol. The PreTransformOperator introduced in FLINK-35272 fixes the "*" problem, but there are still some scenarios where Caused by: java.lang.IllegalArgumentException: wrong number of arguments is thrown due to metaColumn name conflicts. This PR will fix these bugs.