-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-36081][cdc-base][mysql] Fix that MySQL source connector missing some columns data of newly added tables #3548
Merged
ruanhang1993
merged 3 commits into
apache:master
from
kevinwangcs:flinkcdc_mysqlsource_new_column_miss_data_36081
Aug 21, 2024
Merged
[FLINK-36081][cdc-base][mysql] Fix that MySQL source connector missing some columns data of newly added tables #3548
ruanhang1993
merged 3 commits into
apache:master
from
kevinwangcs:flinkcdc_mysqlsource_new_column_miss_data_36081
Aug 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g some columns data of newly added tables
...l-cdc/src/main/java/org/apache/flink/cdc/connectors/mysql/source/split/MySqlBinlogSplit.java
Outdated
Show resolved
Hide resolved
...l-cdc/src/main/java/org/apache/flink/cdc/connectors/mysql/source/split/MySqlBinlogSplit.java
Outdated
Show resolved
Hide resolved
…g some columns data of newly added tables
…g some columns data of newly added tables
ruanhang1993
approved these changes
Aug 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
yuxiqian
pushed a commit
to yuxiqian/flink-cdc
that referenced
this pull request
Aug 22, 2024
…bles in the BinlogSplit when restart (apache#3548) Co-authored-by: 云时 <mingya.wmy@alibaba-inc.com> (cherry picked from commit 77c6338)
leonardBang
pushed a commit
to yuxiqian/flink-cdc
that referenced
this pull request
Aug 27, 2024
…bles in the BinlogSplit when restart (apache#3548) Co-authored-by: 云时 <mingya.wmy@alibaba-inc.com> (cherry picked from commit 77c6338)
qiaozongmi
pushed a commit
to qiaozongmi/flink-cdc
that referenced
this pull request
Sep 23, 2024
…bles in the BinlogSplit when restart (apache#3548) Co-authored-by: 云时 <mingya.wmy@alibaba-inc.com>
ChaomingZhangCN
pushed a commit
to ChaomingZhangCN/flink-cdc
that referenced
this pull request
Jan 13, 2025
…bles in the BinlogSplit when restart (apache#3548) Co-authored-by: 云时 <mingya.wmy@alibaba-inc.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Description:
When adding a new table, the Flink CDC MySQL source connector experiences missing data for some columns of the newly added table.
Reproduction Scenario:
Cause Analysis:
The issue arises because the MySQL CDC Source maintains the table schema in state. When adding a new table, it recovers the schema from the previous state. Since the prior schema exists and represents the structure before the column addition, the MySQL CDC Source provides the downstream with data based on the schema cached in the state. Consequently, records outputted to downstream systems are missing the fields corresponding to the newly added columns.
Proposed Solution:
Upon removing a table from the cdc job, it is necessary to also correspondingly remove the table from the MySQLBinlogSplit.