-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tests][oceanbase] Fix oceanbase test failure, possibly caused by some interactions among cases #3712
[tests][oceanbase] Fix oceanbase test failure, possibly caused by some interactions among cases #3712
Conversation
Another typical failure case is when |
To avoid reading change events generated by another test case, how about using UniqueDatabase? Starting a new container for each test case may significantly increase the testing time. There should be a timeout for |
9b435b0
to
7b731f3
Compare
Done, please check. |
…e interactions among cases Signed-off-by: yuxiqian <34335406+yuxiqian@users.noreply.github.com> # Conflicts: # flink-cdc-connect/flink-cdc-source-connectors/flink-connector-oceanbase-cdc/src/test/java/org/apache/flink/cdc/connectors/oceanbase/table/OceanBaseMySQLModeITCase.java
Signed-off-by: yuxiqian <34335406+yuxiqian@users.noreply.github.com>
c4783ea
to
ccce315
Compare
Rebased with master, could @ruanhang1993 please take a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…d by some interactions among cases (apache#3712)
This fixes a mysterious test failure in OceanBaseMySQLModeITCase like this. Recently it is happening quite frequently, possibly brought in by #3439.
This could be stably reproduced locally, by running
OceanBaseMySqlModeITCase
locally, and make suretestMetadataColumns
is executed right aftertestSnapshotOnly
.This test case will fail, because instead of getting expected
values, it is actually receiving:
which makes totally no sense, just like previous data records have not been cleaned up correctly. Running either
testSnapshotOnly
ortestMetadataColumns
independently is OK, so this PR creates & destroys OceanBase containers for each test case to avoid breaking CI, as a temporary hackaround.I'm a little worried that this behavior might not be caused by a bad test case but reflects some connector implementation issue. Needs some advice from @whhe.