[FLINK-35638] Refactor OceanBase test cases and remove dependency on host network #3439
Conversation
whhe
force-pushed
the
ob-test-network
branch
3 times, most recently
from
163b0e0 to
52006b1
Compare
whhe
force-pushed
the
ob-test-network
branch
4 times, most recently
from
87a9cc9 to
06afe10
Compare
whhe
force-pushed
the
ob-test-network
branch
3 times, most recently
from
9be64dc to
b1edf22
Compare
|
@GOODBOY008 @ruanhang1993 PTAL |
|
@GOODBOY008 would you like to take a look at this PR when you have time? |
docs/content/docs/connectors/flink-sources/tutorials/oceanbase-tutorial.md
Outdated
Show resolved
Hide resolved
whhe
force-pushed
the
ob-test-network
branch
2 times, most recently
from
11e23b5 to
64ea6f1
Compare
…ve dependency on host network
|
Doc typo fixed, @GOODBOY008 PTAL. |
|
|
||
| public Connection getJdbcConnection() throws SQLException { | ||
| return DriverManager.getConnection( | ||
| container.getJdbcUrl(databaseName), getUsername(), getPassword()); |
There was a problem hiding this comment.
@whhe It's wrong to get connection here, should be the implement like : org.apache.flink.cdc.connectors.oceanbase.OceanBaseTestBase#getJdbcConnection.
There was a problem hiding this comment.
It is copied from UniqueDatabase in the mysql-cdc test module, and the database name it connects to is different from OceanBaseTestBase#getJdbcConnection. I think we can keep it.
There was a problem hiding this comment.
If ob in oracle model and e2e test invork UniqueDatabase.getJdbcConnection, what will happened?
There was a problem hiding this comment.
UniqueDatabase is instanced by a container object, so it can't be used for oracle mode now.
There was a problem hiding this comment.
So why not unify invoke org.apache.flink.cdc.connectors.oceanbase.OceanBaseTestBase#getJdbcConnection ?
There was a problem hiding this comment.
I didn't get you. The e2e test case is Parameterized, so I added the UniqueDatabase to create tables for different parameters. It's not a sub class of OceanBaseTestBase, if I want to connect to the unique database, it's straightforward to have a getJdbcConnection method in UniqueDatabase.
…ve dependency on host network (apache#3439)
…ve dependency on host network (apache#3439)
No description provided.