[FLINK-36076] Set isSchemaChangeApplying as isSchemaChangeApplying for thread safe. #3556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The PR title and commit content confuse me a little, @loserwang1024 could you check your PR ? |
leonardBang
reviewed
Aug 19, 2024
.../org/apache/flink/cdc/runtime/operators/schema/coordinator/SchemaRegistryRequestHandler.java
Outdated
Show resolved
Hide resolved
leonardBang
approved these changes
Aug 19, 2024
yuxiqian
pushed a commit
to yuxiqian/flink-cdc
that referenced
this pull request
Aug 22, 2024
…ile for thread safe consideration This closes apache#3556. (cherry picked from commit d3473de)
leonardBang
pushed a commit
to yuxiqian/flink-cdc
that referenced
this pull request
Aug 27, 2024
…ile for thread safe consideration This closes apache#3556. (cherry picked from commit d3473de)
qiaozongmi
pushed a commit
to qiaozongmi/flink-cdc
that referenced
this pull request
Sep 23, 2024
…ile for thread safe consideration This closes apache#3556.
ChaomingZhangCN
pushed a commit
to ChaomingZhangCN/flink-cdc
that referenced
this pull request
Jan 13, 2025
…ile for thread safe consideration This closes apache#3556.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in https://issues.apache.org/jira/browse/FLINK-36076 , Current, we apply schema change asynchronous.
SchemaChangeThreadPool will set isSchemaChangeApplying as true when apply schema change event. And the main thread which handle operater event will check isSchemaChangeApplying.
For thread safe, this should be volatile.