chore(vision): migrate code from googleapis/nodejs-vision #2858
Conversation
* Switch back to mocha from ava. * Make lint happy. * Uncache vision. * Make canvas dependency optional. * Change node version. * Remove const
* Refactor tests. * Tweak build. * Tweak build. * More tests. * Tweak build. * Tweak build. * Fix build. * Fix build. * Speed up build. * Fix build. * Remove extra dep. * Investigate why 0.12 fails. * Scripts. * More tests. * Upgrades * Upgrades * Update readme
…e new Cloud Storage samples (#164) * Brought Pub/Sub samples code coverage up to 98.66%
* Switch to individual API packages. * Address comments * Address comments
* New quickstarts. * Address comments.
* Update storage samples. * Update dependencies.
* Switch from Mocha to Ava * Concurrency: 5
* Make unify script recursive + clean up dependency conflicts * Restore travis.yml * Delete outdated text detection sample that duplicates detect.js * Fix failing KMS + vision tests by updating dependencies * Fix video tests using a bad cwd * Upgrade monitoring dependency + skip flaky monitoring tests * Fix DLP tests having wrong cwd * Fix failing vision test * Fix datastore tests * Update broken dependency * Update possibly broken compute engine dependency * Fix typos * Disable Node 4 testing * Revert deletion of outdated sample - @gguuss says we still use this. This reverts commit b7259c8. * Update dependency
product-auto-label
bot
added
the
samples
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Thanks for preparing this draft, Eric. |
telpirion
changed the title
Yep, that's why it was in a draft PR -- I wasn't done working on it 🙂 |
|
Here is the summary of changes. You are about to add 61 region tags.
This comment is generated by snippet-bot.
|
.github/workflows/workflows.json
Outdated
| "datalabeling", | ||
| "datastore/functions", | ||
| "datacatalog/quickstart", | ||
| "datastore/functions", |
There was a problem hiding this comment.
Nitpick: datastore/functions appears twice in this list.
| "service-directory/snippets", | ||
| "scheduler", | ||
| "speech", | ||
| "talent", | ||
| "translate", | ||
| "video-intelligence", | ||
| "contact-center-insights", | ||
| "vision", | ||
| "vision/productSearch", |
There was a problem hiding this comment.
Question 1: Should vision/productSearch actually be vision/samples/productSearch?
There was a problem hiding this comment.
You're correct. Done.
| "service-directory/snippets", | ||
| "scheduler", | ||
| "speech", | ||
| "talent", | ||
| "translate", | ||
| "video-intelligence", | ||
| "contact-center-insights", | ||
| "vision", | ||
| "vision/productSearch", | ||
| "workflows" | ||
| ] |
There was a problem hiding this comment.
Praise: Thank you for sorting this in alphabetical order, Eric.
| paths: | ||
| - 'vision/**' | ||
| pull_request: | ||
| paths: |
There was a problem hiding this comment.
Please add vision/productSearch/** to paths-ignore so changes to vision-productSearch don't trigger tests of vision.
There was a problem hiding this comment.
Where would I find the definition for this YAML schema? I've made the change to the YAML file but I don't think it's correct ....
There was a problem hiding this comment.
.github/workflows/workflows.json
Outdated
| @@ -48,20 +51,17 @@ | |||
| "healthcare/fhir", | |||
| "healthcare/hl7v2", | |||
| "kms", | |||
| "game-servers/snippets", | |||
There was a problem hiding this comment.
Praise: Thank you for alphabetizing this config file.
Suggestion: Changes like this are our of scope of the PR, consider putting reorganization work in a separate PR, especially in this context where individual branch commits will be retained as part of the repository history.
There was a problem hiding this comment.
Okay, fair enough. I've reverted the alphabetization.
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
There was a problem hiding this comment.
Because there is no existing vision sample for which we want to avoid collision, the target path should be /vision, not /vision/samples.
gcloud appinstead ofgcloud preview app#148)transaction.getguarantees the same order as the keys? #234)