Slight refactor of logging samples. #199

jmdobry · 2016-09-01T04:56:40Z

No description provided.

ace-n · 2016-09-01T17:24:39Z

logging/logs.js

-  // Get a reference to an existing log
-  var log = logging.log(options.name);
+
+function writeLogEntryAdvanced (logName, options, callback) {


Should we have logName and options here?

Required things go into positional arguments, optional stuff into an options argument.

ace-n · 2016-09-01T17:36:41Z

logging/system-test/logs.test.js

+        // Ignore "Not Found" error
+        if (err && err.code !== 404) {
+          assert.ifError(err);
+          assert(apiResponse);


Remove this 'naked assert'? e.g.

assert.notEqual(apiResponse, null)

ace-n · 2016-09-01T17:43:25Z

LGTM, assuming the naked asserts aren't an issue (or will be resolved in a separate PR).

codecov-io · 2016-09-01T17:55:33Z

Current coverage is 89.20% (diff: 100%)

Merging #199 into master will increase coverage by 0.07%

@@             master       #199   diff @@
==========================================
  Files            57         57          
  Lines          2382       2399    +17   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits           2123       2140    +17   
  Misses          259        259          
  Partials          0          0

Powered by Codecov. Last update 2f9b34f...6174d46

🤖 I have created a release \*beep\* \*boop\* --- ### [2.1.1](https://www.github.com/googleapis/nodejs-datalabeling/compare/v2.1.0...v2.1.1) (2020-07-10) ### Bug Fixes * typeo in nodejs .gitattribute ([#198](https://www.github.com/googleapis/nodejs-datalabeling/issues/198)) ([494d94c](https://www.github.com/googleapis/nodejs-datalabeling/commit/494d94c6baafe7626feb4eb611e09eb25f7936f2)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

* updated CHANGELOG.md * updated package.json * updated samples/package.json

Before, this was dumping an object via console.log Now, this properly prints just the label description

* updated CHANGELOG.md * updated package.json * updated samples/package.json

🤖 I have created a release \*beep\* \*boop\* --- ## [3.3.0](https://www.github.com/googleapis/nodejs-secret-manager/compare/v3.2.3...v3.3.0) (2021-01-09) ### Features * adds style enumeration ([#199](https://www.github.com/googleapis/nodejs-secret-manager/issues/199)) ([d99b4af](https://www.github.com/googleapis/nodejs-secret-manager/commit/d99b4af960182916b9a5ed0dfd1f12a2148729fb)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

jmdobry assigned ace-n Sep 1, 2016

jmdobry force-pushed the logs branch from 8c33f2d to 5eb279f Compare September 1, 2016 14:55

ace-n reviewed Sep 1, 2016
View reviewed changes

jmdobry force-pushed the logs branch from 5eb279f to 6174d46 Compare September 1, 2016 17:33

ace-n reviewed Sep 1, 2016
View reviewed changes

jmdobry force-pushed the logs branch from 6174d46 to 1277cd5 Compare September 1, 2016 20:44

Slight refactor of logging samples.

1277cd5

jmdobry merged commit b6cbadd into master Sep 1, 2016

jmdobry deleted the logs branch September 1, 2016 20:55

grayside pushed a commit that referenced this pull request Oct 26, 2022

docs(samples): Add HTTP Push Queue Sample (#199)

34864b3

grayside mentioned this pull request Oct 26, 2022

migrate code from googleapis/nodejs-tasks #2792

Merged

ivanmkc mentioned this pull request Nov 3, 2022

Migrate code from googleapis/nodejs-datalabeling #2797

Merged

grayside pushed a commit that referenced this pull request Nov 3, 2022

docs(samples): Add HTTP Push Queue Sample (#199)

a8693a9

ahrarmonsur pushed a commit that referenced this pull request Nov 8, 2022

Release v0.7.0 (#199)

4239fe3

ahrarmonsur mentioned this pull request Nov 8, 2022

samples: migrate code from googleapis/nodejs-monitoring #2807

Merged

pattishin pushed a commit that referenced this pull request Nov 9, 2022

chore: release 2.3.7 (#199)

f405853

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

pattishin mentioned this pull request Nov 9, 2022

migrate code from googleapis/nodejs-game-servers #2818

Closed

pattishin pushed a commit that referenced this pull request Nov 9, 2022

chore: release 2.3.7 (#199)

60e78ea

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

pattishin mentioned this pull request Nov 9, 2022

migrate code from googleapis/nodejs-game-servers #2819

Closed

pattishin pushed a commit that referenced this pull request Nov 9, 2022

chore: release 2.3.7 (#199)

5279fdd

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

pattishin mentioned this pull request Nov 9, 2022

migrate code from googleapis/nodejs-game-servers #2820

Closed

ace-n pushed a commit that referenced this pull request Nov 10, 2022

Release v0.7.0 (#199)

0c155df

pattishin mentioned this pull request Nov 11, 2022

migrate code from googleapis/nodejs-game-servers #2837

Merged

NimJay pushed a commit that referenced this pull request Nov 11, 2022

chore: release 2.3.7 (#199)

e2c1c7f

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

ace-n pushed a commit that referenced this pull request Nov 11, 2022

chore: release 1.2.1 (#199)

457576f

* updated CHANGELOG.md * updated package.json * updated samples/package.json

ace-n mentioned this pull request Nov 11, 2022

migrate code from googleapis/nodejs-automl #2841

Merged

ace-n pushed a commit that referenced this pull request Nov 11, 2022

chore: release 1.2.1 (#199)

62632ad

* updated CHANGELOG.md * updated package.json * updated samples/package.json

ace-n pushed a commit that referenced this pull request Nov 14, 2022

chore: release 1.2.1 (#199)

5d2cd4b

* updated CHANGELOG.md * updated package.json * updated samples/package.json

ace-n pushed a commit that referenced this pull request Nov 15, 2022

chore: release 1.2.1 (#199)

2f04bed

* updated CHANGELOG.md * updated package.json * updated samples/package.json

ace-n pushed a commit that referenced this pull request Nov 15, 2022

chore: release 1.2.1 (#199)

16f250b

* updated CHANGELOG.md * updated package.json * updated samples/package.json

ace-n pushed a commit that referenced this pull request Nov 16, 2022

Release v1.6.0 (#199)

922d61c

ace-n mentioned this pull request Nov 16, 2022

migrate code from googleapis/nodejs-video-intelligence #2855

Merged

telpirion mentioned this pull request Nov 16, 2022

chore(vision): migrate code from googleapis/nodejs-vision #2858

Merged

telpirion pushed a commit that referenced this pull request Nov 16, 2022

Fix response output for Detect Labels (#199)

4db80be

Before, this was dumping an object via console.log Now, this properly prints just the label description

ace-n pushed a commit that referenced this pull request Nov 17, 2022

Release v1.6.0 (#199)

2ad84f8

ace-n pushed a commit that referenced this pull request Nov 17, 2022

chore: release 1.2.1 (#199)

764162f

* updated CHANGELOG.md * updated package.json * updated samples/package.json

ace-n pushed a commit that referenced this pull request Nov 17, 2022

chore: release 1.2.1 (#199)

08d0ee0

* updated CHANGELOG.md * updated package.json * updated samples/package.json

ace-n pushed a commit that referenced this pull request Nov 17, 2022

refactor: modernize sample tests (#199)

2c1f609

ace-n mentioned this pull request Nov 17, 2022

migrate code from googleapis/nodejs-translate #2862

Merged

ace-n pushed a commit that referenced this pull request Nov 17, 2022

refactor: modernize sample tests (#199)

7303462

ahrarmonsur pushed a commit that referenced this pull request Nov 17, 2022

Release v1.6.0 (#199)

3747929

ahrarmonsur pushed a commit that referenced this pull request Nov 17, 2022

chore: release 1.2.1 (#199)

3e9c81c

* updated CHANGELOG.md * updated package.json * updated samples/package.json

ace-n pushed a commit that referenced this pull request Nov 17, 2022

refactor: modernize sample tests (#199)

be3eb9a

ace-n pushed a commit that referenced this pull request Nov 17, 2022

refactor: modernize sample tests (#199)

4ae0c80

ace-n pushed a commit that referenced this pull request Nov 17, 2022

refactor: modernize sample tests (#199)

aeb6983

jsimonweb pushed a commit to jsimonweb/nodejs-docs-samples that referenced this pull request Dec 12, 2022

fix: use alloydb-tmp as default tmp dir (GoogleCloudPlatform#199)

30587d6

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Slight refactor of logging samples. #199

Slight refactor of logging samples. #199

jmdobry commented Sep 1, 2016

ace-n Sep 1, 2016

jmdobry Sep 1, 2016

ace-n Sep 1, 2016

ace-n commented Sep 1, 2016

codecov-io commented Sep 1, 2016

Slight refactor of logging samples. #199

Slight refactor of logging samples. #199

Conversation

jmdobry commented Sep 1, 2016

ace-n Sep 1, 2016

Choose a reason for hiding this comment

jmdobry Sep 1, 2016

Choose a reason for hiding this comment

ace-n Sep 1, 2016

Choose a reason for hiding this comment

ace-n commented Sep 1, 2016

codecov-io commented Sep 1, 2016

Current coverage is 89.20% (diff: 100%)