Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Does transaction.get guarantees the same order as the keys? #234

Closed
tmatsuo opened this issue Oct 12, 2016 · 1 comment
Closed

Does transaction.get guarantees the same order as the keys? #234

tmatsuo opened this issue Oct 12, 2016 · 1 comment
Assignees
@jmdobry
Labels
🚨 This issue needs some love. triage me I really want to be triaged.

Comments

@tmatsuo
Copy link
Contributor

tmatsuo commented Oct 12, 2016

https://github.com/GoogleCloudPlatform/nodejs-docs-samples/blob/master/datastore/concepts.js#L1048

I don't think transaction.get guarantees that the order of the result is the same as the given keys. Please close if it does, but please fix this otherwise.
@tmatsuo tmatsuo added the bug label Nov 7, 2016
@jmdobry
Copy link
Member

jmdobry commented Nov 7, 2016

As far as I can tell, the order of the entities in the response is undefined and has no relation to the order of the keys in the input. I'll have to fix the sample.

See: https://cloud.google.com/datastore/docs/reference/rpc/google.datastore.v1beta3#google.datastore.v1beta3.LookupResponse

jmdobry added a commit that referenced this issue Nov 7, 2016
@jmdobry
Fixes #234
48b80c5
jmdobry added a commit that referenced this issue Nov 8, 2016
@jmdobry
Fixes #48
d914137 
Fixes #234
@jmdobry jmdobry mentioned this issue Nov 8, 2016
Merged
jmdobry added a commit that referenced this issue Nov 15, 2016
@jmdobry
Fixes #48
ce8b714 
Fixes #234
jmdobry added a commit that referenced this issue Nov 15, 2016
@jmdobry
Fixes #48
63fd52c 
Fixes #234
jmdobry added a commit that referenced this issue Nov 15, 2016
@jmdobry
Fixes #48
6b7cb36 
Fixes #234
jmdobry added a commit that referenced this issue Nov 16, 2016
@jmdobry
Fixes #48
33bfdd7 
Fixes #234
jmdobry added a commit that referenced this issue Nov 18, 2016
@jmdobry
Fixes #48
dbb186a 
Fixes #234
Fixes #250

Addressed comments.
jmdobry added a commit that referenced this issue Nov 21, 2016
@jmdobry
Fixes #48
ed81bc1 
Fixes #234
Fixes #250

Addressed comments.
jmdobry added a commit that referenced this issue Nov 21, 2016
@jmdobry
Fixes #48 (#249)
1b3dd3f 
Fixes #234
Fixes #250

Addressed comments.
@yoshi-automation yoshi-automation added triage me I really want to be triaged. 🚨 This issue needs some love. labels Apr 6, 2020
@snyk-bot snyk-bot mentioned this issue Apr 27, 2022
Open
kweinmeister pushed a commit that referenced this issue Nov 7, 2022
@release-please
chore(main): release 3.0.1 (#234)
0fd886e 
🤖 I have created a release *beep* *boop*
---


## [3.0.1](googleapis/nodejs-media-translation@v3.0.0...v3.0.1) (2022-06-30)


### Bug Fixes

* **docs:** describe fallback rest option ([#233](googleapis/nodejs-media-translation#233)) ([f83d3ed](googleapis/nodejs-media-translation@f83d3ed))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
@kweinmeister kweinmeister mentioned this issue Nov 7, 2022
Closed
ahrarmonsur pushed a commit that referenced this issue Nov 8, 2022
@JustinBeckwith
refactor: use execSync for tests (#234)
d8ff54a
@ahrarmonsur ahrarmonsur mentioned this issue Nov 8, 2022
Merged
kweinmeister pushed a commit that referenced this issue Nov 8, 2022
@release-please
chore(main): release 3.0.1 (#234)
ca9d240 
🤖 I have created a release *beep* *boop*
---


## [3.0.1](googleapis/nodejs-media-translation@v3.0.0...v3.0.1) (2022-06-30)


### Bug Fixes

* **docs:** describe fallback rest option ([#233](googleapis/nodejs-media-translation#233)) ([f83d3ed](googleapis/nodejs-media-translation@f83d3ed))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
@kweinmeister kweinmeister mentioned this issue Nov 8, 2022
Merged
kweinmeister pushed a commit that referenced this issue Nov 8, 2022
@release-please @kweinmeister
chore(main): release 3.0.1 (#234)
d8d9764 
🤖 I have created a release *beep* *boop*
---


## [3.0.1](googleapis/nodejs-media-translation@v3.0.0...v3.0.1) (2022-06-30)


### Bug Fixes

* **docs:** describe fallback rest option ([#233](googleapis/nodejs-media-translation#233)) ([f83d3ed](googleapis/nodejs-media-translation@f83d3ed))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
ace-n pushed a commit that referenced this issue Nov 10, 2022
@JustinBeckwith
refactor: use execSync for tests (#234)
27bdf38
NimJay pushed a commit that referenced this issue Nov 10, 2022
@jmdobry
Fixes #48 (#249)
3cdf0c9 
Fixes #234
Fixes #250

Addressed comments.
NimJay pushed a commit that referenced this issue Nov 10, 2022
@jmdobry @NimJay
Fixes #48 (#249)
5036529 
Fixes #234
Fixes #250

Addressed comments.
@telpirion telpirion mentioned this issue Nov 16, 2022
Merged
telpirion pushed a commit that referenced this issue Nov 16, 2022
@normankong @JustinBeckwith
fix: Param "scoreThreshold" should be "score_threshold" (#234)
d1056e3 
Sine 18 Oct 2018, I found that the scoreThreshold param won't work and encounter  "Error: 3 INVALID_ARGUMENT: Request contains an invalid argument." during prediction call. I compared the doc below and the params should be score_threshold instead of scoreThreshold. 

https://cloud.google.com/vision/automl/docs/reference/rest/v1beta1/projects.locations.models/predict#request-body
ace-n pushed a commit that referenced this issue Nov 17, 2022
@leahecole @JustinBeckwith
docs(samples): Add samples for translate v3 beta (#234)
5efaf7f
@ace-n ace-n mentioned this issue Nov 17, 2022
Merged
ace-n pushed a commit that referenced this issue Nov 17, 2022
@leahecole
docs(samples): Add samples for translate v3 beta (#234)
c265b11
ace-n pushed a commit that referenced this issue Nov 17, 2022
@leahecole
docs(samples): Add samples for translate v3 beta (#234)
e7ceed3
ace-n pushed a commit that referenced this issue Nov 17, 2022
@leahecole
docs(samples): Add samples for translate v3 beta (#234)
3a446b6
ace-n pushed a commit that referenced this issue Nov 17, 2022
@leahecole
docs(samples): Add samples for translate v3 beta (#234)
a128c50
ahrarmonsur pushed a commit that referenced this issue Nov 18, 2022
@JustinBeckwith
docs: improve the quickstart sample (#234)
f9167d7
ahrarmonsur pushed a commit that referenced this issue Nov 18, 2022
@JustinBeckwith
docs: improve the quickstart sample (#234)
83c9ce4
@ahrarmonsur ahrarmonsur mentioned this issue Nov 18, 2022
Merged
NimJay pushed a commit that referenced this issue Nov 18, 2022
@JustinBeckwith @NimJay
docs: improve the quickstart sample (#234)
0717fae
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmdobry jmdobry

Labels
🚨 This issue needs some love. triage me I really want to be triaged.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tmatsuo @jmdobry @yoshi-automation