Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does transaction.get guarantees the same order as the keys? #234

Closed
tmatsuo opened this issue Oct 12, 2016 · 1 comment
Closed

Does transaction.get guarantees the same order as the keys? #234

tmatsuo opened this issue Oct 12, 2016 · 1 comment
Assignees
Labels
🚨 This issue needs some love. triage me I really want to be triaged.

Comments

@tmatsuo
Copy link
Contributor

tmatsuo commented Oct 12, 2016

https://github.com/GoogleCloudPlatform/nodejs-docs-samples/blob/master/datastore/concepts.js#L1048

I don't think transaction.get guarantees that the order of the result is the same as the given keys. Please close if it does, but please fix this otherwise.

@jmdobry
Copy link
Member

jmdobry commented Nov 7, 2016

As far as I can tell, the order of the entities in the response is undefined and has no relation to the order of the keys in the input. I'll have to fix the sample.

See: https://cloud.google.com/datastore/docs/reference/rpc/google.datastore.v1beta3#google.datastore.v1beta3.LookupResponse

jmdobry added a commit that referenced this issue Nov 7, 2016
jmdobry added a commit that referenced this issue Nov 8, 2016
Fixes #234
jmdobry added a commit that referenced this issue Nov 15, 2016
Fixes #234
jmdobry added a commit that referenced this issue Nov 15, 2016
Fixes #234
jmdobry added a commit that referenced this issue Nov 15, 2016
Fixes #234
jmdobry added a commit that referenced this issue Nov 16, 2016
Fixes #234
jmdobry added a commit that referenced this issue Nov 18, 2016
Fixes #234
Fixes #250

Addressed comments.
jmdobry added a commit that referenced this issue Nov 21, 2016
Fixes #234
Fixes #250

Addressed comments.
jmdobry added a commit that referenced this issue Nov 21, 2016
Fixes #234
Fixes #250

Addressed comments.
@yoshi-automation yoshi-automation added triage me I really want to be triaged. 🚨 This issue needs some love. labels Apr 6, 2020
kweinmeister pushed a commit that referenced this issue Nov 7, 2022
🤖 I have created a release *beep* *boop*
---


## [3.0.1](googleapis/nodejs-media-translation@v3.0.0...v3.0.1) (2022-06-30)


### Bug Fixes

* **docs:** describe fallback rest option ([#233](googleapis/nodejs-media-translation#233)) ([f83d3ed](googleapis/nodejs-media-translation@f83d3ed))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
kweinmeister pushed a commit that referenced this issue Nov 8, 2022
🤖 I have created a release *beep* *boop*
---


## [3.0.1](googleapis/nodejs-media-translation@v3.0.0...v3.0.1) (2022-06-30)


### Bug Fixes

* **docs:** describe fallback rest option ([#233](googleapis/nodejs-media-translation#233)) ([f83d3ed](googleapis/nodejs-media-translation@f83d3ed))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
kweinmeister pushed a commit that referenced this issue Nov 8, 2022
🤖 I have created a release *beep* *boop*
---


## [3.0.1](googleapis/nodejs-media-translation@v3.0.0...v3.0.1) (2022-06-30)


### Bug Fixes

* **docs:** describe fallback rest option ([#233](googleapis/nodejs-media-translation#233)) ([f83d3ed](googleapis/nodejs-media-translation@f83d3ed))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
ace-n pushed a commit that referenced this issue Nov 10, 2022
NimJay pushed a commit that referenced this issue Nov 10, 2022
Fixes #234
Fixes #250

Addressed comments.
NimJay pushed a commit that referenced this issue Nov 10, 2022
Fixes #234
Fixes #250

Addressed comments.
telpirion pushed a commit that referenced this issue Nov 16, 2022
Sine 18 Oct 2018, I found that the scoreThreshold param won't work and encounter  "Error: 3 INVALID_ARGUMENT: Request contains an invalid argument." during prediction call. I compared the doc below and the params should be score_threshold instead of scoreThreshold. 

https://cloud.google.com/vision/automl/docs/reference/rest/v1beta1/projects.locations.models/predict#request-body
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚨 This issue needs some love. triage me I really want to be triaged.
Projects
None yet
Development

No branches or pull requests

3 participants