Add KMS quickstart. #296

jmdobry · 2017-01-11T18:10:00Z

No description provided.

ace-n

LGTM, other than grammatical nits and (some relevant) failing tests.

ace-n · 2017-01-11T18:22:34Z

kms/quickstart.js

+// Your Google Cloud Platform project ID
+const projectId = 'YOUR_PROJECT_ID';
+
+// The "global" zone will list all keys, can be a specific zone if desired


Grammar nit: The "global" zone will list all keys. It can be a specific zone if desired

ace-n · 2017-01-11T18:23:06Z

kms/quickstart.js

+// Acquires credentials
+google.auth.getApplicationDefault((err, authClient) => {
+  if (err) {
+    console.error('Filed to acquire credentials');


Typo: Failed

ace-n · 2017-01-11T18:23:43Z

kms/system-test/quickstart.test.js

+function list (callback) {
+  google.auth.getApplicationDefault((err, authClient) => {
+    if (err) {
+      callback(new Error('Filed to acquire credentials'));


Typo: failed

ace-n · 2017-01-11T18:26:41Z

Failing test output on CircleCI:

Uncaught Exception: kms/system-test/quickstart.test.js
  TypeError: google.cloudkms is not a function
    google.auth.getApplicationDefault (kms/system-test/quickstart.test.js:36:29)
    callback (node_modules/googleapis/node_modules/google-auth-library/lib/auth/googleauth.js:42:14)
    node_modules/googleapis/node_modules/google-auth-library/lib/auth/googleauth.js:289:13

jmdobry · 2017-01-11T18:29:08Z

Fixed

🤖 I have created a release \*beep\* \*boop\* --- ### [2.2.6](https://www.github.com/googleapis/nodejs-datalabeling/compare/v2.2.5...v2.2.6) (2021-07-21) ### Bug Fixes * Updating WORKSPACE files to use the newest version of the Typescript generator. ([#296](https://www.github.com/googleapis/nodejs-datalabeling/issues/296)) ([b67af5c](https://www.github.com/googleapis/nodejs-datalabeling/commit/b67af5c6eea1142d6b1f08f7dd9213a7078a4d59)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

* docs: add translate ga samples * update package.json * add missing file * Add license headers

* [CHANGE ME] Re-generated to pick up changes in the API or client library generator. * rename imagePath => referenceImagePath in samples

🤖 I have created a release \*beep\* \*boop\* --- ## [1.7.0](https://www.github.com/googleapis/nodejs-cloud-container/compare/v1.6.2...v1.7.0) (2020-03-06) ### Features * deferred client initialization ([#304](https://www.github.com/googleapis/nodejs-cloud-container/issues/304)) ([b1b7080](https://www.github.com/googleapis/nodejs-cloud-container/commit/b1b70806289aea73a6e83d3d33983d05856f21f3)) * export protos in src/index.ts ([acaaeff](https://www.github.com/googleapis/nodejs-cloud-container/commit/acaaeff08ad5505accc15bb496bcd3a29086a5ac)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).

* docs: add translate ga samples * update package.json * add missing file * Add license headers

🤖 I have created a release \*beep\* \*boop\* --- ## [1.7.0](https://www.github.com/googleapis/nodejs-cloud-container/compare/v1.6.2...v1.7.0) (2020-03-06) ### Features * deferred client initialization ([#304](https://www.github.com/googleapis/nodejs-cloud-container/issues/304)) ([b1b7080](https://www.github.com/googleapis/nodejs-cloud-container/commit/b1b70806289aea73a6e83d3d33983d05856f21f3)) * export protos in src/index.ts ([acaaeff](https://www.github.com/googleapis/nodejs-cloud-container/commit/acaaeff08ad5505accc15bb496bcd3a29086a5ac)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).

* docs: add translate ga samples * update package.json * add missing file * Add license headers

🤖 I have created a release \*beep\* \*boop\* --- ## [1.7.0](https://www.github.com/googleapis/nodejs-cloud-container/compare/v1.6.2...v1.7.0) (2020-03-06) ### Features * deferred client initialization ([#304](https://www.github.com/googleapis/nodejs-cloud-container/issues/304)) ([b1b7080](https://www.github.com/googleapis/nodejs-cloud-container/commit/b1b70806289aea73a6e83d3d33983d05856f21f3)) * export protos in src/index.ts ([acaaeff](https://www.github.com/googleapis/nodejs-cloud-container/commit/acaaeff08ad5505accc15bb496bcd3a29086a5ac)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

jmdobry self-assigned this Jan 11, 2017

jmdobry requested a review from ace-n January 11, 2017 18:10

ace-n suggested changes Jan 11, 2017

View reviewed changes

Add KMS quickstart.

9cd9f4f

jmdobry force-pushed the kms branch from f268b64 to 9cd9f4f Compare January 11, 2017 18:29

jmdobry merged commit f800be2 into master Jan 11, 2017

ace-n pushed a commit that referenced this pull request Jan 11, 2017

Add KMS quickstart. (#296)

f2d185b

jmdobry deleted the kms branch January 12, 2017 17:49

ace-n pushed a commit that referenced this pull request Nov 11, 2022

docs: add translate ga samples (#296)

fc35876

* docs: add translate ga samples * update package.json * add missing file * Add license headers

ace-n mentioned this pull request Nov 11, 2022

migrate code from googleapis/nodejs-automl #2841

Merged

ace-n pushed a commit that referenced this pull request Nov 11, 2022

docs: add translate ga samples (#296)

639e033

* docs: add translate ga samples * update package.json * add missing file * Add license headers

ace-n pushed a commit that referenced this pull request Nov 14, 2022

docs: add translate ga samples (#296)

ce62524

* docs: add translate ga samples * update package.json * add missing file * Add license headers

ace-n pushed a commit that referenced this pull request Nov 15, 2022

docs: add translate ga samples (#296)

56d6289

* docs: add translate ga samples * update package.json * add missing file * Add license headers

ace-n pushed a commit that referenced this pull request Nov 15, 2022

docs: add translate ga samples (#296)

6438d03

* docs: add translate ga samples * update package.json * add missing file * Add license headers

telpirion mentioned this pull request Nov 16, 2022

chore(vision): migrate code from googleapis/nodejs-vision #2858

Merged

telpirion pushed a commit that referenced this pull request Nov 16, 2022

BREAKING: rename method imagePath => referenceImagePath (#296)

870f233

* [CHANGE ME] Re-generated to pick up changes in the API or client library generator. * rename imagePath => referenceImagePath in samples

This was referenced Nov 16, 2022

migrate code from googleapis/nodejs-cloud-container #2859

Closed

migrate code from googleapis/nodejs-cloud-container #2860

Merged

ace-n pushed a commit that referenced this pull request Nov 17, 2022

docs: add translate ga samples (#296)

9677f5d

* docs: add translate ga samples * update package.json * add missing file * Add license headers

ace-n pushed a commit that referenced this pull request Nov 17, 2022

docs: add translate ga samples (#296)

1f4c291

* docs: add translate ga samples * update package.json * add missing file * Add license headers

ahrarmonsur pushed a commit that referenced this pull request Nov 17, 2022

docs: add translate ga samples (#296)

62db156

* docs: add translate ga samples * update package.json * add missing file * Add license headers

kweinmeister mentioned this pull request Nov 18, 2022

migrate code from googleapis/nodejs-text-to-speech #2872

Merged

kweinmeister pushed a commit that referenced this pull request Nov 18, 2022

chore: release 2.0.1 (#296)

61cd3f5

ahrarmonsur pushed a commit that referenced this pull request Nov 18, 2022

chore: release 3.10.1 (#296)

1dac2dd

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

ahrarmonsur mentioned this pull request Nov 18, 2022

migrate code from googleapis/nodejs-secret-manager #2874

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add KMS quickstart. #296

Add KMS quickstart. #296

jmdobry commented Jan 11, 2017

ace-n left a comment

ace-n Jan 11, 2017

jmdobry Jan 11, 2017

ace-n Jan 11, 2017

jmdobry Jan 11, 2017

ace-n Jan 11, 2017

jmdobry Jan 11, 2017

ace-n commented Jan 11, 2017

jmdobry commented Jan 11, 2017

Add KMS quickstart. #296

Add KMS quickstart. #296

Conversation

jmdobry commented Jan 11, 2017

ace-n left a comment

Choose a reason for hiding this comment

ace-n Jan 11, 2017

Choose a reason for hiding this comment

jmdobry Jan 11, 2017

Choose a reason for hiding this comment

ace-n Jan 11, 2017

Choose a reason for hiding this comment

jmdobry Jan 11, 2017

Choose a reason for hiding this comment

ace-n Jan 11, 2017

Choose a reason for hiding this comment

jmdobry Jan 11, 2017

Choose a reason for hiding this comment

ace-n commented Jan 11, 2017

jmdobry commented Jan 11, 2017