Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run unit and integration tests on functions/helloworld presubmit #910

Closed
fhinkel opened this issue Nov 15, 2018 · 4 comments
Closed

Run unit and integration tests on functions/helloworld presubmit #910

fhinkel opened this issue Nov 15, 2018 · 4 comments
Assignees
@ace-n

Comments

@fhinkel
Copy link
Contributor

fhinkel commented Nov 15, 2018

I disabled most tests so we get a green presubmit tests. Please fix and re-enable them.

See #909
@fhinkel fhinkel added the Fixit label Nov 30, 2018
@fhinkel
Copy link
Contributor Author

fhinkel commented Dec 17, 2018

ping on this

@fhinkel
Copy link
Contributor Author

fhinkel commented Feb 6, 2019

ping @ace-n Do the tests for functions/helloworld pass now? Can we make them blocking?

1 similar comment
@fhinkel
Copy link
Contributor Author

fhinkel commented Feb 28, 2019

ping @ace-n Do the tests for functions/helloworld pass now? Can we make them blocking?

@fhinkel
Copy link
Contributor Author

fhinkel commented Jul 10, 2019

Closing due to inactivity.

@fhinkel fhinkel closed this as completed Jul 10, 2019
@telpirion telpirion mentioned this issue Nov 16, 2022
Merged
telpirion pushed a commit that referenced this issue Nov 16, 2022
@munkhuushmgl
chore: removed duplicate v1p1beta1 samples (#910)
dc869a5 
Fixes disambiguate state of v1p1beta1 vs v1 samples  🦕
@ninadhatkar ninadhatkar mentioned this issue Nov 28, 2023
Open
This was referenced Nov 29, 2023
Open
Open
Open
This was referenced Dec 20, 2023
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ace-n ace-n

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fhinkel @ace-n