Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

retry-request 4.0 won't work but 3.3.2 works #1069

Closed
kenakamu opened this issue Dec 22, 2018 · 5 comments
Closed

retry-request 4.0 won't work but 3.3.2 works #1069

kenakamu opened this issue Dec 22, 2018 · 5 comments
Assignees
@gguuss

Comments

@kenakamu
Copy link

retry-request 4.0 won't work but 3.3.2 works
@fhinkel
Copy link
Contributor

fhinkel commented Dec 29, 2018

@kenakamu Thanks for opening the issue. For which sample does retry-request not work?

@kenakamu
Copy link
Author

Forgot to mention that. sorry.

https://github.com/GoogleCloudPlatform/nodejs-docs-samples/tree/master/iot/http_example

@fhinkel
Copy link
Contributor

fhinkel commented Jan 3, 2019 •
edited
Loading

Thanks. @gguuss, could you have a look? Here's the PR that updated retry-request, all tests were green.

@gguuss
Copy link
Contributor

gguuss commented Jan 3, 2019

I'm able to reproduce the behavior on Node 10. I'll update the package / configuration.

@gguuss
Copy link
Contributor

gguuss commented Jan 3, 2019

This should be fixed in this PR.

@fhinkel fhinkel closed this as completed Feb 28, 2019
@telpirion telpirion mentioned this issue Nov 16, 2022
Merged
telpirion pushed a commit that referenced this issue Nov 16, 2022
@galz10 @gcf-owl-bot
build(samples test): added imageContext to ImprovedRequest (#1069)
6df37a6 
* build(samples test): added imageContext to ImprovedRequest

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gguuss gguuss

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fhinkel @gguuss @kenakamu