Deploy Checklist: Expensify.cash 2021-05-14

[OSBotify]

Release Version: 1.0.48-0
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Add storybook and a Header story #1257
• Clean up IOUAmount page #2723
• FIX: crash when selected corrupted image on Android #2731
• Add Personal Bank Account via Plaid flow #2746
• [No QA] fixed quickly Commenting on PRs hit api limit #2769
• Added dynamic repositioning for Context menu on resize #2822
• Activate draft Icon for active report #2823
• #2806 fix selectable timezone dropdown with thuthy disabled passed #2824
• DeployBlockerCash: Add labels, comment in slack, comment on issue #2843
• fix: remove margin from 'pre' tag #2854
• #2794 fix document attachment label #2919
• [No QA] Fix all propTypes to use block comments #2921
• Fix Image Attachments #2933
• Add Localization to Attachment Modal #2935
• [No QA] Don't Overwrite Storybook docs directory when deploying #2949
• Set the leader on Page Focus #2954
• fix: Emoji Picker Styles #2955
• Add autofocus to emoji picker text input #2959
• Make unread indicator for web favicon larger #2961
• Update sort order for Search Page lastVisitedTimestamp #2964
• [No QA] Apply engineering label to deploy blockers, not demolition #2971
• [No QA] Remove at-here from Slack comment for deploy blockers #2975
• Fix blank screen on IOU confirm page #2976

Deploy Blockers:

• IOU - Unable to create IOU transaction via request money on conversation #2969
• Test deploy blocker #2974
• Test Deploy Blocker: No at-here #2984

cc @Expensify/applauseleads

[isagoico]

Starting QA 🚀

[isagoico]

#2843 was a fail, being fixed here #2971

[isagoico]

Regression is finished!
Issues found:

1. Android - App crashes when uploading a PDF file #2972 - Possible deploy blocker
2. Edit message - Able to save an empty message #2968
3. [HOLD for payment 23 June] Web - Chat - Adjust modal rendering  #2967

PRs are finished too!
No comments added.

Thanks!

[roryabraham]

#2843 was fixed in #2971

[roryabraham]

Okay, due to an incident with the GH servers, this checklist was not being correctly updated. So I went ahead and manually added the following PRs to the checklist:

• Clean up IOUAmount page #2723
• FIX: crash when selected corrupted image on Android #2731
• Add Personal Bank Account via Plaid flow #2746
• [No QA] fixed quickly Commenting on PRs hit api limit #2769
• #2794 fix document attachment label #2919
• Add autofocus to emoji picker text input #2959
• Make unread indicator for web favicon larger #2961
• Update sort order for Search Page lastVisitedTimestamp #2964
• [No QA] Apply engineering label to deploy blockers, not demolition #2971
• [No QA] Remove at-here from Slack comment for deploy blockers #2975
• Fix blank screen on IOU confirm page #2976

All these PRs were merged since this checklist was closed yesterday 😬

@AndrewGable it would be awesome if the checklist-building didn't work by adding 1 PR at a time and instead looked at the commit history to find all the PRs that were merged in the timeframe we're interested in. That way, this would be less brittle when GH has an incident.

[roryabraham]

Created a follow-up issue here to improve how this checklist is populated in the future.

[isagoico]

Starting QA 🚀

[isagoico]

Regression is finished!
1 issue found today:

1. [Hold for Payment 1st June] IOU - Name is not visible in the IOU request page #2996

PRs are finished too!
1 comment added:

1. Fix blank screen on IOU confirm page #2976 (comment) - Separate issue here IOU - Android - Nothing happened after clicked Request Money button #2995

Thanks!

[roryabraham]

Looks like the only issues we have are related to IOU stuff. Since IOU's are still hidden behind a beta, those issues should not be treated as deploy blockers. So I'm thinking we'll run a production deploy 🚀

[roryabraham]