Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sort order for Search Page lastVisitedTimestamp #2964

Merged
merged 3 commits into from
May 18, 2021

Conversation

parasharrajat
Copy link
Member

@parasharrajat parasharrajat commented May 17, 2021

Details

A concise explanation can be found here #2960 (comment).

Fixed Issues

Fixes #2960

Tests / QA Steps

  1. Open the E.cash app on any platform.
  2. Open different chats and remember the order.
  3. Open the Search Page by clicking the search icon on the LHN topbar.
  4. Observe the order of chats, they should be in reverse order as of your order in Step 2. Recent visited should come up.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

order.mp4

Mobile Web

1621276917739.mp4

Desktop

order-d.mp4

iOS

Android

order-and.mp4

@parasharrajat parasharrajat marked this pull request as ready for review May 17, 2021 18:49
@parasharrajat parasharrajat requested a review from a team as a code owner May 17, 2021 18:49
@MelvinBot MelvinBot requested review from nickmurray47 and removed request for a team May 17, 2021 18:49
@parasharrajat
Copy link
Member Author

Ready for review.

@nickmurray47 nickmurray47 merged commit a87db63 into Expensify:main May 18, 2021
@parasharrajat parasharrajat deleted the searchOptions branch November 20, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Hold for payment 2021-05-25] Search results are not sorted by last viewed anymore
2 participants