Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DeployBlockerCash: Add labels, comment in slack, comment on issue #2843

Merged
merged 1 commit into from
May 14, 2021

Conversation

roryabraham
Copy link
Contributor

Details

Previously, when an Expensify.cash Deploy Blocker was created, we would just add the issue to the open StagingDeployCash checklist. This PR makes it so that we:

  1. Add it to the StagingDeployCash checklist
  2. Give it the Hourly and Demolition labels
  3. Post the issue in Slack in the #deployer room
  4. Comment on the issue with instructions that clarify the expectation for assignees.

Fixed Issues

Fixes https://github.com/Expensify/Expensify/issues/163893

QA Steps

  1. Merge this PR
  2. Label an issue DeployBlockerCash
  3. Verify that the issue is given the Hourly and Demolition labels
  4. Verify that someone from the Engineering Demolition team is auto-assigned to the issue.
  5. Verify that the issue is posted in the #deployer slack room
  6. Verify that OSBotify comments in the issue with a comment that looks like this:

image

Tested On

Can be live-tested on GitHub only (although I did test the issue comment in another repo I use for testing GH Actions).

@roryabraham roryabraham self-assigned this May 13, 2021
@roryabraham roryabraham requested a review from a team as a code owner May 13, 2021 00:42
@MelvinBot MelvinBot requested review from Gonals and removed request for a team May 13, 2021 00:42
@roryabraham roryabraham requested a review from deetergp May 13, 2021 00:42
@roryabraham
Copy link
Contributor Author

@deetergp Since Andrew is OoO I'm requesting your review since I know you have some familiarity with the GH Actions YAML syntax.

@deetergp
Copy link
Contributor

Looks good to me!

@roryabraham
Copy link
Contributor Author

@Gonals In the spirit of #Urgency I'm going to go ahead and self-merge this so that any deploy blockers created today get auto-assigned with a high degree of urgency.

@roryabraham roryabraham merged commit 78c9355 into main May 14, 2021
@roryabraham roryabraham deleted the Rory-DeployBlockerCashUrgency branch May 14, 2021 18:58
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.46-1🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@isagoico
Copy link

@roryabraham Heyo!
Added the deploy blocker to this issue that was found around the IOU transactions. Seems like this PR is a fail but wanted to verify with you first #2969

@roryabraham
Copy link
Contributor Author

Hi @isagoico . That PR was indeed a fail. I have a (hopefully) better one here.

@roryabraham roryabraham mentioned this pull request May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants