Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove margin from 'pre' tag #2854

Merged

Conversation

0xthierry
Copy link
Contributor

@0xthierry 0xthierry commented May 13, 2021

Details

On the mobile app (iOS and Android), the code block is formatted incorrectly, showing an extra space before and after the block.

The expected result is this extra space removed.

Fixed Issues

#2673

Tests

QA Steps

  1. Navigate to a conversation
  2. Compose a message with text and a multi line code block (single ticks)
  3. Notice that there are no extra line spaces before and after the code block

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Screen Shot 2021-05-16 at 10 42 37

Mobile Web

Screen Shot 2021-05-16 at 10 43 23

Desktop

Screen Shot 2021-05-16 at 10 44 43

iOS

Screen Shot 2021-05-16 at 10 40 56

Android

Screen Shot 2021-05-16 at 10 32 42

@0xthierry 0xthierry force-pushed the fix/margin-multiline-code-block branch from b9adba7 to 664fec6 Compare May 16, 2021 13:25
@0xthierry 0xthierry marked this pull request as ready for review May 16, 2021 13:45
@0xthierry 0xthierry requested a review from a team as a code owner May 16, 2021 13:45
@MelvinBot MelvinBot requested review from nickmurray47 and removed request for a team May 16, 2021 13:45
@nickmurray47 nickmurray47 merged commit 995cf86 into Expensify:main May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants