Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix blank screen on IOU confirm page #2976

Merged
merged 2 commits into from
May 18, 2021
Merged

Conversation

roryabraham
Copy link
Contributor

@roryabraham roryabraham commented May 18, 2021

Details

The option.participantsList may be undefined (per it's prop types here). So this PR ensures that we're safely checking the length of that array.

Fixed Issues

Fixes #2969

Tests / QA Steps

  1. Open a chat on an account in the IOU beta.
  2. Press the + icon
  3. Press "Request Money"
  4. Enter an amount in the modal.
  5. Hit Next
  6. Verify that the app doesn't crash or fail with a white screen.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

image

Mobile Web

image

Desktop

image

iOS

image

Android

image

@roryabraham roryabraham requested a review from a team May 18, 2021 00:54
@roryabraham roryabraham self-assigned this May 18, 2021
@MelvinBot MelvinBot requested review from stitesExpensify and removed request for a team May 18, 2021 00:55
@roryabraham roryabraham requested a review from a team as a code owner May 18, 2021 00:58
@MelvinBot MelvinBot requested review from joelbettner and removed request for a team May 18, 2021 00:58
@roryabraham roryabraham removed the request for review from joelbettner May 18, 2021 00:59
@roryabraham
Copy link
Contributor Author

Unfortunately I've got to run and didn't have time to finish testing this on all platforms. Will resume in the AM

@roryabraham
Copy link
Contributor Author

@stitesExpensify This passed testing on all platforms and is ready for your review :)

@stitesExpensify stitesExpensify merged commit 577ef59 into main May 18, 2021
@stitesExpensify stitesExpensify deleted the Rory-BlankScreenIOUConfirm branch May 18, 2021 15:59
@isagoico
Copy link

Android - Chat - Nothing happened after clicked Request Money button

Expected Result

The screen should redirect to LHN after clicked Request Money button the

Actual Result

Nothing happened after clicked Request Money button

Action Performed

  1. Lunch the app
  2. Log in with applause account
  3. Press the + icon
  4. Press "Request Money"
  5. Enter an amount in the modal.
  6. Hit Next
  7. Select any user
  8. Click Request Money button

Platform

Android ✔️

Notes/Images/Video
No workaround found. Only happening on Android app.

Bug5074926_Screen_Recording_20210518-170423_Expensifycash__1_.mp4

@roryabraham
Copy link
Contributor Author

@isagoico This goes a step further than the QA steps for this PR. Could you please create a separate issue?

@isagoico
Copy link

Sure! Issue here #2995

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IOU - Unable to create IOU transaction via request money on conversation
3 participants