[Hold for Payment 1st June] IOU - Name is not visible in the IOU request page

[isagoico]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Expected Result:

User's name should be visible in the request page.

Actual Result:

Username is not visible and there's a blank space

Action Performed:

1. Log in to e.cash with a expensifail account
2. Navigate to a conversation
3. Click on the + button
4. Click on request money
5. Set an amount
6. Click continue

Workaround:

None needed, visual issue.

Platform:

Where is this issue occurring?

Web ✔️
iOS
Android ✔️
Desktop App
Mobile Web ✔️

Version Number: 1.0.48-0

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation
I was unable to verify the issue in production due to the blank page issue #2969

Expensify/Expensify Issue URL:

View all open jobs on Upwork

[MelvinBot]

Triggered auto assignment to @arielgreen (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[trjExpensify]

I'm unable to reproduce this in the request money flow on v.1.0.48-3:

I am however able to reproduce this in the split bill flow:

[Julesssss]

I'm seeing this for the Request Money flow too on version v1.0.48-3:

OptionRow has the correct name, but DisplayNames does not:

[trjExpensify]

Strange. I re-added and changed my name in Expensify to see if there was anything in that, but nothing. Anyhow, let's get this to engineering and I'll add it the IOU parent issue as a regression to fix.

[MelvinBot]

Triggered auto assignment to @Beamanator (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[Beamanator]

10/10 can reproduce 😅

[Beamanator]

Looks like in the IOUConfirmationList component we don't pass showTitleTooltip to OptionRow, so tooltipEnabled is never passed as true to DisplayNames.

In DisplayNames, if this.props.tooltipEnabled is false (which it always will be for this page), we try to display this.props.fullTitle. It seems this.props.fullTitle is an empty string here, always. Which seems odd.

If we decide to pass showTitleTooltip as true in IOUConfirmationList, it would make it all the way to DisplayNames, and then we would try to render data from this.props.displayNamesWithTooltips, but this appears to be an empty array always. This also seems odd.

fullTitle is created from displayNamesWithTooltips, which is created from option.participantsList, which seems to be missing in the OptionRow -> this is probably where our issues are coming from.

Continuing investigation...

[parasharrajat]

It seems a regression by #2724.

[Julesssss]

Great spot @parasharrajat. I'll share this on the issue.

[Beamanator]

Yeah nice - changing OptionRow back to: fullTitle={option.text} fixes it 👍

[iwiznia]

So, we should assign this to @Viacheslav80, right?

[trjExpensify]

Yes, although for some reason GH isn't allowing us to do that. @Viacheslav80 could you assign yourself this issue to fix the regression, please?

[Viacheslav80]

I created a fix for this regression. How i can assign myself for this issue?
Or someone assign me

[Beamanator]

Hey @Viacheslav80 we were having trouble assigning you yesterday (not sure why), looks like we're able to today :) Please submit a PR when you have a chance!

[isagoico]

Issue not reproducible today during KI retests (First Week)

[trjExpensify]

Hm yeah, odd. Same for me on v1.0.51-2:

[Beamanator]

Same - can't reproduce anymore.

I believe it was fixed here: 54a21d9#diff-0f2d048995be66cab42aa4bdf71f1befedeb2989e3bd00c8113fb54b98a54f76

Where this change was made in OptionRow.js:

-   const fullTitle = displayNamesWithTooltips.map(({displayName}) => displayName).join(', ');
+   const fullTitle = option.text ? option.text
+        : displayNamesWithTooltips.map(({displayName}) => displayName).join(', ');

[Viacheslav80]

@Beamanator
Hi! This patch solves this problem but does not solve the firstiNames in the chat title
this pr is created to solve: #3027

[trjExpensify]

Thanks guys!

[parasharrajat]

I think this can be closed now.

[trjExpensify]

Yep! 👍