Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix IOU - Name is not visible in the IOU request page #2996 #3027

Merged
merged 5 commits into from
May 25, 2021
Merged

fix IOU - Name is not visible in the IOU request page #2996 #3027

merged 5 commits into from
May 25, 2021

Conversation

Viacheslav80
Copy link
Contributor

@Viacheslav80 Viacheslav80 commented May 20, 2021 •
edited
Loading

Details

returning back param option.text to src/pages/home/sidebar/OptionRow.js
creating a fulltitle string constant (firstNames) and
assigned to the text property if hasMultipleParticipants is true
in src/libs/OptionsListUtils.js

Fixed Issues

Fixes #2996

Tests

  1. Log in to e.cash with a expensifail account
  2. Navigate to a conversation
  3. Click on the + button
  4. Click on request money
  5. Set an amount
  6. Click continue
  7. Making sure that the Username is visible

QA Steps

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

web

Mobile Web

Desktop

iOS

Android

web

@Viacheslav80 Viacheslav80 requested a review from a team as a code owner May 20, 2021 12:07
@MelvinBot MelvinBot requested review from Dal-Papa and removed request for a team May 20, 2021 12:08
@trjExpensify
Copy link
Contributor

trjExpensify commented May 21, 2021 •
edited
Loading

👋 @Viacheslav80, can you let us know why you're unable to test? You should be able to access the IOU functionality locally.

@Viacheslav80
Copy link
Contributor Author

I've already tested it

This was referenced May 22, 2021
Merged
Closed
@Dal-Papa Dal-Papa merged commit 66198f8 into Expensify:main May 25, 2021
@OSBotify OSBotify mentioned this pull request May 25, 2021
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dal-Papa Dal-Papa Dal-Papa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Hold for Payment 1st June] IOU - Name is not visible in the IOU request page
3 participants
@Viacheslav80 @trjExpensify @Dal-Papa