Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make unread indicator for web favicon larger #2961

Merged
merged 1 commit into from
May 17, 2021
Merged

Make unread indicator for web favicon larger #2961

merged 1 commit into from
May 17, 2021

Conversation

shawnborton
Copy link
Contributor

This updates the favicon for web when there are unread messages.

Details

Fixed Issues

#2658

Tests

  1. Open up Expensify.cash for web, and make sure the favicon when there is unread messages has been updated. The red dot on the icon should be larger.

QA Steps

  1. Open up Expensify.cash for web, and make sure the favicon when there is unread messages has been updated. The red dot on the icon should be larger.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

This change is for web only.

Web

No Unreads | Unreads

image | image

Mobile Web

N/A

Desktop

N/A

iOS

N/A

Android

N/A

@shawnborton shawnborton requested a review from a team May 17, 2021 15:41
@shawnborton shawnborton self-assigned this May 17, 2021
@MelvinBot MelvinBot requested review from marcaaron and removed request for a team May 17, 2021 15:41
Copy link
Contributor

@marcaaron marcaaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marcaaron marcaaron merged commit 087205d into main May 17, 2021
@marcaaron marcaaron deleted the shawn-favicon branch May 17, 2021 19:10
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants