Deploy Checklist: New Expensify 2023-07-21

[OSBotify]

Release Version: 1.3.44-0
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Apple sign-in #16723
• clean up the deep link code #17452
• Support new emojiReaction data format #17996
• [Fix #21022] Improve performance by reducing re-renders SidebarLinks #21406
• Removed isVisible prop from ValidateCodeForm #21594
• Localize OS desktop menus #21938
• migrate AddDebitCardPage to function component #16284 #22154
• migrate workspaceReimburseView.js from class to function component #22243
• Migrate/workspacelistpage issue/16310 #22248
• fix: Regression - Emoji reaction not working - Issue 22235 (Original - 21826) #22270
• Cut off reveal button when deleting in offline mode #22276
• fix rename room permission #22316
• Fix for: Web – 2FA - The copy icon placed in "copy code" button is clicked, the icon remains in a hovered state. #22430
• fix: console error on click of connect online with plaid button #22473
• Update Expense Request Headers / Empty State #22562
• Fix: After going back from a thread, clicking on New Message button doesn't scroll to the new message at the bottom #22645
• fix: format amount before navigating to next page #22728
• Context menu item Class Component Refactor #22733
• Allow user to search for tasks #22734
• Fix Task cancelled message is not showing #22755
• [NoQA] refactor: migrate RadioButtons to function component #22770
• fix: Green dot doesn't appear automatically when assigning task to self repeatedly #22784
• Fix: Web -Default avatar is changed when we select/unselect a member in Workspace invitation page #22791
• Refactor KeyboardDismissingFlatList to a functional component #22805
• Migrate CopySelectionHelper.js from class component to hook #22808
• Update language on Split Preview #22818
• fix: get correct avatar using user utils function #22830
• Silently fail flagComment request if reportAction has been deleted #22831
• AutoFocus On Debit Card Page #22841
• Make sure the IOU or expense level settlement button defaults to last used method #22846
• Assignee selector #22851
• fix: deleted message not show when deleting thread #22864
• Migrate BasePasswordPopover.js to function component #22891
• separate indicator view from avatar on LHN header #22898
• fix: optimistically add personal details #22904
• [HelpSite] Fix typo in link, make it clickable #22917
• Disable onkeydown when Pressable is disabled #22926
• Fix - Cursor position and hover effect on emoji picker doesn't match #21217 #22928
• fix: Send button does not appear when the internet connection is disabled #22981
• fix: The title field is cleared when the Confirm task button is pressed #22983
• Fix the emoji picker does not close when editing message is deleted #22984
• fix Notfound when login from contact detail page #22988
• Update optimistic data for parent report action when completing or reopening task #22990
• Prevent potential duplication of adding the event listeners #22991
• [navigation-refactor] Fix: dont use fallback if there are multiple rhp stacks #23007
• fix: preserve magic code when login #23023
• [NoQA] [navigation-refactor] Remove withNavigationFocus from the report screen #23024
• fix navigating to thread when clicking on go to #admins or #announce room #23030
• Revert "Hide muted chats from LHN" #23037
• Fix: when someone assign a task to himself and share it, his email hi… #23041
• [NoQA] Fix: console warning by adding the missing values to target location for native devices #23042
• Pass policyID when adding a bank account #23045
• Update Expensify-Chat-Playbook-for-Conferences.md #23047
• generate optimisticAccountID for details page of users without prior chat history #23053
• fix: text below the input flickers in ios. #23054
• fix: 22692 FAB menu is not open when login with the new account #23056
• fix 22745: change filter rule to exclude pending delete workspace #23064
• Center Emojis Vertically on Native #23071
• fix: scroll date of birth year list on first mount only #23079
• Revert PR 22752 to fix text selection regression #23085
• [navigation-refactor] Change navigate to goBack after saving on paypal me page #23086
• fix: added maxLength to login and contact inputs #23095
• Fix report name on report footer is not dynamically updated #23098
• Fix - close account confirmation modal is displayed by ENTER when network is offline #23099
• Fix step counter #23107
• Fix: When the language changes, we should not change the focused index in a list #23117
• Fix navigating back to parent from iou action thread #23121
• Create DesignDocIssue template #23127
• [CP Staging] Fix missing settlement button #23129
• Only show back button on small screen width #23133
• fix: ensure multiple errors are not shown on Add New contact page #23141
• Fix lottie interactions #23145
• fix: the created task message is grey when offline #23150
• Revert Android app name to 'New Expensify' #23155
• Remove lhNormal from MenuItem #23156
• Add provisioning profile for Expensify AdHoc App #23176
• Fix: for mWeb(ios safari) float button up for the screen when keyboard opens for the form input #23185
• [CP Staging] Add missing Toggle Developer Tools option to desktop menu #23192
• Rename DesignDocIssue to DesignDocIssue.md #23205
• Remove unnecessary default value #23206
• Change allReportActionsParam default #23214
• #20709: Use windowHeight in getNavigationModalCardStyles #23222
• [CP Staging] Fix regression #23189 #23240
• Migrate OptionsList/index.js to a functional component #23241
• Revert "fix: The title field is cleared when the Confirm task button is pressed" #23243
• remove limit and add max length task description #23246
• fix: allow to add link with code block inside alias text part #23247
• Update ReportSettingsPage and NotificationPreferencePage permission #23255
• [NoQA] Fix the usage of localize #23256
• fix crash while pressing mention #23259
• Revert "Apple sign-in" #23295
• [CP Staging] [NO QA] Update provisioning profile to include one with Apple Sign In entitlement #23299
• Fix tooltip for mentions #23310

Internal QA:

• Fix the settled preview message #23110 - @mountiny

Deploy Blockers:

• [HOLD for payment 2023-08-01] [HOLD for payment 2023-07-28] Web - Workspace avatar is not updating after renaming #23189

• [HOLD for payment 2023-08-01][$1000] Chat - App crashed while clicking on non-existed mention email #23250

• [$1000] Chat - Removed reactions by other user offline still displayed after going online #23388

• Chat - Name not placed in bold to indicate unread messages #23399

• [HOLD for payment 2023-08-02] Task - Long task description is truncated in chat and overlapped by expand button #23410

• Chat - "Back arrow" works with delay for chat opened from room member's list #23412

• Workspace rooms details page display user list in place of room name #23416

• [HOLD for payment 2023-08-02] LHN - If the first comment in a thread is deleted [Deleted message] appears in the LHN subtitle of the parent report #23401

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
• I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

[OSBotify]

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.3.44-0 🚀

[mvtglobally]

Regression is almost completed

Will update the summary in the morning

PR #22851 is failing #23407
PR #22891 (comment) needs assistance
PR #22917 prod QA are we ok to check it off?
PR #23246 is failing #23410

[mountiny]

Checking the internalQA #23110 off as Anu has tested this with the C+ payments

[mountiny]

checking #23189 and #23250 off as the CPes have been deployed to staging and the issues are not reproducible anymore

[mvtglobally]

Regression is completed. No additional comments

[marcaaron]

Checking off #22891 because passwordless is 100% rolled out and I think the code from that PR is basically "dead" now.

[marcaaron]

#22851 is on prod so we can check it off

[marcaaron]

PR #22917 prod QA are we ok to check it off?

yes - checked off

[marcaaron]

Just waiting for #23487 to get tested and then we can:

• CP
• retest
• check off remove limit and add max length task description #23246 + [HOLD for payment 2023-08-02] Task - Long task description is truncated in chat and overlapped by expand button #23410

Edit: We just decided to drop the blocker for this one. Reasoning in this thread.

[marcaaron]

Removed the blocker label from #23412. It seems like a performance regression, but inconsistently reproducible for everyone.

[arosiclair]

#23358 passes on staging and fixes #23416

[marcaaron]

Just down to the [Deleted message] bug now. Ready to send it after that.

[marcaaron]