-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chat - "Back arrow" works with delay for chat opened from room member's list #23412
Comments
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
|
Triggered auto assignment to @marcaaron ( |
I cannot repro cc @lanitochka17 @isagoico @kavimuru Can you please double check if you can still repro? |
@mountiny Issue is not reproduced. Build 1.3.44.0 ios.2407.mp4 |
Interesting so - since this is not reproducible anymore I think we can remove the blocker. Though - I feel like there might be some performance issue happening here. Can we test out how this works when the room has a lot of members or a lot of chats? Something happened to make this slow. And a reported lag of 7-13 seconds is fairly serious. |
Triggered auto assignment to @sakluger ( |
Bug0 Triage Checklist (Main S/O)
|
One thing that I'd recommend we do here is add timing logs and maybe try to figure out some way to alert when this is really slow. Also would be good to include additional params like number of comments on the chat they are navigating back to, number of members in the chat, etc. |
I'm not the right person to help reproduce this. As an AM, my app is incredibly slow in lots of scenarios. I do like the idea to add timing logs to find slow processes in general. |
It seems that we can't reproduce this and we're working on a bunch of other changes to improve performance, so I'm going to close this issue out for now. |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Expected Result:
User is immediately transferred to the room page
Actual Result:
Back arrow works with delay - user is transferred to the room page in 7-13 seconds
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: 1.3.44.0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Bug6137987_bug.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: