Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chat - "Back arrow" works with delay for chat opened from room member's list #23412

Closed
1 of 6 tasks
lanitochka17 opened this issue Jul 22, 2023 · 10 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2

Comments

@lanitochka17
Copy link

lanitochka17 commented Jul 22, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open iOS app
  2. Open a room (with at least 1 more member in it)
  3. Tap on room nam to invoke room details page
  4. Tap on members
  5. Tap on a member other than yourself
  6. Tap on "message "member name""
  7. Tap on back arrow in the top left

Expected Result:

User is immediately transferred to the room page

Actual Result:

Back arrow works with delay - user is transferred to the room page in 7-13 seconds

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Safari
  • MacOS / Desktop

Version Number: 1.3.44.0

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6137987_bug.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Jul 22, 2023
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Jul 22, 2023

Triggered auto assignment to @marcaaron (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@mountiny
Copy link
Contributor

I cannot repro cc @lanitochka17 @isagoico @kavimuru Can you please double check if you can still repro?

@lanitochka17
Copy link
Author

@mountiny Issue is not reproduced. Build 1.3.44.0
Iphone 14 Pro Max/ios16.5

ios.2407.mp4

@marcaaron
Copy link
Contributor

Interesting so - since this is not reproducible anymore I think we can remove the blocker. Though - I feel like there might be some performance issue happening here. Can we test out how this works when the room has a lot of members or a lot of chats? Something happened to make this slow. And a reported lag of 7-13 seconds is fairly serious.

@marcaaron marcaaron added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Jul 24, 2023
@marcaaron marcaaron removed their assignment Jul 24, 2023
@marcaaron marcaaron added Bug Something is broken. Auto assigns a BugZero manager. and removed Engineering labels Jul 24, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 24, 2023

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Jul 24, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@marcaaron
Copy link
Contributor

One thing that I'd recommend we do here is add timing logs and maybe try to figure out some way to alert when this is really slow. Also would be good to include additional params like number of comments on the chat they are navigating back to, number of members in the chat, etc.

@sakluger
Copy link
Contributor

I'm not the right person to help reproduce this. As an AM, my app is incredibly slow in lots of scenarios.

I do like the idea to add timing logs to find slow processes in general.

@melvin-bot melvin-bot bot added the Overdue label Jul 27, 2023
@sakluger
Copy link
Contributor

It seems that we can't reproduce this and we're working on a bunch of other changes to improve performance, so I'm going to close this issue out for now.

@melvin-bot melvin-bot bot removed the Overdue label Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2
Projects
None yet
Development

No branches or pull requests

5 participants