fix: preserve magic code when login #23023

tienifr · 2023-07-17T17:26:30Z

Details

Fixed Issues

$ #21293
$ #23087
PROPOSAL:

Tests

Navigate to Sign-in page on two tabs
Enter account > Continue
Verify that it redirects to magic code input on both tabs
Enter an invalid magic code with 6 characters on the first tab
Verify that the error appears and the magic code is still preserve
Press Didn't receive a magic code on the second tab
Verify that all errors on the first tabs are cleared

Verify that no errors appear in the JS console

Offline tests

QA Steps

Navigate to Sign-in page on two tabs
Enter account > Continue
Verify that it redirects to magic code input on both tabs
Enter an invalid magic code with 6 characters on the first tab
Verify that the error appears and the magic code is still preserve
Press Didn't receive a magic code on the second tab
Verify that all errors on the first tabs are cleared

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Screen.Recording.2023-07-18.at.00.02.00.mp4

Mobile Web - Chrome

original-BCA41B7B-9BE5-4E54-B46C-BE8051DD235D.mp4

Mobile Web - Safari

original-A95D8992-3BB4-4BFC-8348-AACAF4E6B533.mp4

Desktop

Screen.Recording.2023-07-18.at.00.20.35.mov

iOS

Screen.Recording.2023-07-18.at.00.30.48.mov

Android

Screen.Recording.2023-07-18.at.00.44.07.mp4

melvin-bot · 2023-07-17T17:27:45Z

@aimane-chnaif Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

tienifr · 2023-07-17T17:29:44Z

@aimane-chnaif Sorry for this inconvenience. I had a mistake with the form name. Can you help check the PR to fix the regression? I'm recording the video on ios and android and will post them in a few mins

aimane-chnaif · 2023-07-17T18:00:01Z

src/libs/actions/Session/index.js

@@ -172,7 +172,7 @@ function resendValidateCode(login = credentials.login) {
            key: ONYXKEYS.ACCOUNT,
            value: {
                errors: null,
-                loadingForm: CONST.FORMS.VALIDATE_CODE_FORM,
+                loadingForm: CONST.FORMS.RESEND_VALIDATION_FORM,


This form name is already used in resend page. We should introduce new name, maybe RESEND_VALIDATE_CODE_FORM

tienifr · 2023-07-18T04:43:36Z

@aimane-chnaif I just updated my PR. Can you help review?

aimane-chnaif · 2023-07-18T04:48:01Z

@tienifr please also check if #23009 is caused by our PR, though I don't think so.

tienifr · 2023-07-18T05:00:01Z

Screen.Recording.2023-07-18.at.11.58.55.mov

@aimane-chnaif My PR fixed it. Thanks

aimane-chnaif · 2023-07-18T05:13:46Z

Still codes are cleared while logging in.

Screen.Recording.2023-07-18.at.6.10.37.AM.mov

aimane-chnaif · 2023-07-18T05:20:07Z

Nvm, I was testing on Safari and code changes are not applied for some reason. Tests well after force refresh

aimane-chnaif · 2023-07-18T05:32:41Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-07-18.at.6.21.27.AM.mov

Mobile Web - Chrome

Mobile Web - Safari

Screen.Recording.2023-07-18.at.6.31.21.AM.mov

Desktop

iOS

Android

aimane-chnaif

@danieldoglas let's CP this as original PR was already deployed to staging

OSBotify · 2023-07-18T15:08:53Z

🚀 Deployed to staging by https://github.com/danieldoglas in version: 1.3.42-13 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-07-19T17:58:50Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.42-26 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-07-21T18:53:36Z

🚀 Deployed to staging by https://github.com/danieldoglas in version: 1.3.44-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-07-25T01:27:33Z

🚀 Deployed to production by https://github.com/marcaaron in version: 1.3.44-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

tienifr added 2 commits July 18, 2023 00:05

fix: preserve magic code when login

10cc790

fix: change name

1a8806c

tienifr marked this pull request as ready for review July 17, 2023 17:27

tienifr requested a review from a team as a code owner July 17, 2023 17:27

melvin-bot bot requested review from aimane-chnaif and removed request for a team July 17, 2023 17:27

aimane-chnaif reviewed Jul 17, 2023

View reviewed changes

aimane-chnaif mentioned this pull request Jul 17, 2023

[$250] Web - Magic code does not show if copy-pasted #22963

Closed

6 tasks

fix: change form name

e97e93d

aimane-chnaif approved these changes Jul 18, 2023

View reviewed changes

melvin-bot bot requested a review from danieldoglas July 18, 2023 05:33

This was referenced Jul 18, 2023

Dev: Web - Magic code does not blur during sign in loading #23009

Closed

[HOLD for payment 2023-07-26] User can continue to enter magic code value while entered magic code value is being submitted #23087

Closed

danieldoglas approved these changes Jul 18, 2023

View reviewed changes

danieldoglas merged commit f41825a into Expensify:main Jul 18, 2023
11 checks passed

OSBotify mentioned this pull request Jul 18, 2023

Deploy Checklist: New Expensify 2023-07-17 #23033

Closed

mountiny assigned tienifr Jul 18, 2023

jasperhuangg mentioned this pull request Jul 18, 2023

Web - When "Pasting" a code in sign in menu, the code vanishes and/or flashes #23075

Closed

6 tasks

melvin-bot bot mentioned this pull request Jul 19, 2023

[HOLD for payment 2023-07-26] [$1000] Requesting magic code from 'Magic code' page doesn't clear all sign-in errors #21293

Closed

6 tasks

Ayush-004 mentioned this pull request Jul 19, 2023

[$1000] Dev: Web - Unable to auto-submit the magic code before error appears on incorrect entry #22971

Closed

6 tasks

OSBotify mentioned this pull request Jul 21, 2023

Deploy Checklist: New Expensify 2023-07-21 #23362

Closed

Ollyws mentioned this pull request Sep 7, 2023

disable "Didn't receive magic code" while loading #26783

Merged

59 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: preserve magic code when login #23023

fix: preserve magic code when login #23023

tienifr commented Jul 17, 2023 •

edited by mountiny

Loading

melvin-bot bot commented Jul 17, 2023

tienifr commented Jul 17, 2023 •

edited

Loading

aimane-chnaif Jul 17, 2023

tienifr commented Jul 18, 2023

aimane-chnaif commented Jul 18, 2023

tienifr commented Jul 18, 2023

aimane-chnaif commented Jul 18, 2023

aimane-chnaif commented Jul 18, 2023

aimane-chnaif commented Jul 18, 2023

aimane-chnaif left a comment

OSBotify commented Jul 18, 2023

OSBotify commented Jul 19, 2023

OSBotify commented Jul 21, 2023

OSBotify commented Jul 25, 2023

fix: preserve magic code when login #23023

fix: preserve magic code when login #23023

Conversation

tienifr commented Jul 17, 2023 • edited by mountiny Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jul 17, 2023

tienifr commented Jul 17, 2023 • edited Loading

aimane-chnaif Jul 17, 2023

Choose a reason for hiding this comment

tienifr commented Jul 18, 2023

aimane-chnaif commented Jul 18, 2023

tienifr commented Jul 18, 2023

aimane-chnaif commented Jul 18, 2023

aimane-chnaif commented Jul 18, 2023

aimane-chnaif commented Jul 18, 2023

Reviewer Checklist

Screenshots/Videos

aimane-chnaif left a comment

Choose a reason for hiding this comment

OSBotify commented Jul 18, 2023

OSBotify commented Jul 19, 2023

OSBotify commented Jul 21, 2023

OSBotify commented Jul 25, 2023

tienifr commented Jul 17, 2023 •

edited by mountiny

Loading

tienifr commented Jul 17, 2023 •

edited

Loading