Localize OS desktop menus #21938

wojtus7 · 2023-06-30T10:44:47Z

Details

Translate top Mac menu to different language if the desktop application language changes.

One problem is that some menu options are automatically added on the menu during creation in system's language, and I can't really do much about it so eg. Last options in Edit -> Start Dictation and Emoji & Symbols, are shown in your system language because they were added to the submenu because there is Copy option there. Similar issue happens in Window menu. You can read more here

Fixed Issues

$ #13414

Tests

This change is only relevant in desktop version of the app

Open desktop application
Use top menu and see if all things work
Go to Settings -> Preferences
Change language
See if the menu changed, and works the same as before but is translated

Verify that no errors appear in the JS console

Offline tests

QA Steps

This change is only relevant in desktop version of the app

Open desktop application
Use top menu and see if all things work
Go to Settings -> Preferences
Change language
See if the menu changed, and works the same as before but is translated

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

N/A

Mobile Web - Chrome

N/A

Mobile Web - Safari

N/A

Desktop

Nagranie.z.ekranu.2023-06-30.o.09.37.58.mov

iOS

N/A

Android

N/A

melvin-bot · 2023-06-30T10:45:18Z

@bondydaa Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

bondydaa · 2023-06-30T16:37:21Z

please make sure you follow the PR template b/c the link to the GH was wrong the automation failed

bondydaa · 2023-06-30T16:38:08Z

assigning people from the GH. i fixed the link so should be all set 🙏

sobitneupane

As discussed in details section, following items were not translated.

sobitneupane

Screenshots/Videos

Desktop

Screen.Recording.2023-07-04.at.15.05.57.mov

Web

Mobile Web - Chrome

Mobile Web - Safari

iOS

Android

sobitneupane

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

pecanoro · 2023-07-14T17:37:29Z

Ohh wow I completely missed this PR in my list, I am so sorry about that, reviewing today!

pecanoro

Everything looks great, but did we forget to rename this one?

pecanoro · 2023-07-14T18:42:12Z

Ohh and also Minimize it seems as well!

wojtus7 · 2023-07-17T13:22:12Z

@pecanoro Unfortunately I didn't forget but the implementation of the Window menu is kinda wacky, different than any other menu.

The only way to get Move window to the left/right options is to create autogenerated window menu, but code inside implementation is strange and as a result Bring All to Front, Minimize (and Zoom as far as I can remember) options are hardcoded English 🥲

I think only way to translate all menu here is to remove the Move options. Same thing happens in different electron apps I know :<

pecanoro · 2023-07-17T17:42:54Z

@wojtus7 Got it! Teah, it sucks a bit, there is nothing you can do so let's leave it this way until Electron improves this logic. Can you leave a comment in the code explaining that there are elements that cannot be translated due to that limitation?

wojtus7 · 2023-07-18T15:49:40Z

@pecanoro I have kinda good news! I wanted to test if I was not wrong before adding comments and by accident realized that maybe I still don't have full control over Window menu I was able to translate Minimize, Zoom and Bring All to front options. 🎉

Can you take a look if it works good for you as well?

(On screenshot some options in polish because I change Mac language to test)

pecanoro · 2023-07-18T16:36:37Z

Tested! It works great! Thank you!

OSBotify · 2023-07-18T17:19:27Z

🚀 Deployed to staging by https://github.com/pecanoro in version: 1.3.42-17 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-07-19T17:58:38Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.42-26 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-07-21T18:53:24Z

🚀 Deployed to staging by https://github.com/pecanoro in version: 1.3.44-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-07-25T01:27:21Z

🚀 Deployed to production by https://github.com/marcaaron in version: 1.3.44-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

wojtus7 added 11 commits June 27, 2023 17:24

Working version with everything in one file

a7ea513

Run prettier

4aaab92

Use Localize

e9a5937

Merge remote-tracking branch 'upstream/main' into wojtus7/menu-languages

910ae08

Use localized text instead hardcoded strings in template

46996e9

USe expensify links in help tab

67a2b7c

USe same syntax in initialization and update functions

0a20f03

Move setLabelsInMenuTemplate to menu section

32a88d5

USe old name localizeMenuItems

e92b38c

Make links work

11b42a2

Fix id

5ccdff3

wojtus7 requested a review from a team as a code owner June 30, 2023 10:44

melvin-bot bot requested review from bondydaa and removed request for a team June 30, 2023 10:45

bondydaa assigned wojtus7 Jun 30, 2023

bondydaa requested review from pecanoro and sobitneupane and removed request for bondydaa June 30, 2023 16:37

sobitneupane reviewed Jul 4, 2023

View reviewed changes

sobitneupane approved these changes Jul 4, 2023

View reviewed changes

pecanoro reviewed Jul 14, 2023

View reviewed changes

Merge remote-tracking branch 'upstream/main' into wojtus7/menu-languages

4e7c9e0

Translate window menu

4864d13

pecanoro approved these changes Jul 18, 2023

View reviewed changes

pecanoro merged commit df98ca5 into Expensify:main Jul 18, 2023
10 checks passed

OSBotify mentioned this pull request Jul 18, 2023

Deploy Checklist: New Expensify 2023-07-17 #23033

Closed

melvin-bot bot mentioned this pull request Jul 19, 2023

[HOLD for payment via NewDot] Localize OS desktop menus #13414

Closed

OSBotify mentioned this pull request Jul 21, 2023

Deploy Checklist: New Expensify 2023-07-21 #23362

Closed

bernhardoj mentioned this pull request Jul 29, 2023

Mac OS- cannot use cmd+shift+v shortcut to paste #23830

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Localize OS desktop menus #21938

Localize OS desktop menus #21938

wojtus7 commented Jun 30, 2023 •

edited by bondydaa

Loading

melvin-bot bot commented Jun 30, 2023

bondydaa commented Jun 30, 2023

bondydaa commented Jun 30, 2023

sobitneupane left a comment

sobitneupane left a comment

sobitneupane left a comment

pecanoro commented Jul 14, 2023

pecanoro left a comment

pecanoro commented Jul 14, 2023

wojtus7 commented Jul 17, 2023

pecanoro commented Jul 17, 2023

wojtus7 commented Jul 18, 2023

pecanoro commented Jul 18, 2023

OSBotify commented Jul 18, 2023

OSBotify commented Jul 19, 2023

OSBotify commented Jul 21, 2023

OSBotify commented Jul 25, 2023

Localize OS desktop menus #21938

Localize OS desktop menus #21938

Conversation

wojtus7 commented Jun 30, 2023 • edited by bondydaa Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jun 30, 2023

bondydaa commented Jun 30, 2023

bondydaa commented Jun 30, 2023

sobitneupane left a comment

Choose a reason for hiding this comment

sobitneupane left a comment

Choose a reason for hiding this comment

Screenshots/Videos

sobitneupane left a comment

Choose a reason for hiding this comment

Reviewer Checklist

pecanoro commented Jul 14, 2023

pecanoro left a comment

Choose a reason for hiding this comment

pecanoro commented Jul 14, 2023

wojtus7 commented Jul 17, 2023

pecanoro commented Jul 17, 2023

wojtus7 commented Jul 18, 2023

pecanoro commented Jul 18, 2023

OSBotify commented Jul 18, 2023

OSBotify commented Jul 19, 2023

OSBotify commented Jul 21, 2023

OSBotify commented Jul 25, 2023

wojtus7 commented Jun 30, 2023 •

edited by bondydaa

Loading