-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable onkeydown when Pressable is disabled #22926
Disable onkeydown when Pressable is disabled #22926
Conversation
@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
@eVoloshchak I'm assuming we want the |
Bump @eVoloshchak |
Will review in a couple of hours |
Reviewer Checklist
Screenshots/VideosWebScreen.Recording.2023-07-17.at.18.40.52.movMobile Web - Chromescreen-20230717-230939.mp4DesktopScreen.Recording.2023-07-17.at.18.41.32.movAndroidscreen-20230717-230806.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just to double check did anyone test android and ios just to make sure this didn't cause any other weirdness or crashes? I know in most cases people won't have a keyboard where they could trigger a keyDown
event, my fear being that b/c of that react native might not recognize that event or something. Mostly just asking a naive question since I'm not sure one way or the other.
@bondydaa, yeah, I've connected an external keyboard to Android phone, it works as expected (added videos) |
woot looks like I've got working simulators again, doesn't seem like any issues on iOS so merging 👍 |
🚀 Deployed to staging by https://github.com/bondydaa in version: 1.3.42-2 🚀
|
🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.42-26 🚀
|
🚀 Deployed to staging by https://github.com/bondydaa in version: 1.3.44-0 🚀
|
🚀 Deployed to production by https://github.com/marcaaron in version: 1.3.44-2 🚀
|
Details
Disabling the onKeyDown props when Pressable is disabled.
Fixed Issues
$ #22413
PROPOSAL: #22413 (comment)
Tests
Same as QA Steps
Offline tests
Same as QA Steps
QA Steps
Web/Desktop only
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Web
Screen.Recording.2023-07-15.at.11.11.31.mov
Mobile Web - Chrome
Mobile Web - Safari
Desktop
Screen.Recording.2023-07-15.at.11.18.27.mov
iOS
Android