-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove limit and add max length task description #23246
remove limit and add max length task description #23246
Conversation
@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
src/components/MenuItem.js
Outdated
@@ -72,7 +72,6 @@ const defaultProps = { | |||
isAnonymousAction: false, | |||
isSmallAvatarSubscriptMenu: false, | |||
title: '', | |||
numberOfLinesTitle: 1, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should be removing this prop. We should still retain the check, and instead set this to 0 from TaskPreview
. I think this would break MenuItem
at a few places.
cc - @stitesExpensify
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, you're right, to make sure it not effect another place, I think we can set numberOfLLine={0} from TaskView
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah but we'll have to change the condition to numberOfLinesTitle > 1
to numberOfLinesTitle != 1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, also we don't need to pass the style.preWrap on TaskView, Thanks @mananjadhav for review
@namhihi237 I think we decided not to implement the input limit. @stitesExpensify let's remove it from this PR right? |
oh right, I will remove this @mananjadhav |
@namhihi237 I am not sure how it is working for you on the Android? I thin you haven't tested/updated screenshots after pushing the last changes. |
@mananjadhav Sorry I forgot to test the last update on Android, just IOS. I just fixed it, here is a screenshot for both: |
@namhihi237 I don't think this fix works. It's a code smell, and doesn't make sense to repeat the same component twice? |
yeah @mananjadhav , version refactored |
Thanks I think this works. I can see we're refactoring |
yes, Thanks @mananjadhav for review |
Reviewer Checklist
Screenshots/VideosWebweb-task-description-multiline.movMobile Web - Chromemweb-chrome-task-description-multiline.movMobile Web - Safarimweb-safari-task-description-multiline.movDesktopdesktop-task-description-multiline.moviOSios-task-description-multiline.movAndroidandroid-task-description-multiline.mov |
@stitesExpensify All yours. 🎀 👀 🎀 C+ reviewed. |
Just to confirm @mananjadhav everything is testing well still after the recent changes? |
Oops, my GH wasn't updated, Just saw your new checklist. Ignore me! |
Yes I checked after the last commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/stitesExpensify in version: 1.3.44-0 🚀
|
@namhihi237 We have a regression when we put a continuous string without any space it overflows the description. #23410 (comment) Can we please post a PR to fix this please? |
Yes, I will raise PR sasp |
Hi @mananjadhav PR is already, please take a look thanks. |
🚀 Deployed to production by https://github.com/marcaaron in version: 1.3.44-2 🚀
|
🚀 Deployed to staging by https://github.com/stitesExpensify in version: 1.3.45-0 🚀
|
🚀 Deployed to production by https://github.com/mountiny in version: 1.3.45-7 🚀
|
Details
Fixed Issues
$ #22493
PROPOSAL: #22493 (comment)
Tests
Offline tests
The same test
QA Steps
The same test
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Web
web.mov
Mobile Web - Chrome
mweb.mov
Mobile Web - Safari
safari.MP4
Desktop
desktop.mov
iOS
Android