Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3.24.0 proposal #3266

Merged
merged 42 commits into from
Jun 23, 2023
Merged

v3.24.0 proposal #3266

merged 42 commits into from
Jun 23, 2023

Conversation

nsavoire
Copy link
Collaborator

@nsavoire nsavoire commented Jun 21, 2023

Features

Improvements

Bug Fixes

rochdev and others added 28 commits June 20, 2023 14:03
* add migration guide for 3.x to 4.x

* Update MIGRATING.md

Co-authored-by: Juan Antonio Fernández de Alba <juan.fernandezdealba@datadoghq.com>

* Update MIGRATING.md

Co-authored-by: Juan Antonio Fernández de Alba <juan.fernandezdealba@datadoghq.com>

* Update README.md

Co-authored-by: Ugaitz Urien <ugaitz.urien@datadoghq.com>

---------

Co-authored-by: Juan Antonio Fernández de Alba <juan.fernandezdealba@datadoghq.com>
Co-authored-by: Ugaitz Urien <ugaitz.urien@datadoghq.com>
* update readme to include v4

* use version module instead of semver to match library version
* Unvalidated redirect analyzer

* Ignore tainteds from Referer header
)

* Add _dd.iast.enabled=1 in out of request vulnerabilities tags

* Rename constants.js to tags.js
* add v0 naming to tedious (mssql)
* add v1 naming to tedious (mssql)
* switch to a mostly working test sqlserver

  The standard mssql server image does not work on ARM [1].

  Instead, we use `azure-sql-edge` [2], which provides a sufficient subset
  of mssql server API to test most of our integration. 

  Unfortunately, this image does not support stored procedures [3], so
  tests related to these will still fail locally.

  [1] microsoft/mssql-docker#668
  [2] https://hub.docker.com/_/microsoft-azure-sql-edge
  [3] https://learn.microsoft.com/en-us/azure/azure-sql-edge/features#unsupported-features
* add v0 naming to mysql integrations
* add v1 to mysql integrations
* add tests on v1 for mysql databases

---------

Co-authored-by: Thomas Hunter II <tlhunter@datadog.com>
* Taint cookies and headers

* Bump minimum node version for v4 on cookie plugin test

* Add test with latest node version for cookie plugin test

* Provide iastContext from index when tainting headers

* Add test for cookie tainting in taint tracking plugin

* Remove iast transaction after taint tracking plugin tests to avoid hiting setMaxTransactions in tests

* Add test for taintObject with taintingKeys flag

* Address header tainting test for keys shorter than 10 chars

* Upgrade native-iast-taint-tracking to v1.5.0

* Rewrite expect in taint tracking plugin test

* Fix tag requiring in IAST index

---------

Co-authored-by: Thomas Hunter II <tlhunter@datadog.com>
* Add sources tests

* styles
* appsec-iast benchmark tests

* writing fixes

Co-authored-by: simon-id <simon.id@datadoghq.com>

* small fixes

---------

Co-authored-by: simon-id <simon.id@datadoghq.com>
* Reduce request per iteration in IAST benchmarks

* Reduce a bit more

* 30 iterations 200 requests
* Add debug log listing found source maps

* Bump pprof required version

Use pprof version with source map debug info.
Lock pprof version in package.json to be make sure that customers use
a dd-trace-js/pprof-nodejs combination that is well tested.
@nsavoire nsavoire changed the base branch from master to v3.x June 21, 2023 08:44
@nsavoire nsavoire changed the title V3.24.0 proposal v3.24.0 proposal Jun 21, 2023
@nsavoire nsavoire marked this pull request as ready for review June 22, 2023 09:34
@nsavoire nsavoire requested review from a team as code owners June 22, 2023 09:34
juan-fernandez
juan-fernandez previously approved these changes Jun 22, 2023
Copy link
Collaborator

@juan-fernandez juan-fernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good from ci visibility's perspective

uurien
uurien previously approved these changes Jun 22, 2023
uurien
uurien previously approved these changes Jun 23, 2023
rochdev
rochdev previously approved these changes Jun 23, 2023
* Add DD_PROFILING_DEBUG_SOURCE_MAPS option

DD_PROFILING_DEBUG_SOURCE_MAPS env variable enables printing of
detailed diagnostics concerning source maps.
Pass logger to profiler module to enable logging.

* Bump profiler version to 2.2.3
Copy link
Collaborator

@astuyve astuyve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 from serverless

@tlhunter
Copy link
Member

We're going to ignore the perf regressions for this release. One of them is for the upgraded version of the semver package in yarn.lock as customers installing via yarn install dd-trace already get the newer, slower version of semver. The other perf hit is with the fetch PR and the affected benchmarks are very sensitive to newly added modules.

@tlhunter tlhunter merged commit a3bccfb into v3.x Jun 23, 2023
@nsavoire nsavoire deleted the v3.24.0-proposal branch July 17, 2023 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.