-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check store
has value before use it
#3257
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uurien
force-pushed
the
uurien/fix-nullable-store
branch
from
June 19, 2023 15:55
96f31cd
to
4aaa864
Compare
Overall package sizeSelf size: 4.36 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov Report
@@ Coverage Diff @@
## master #3257 +/- ##
==========================================
+ Coverage 86.03% 86.05% +0.02%
==========================================
Files 194 194
Lines 7517 7517
Branches 33 33
==========================================
+ Hits 6467 6469 +2
+ Misses 1050 1048 -2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
uurien
force-pushed
the
uurien/fix-nullable-store
branch
from
June 20, 2023 07:05
4aaa864
to
650a1e8
Compare
iunanua
reviewed
Jun 20, 2023
iunanua
approved these changes
Jun 20, 2023
uurien
force-pushed
the
uurien/fix-nullable-store
branch
from
June 20, 2023 11:37
650a1e8
to
c213023
Compare
nsavoire
pushed a commit
that referenced
this pull request
Jun 21, 2023
nsavoire
pushed a commit
that referenced
this pull request
Jun 21, 2023
nsavoire
pushed a commit
that referenced
this pull request
Jun 21, 2023
This was referenced Jun 21, 2023
Merged
Merged
Merged
tlhunter
pushed a commit
that referenced
this pull request
Jun 23, 2023
tlhunter
pushed a commit
that referenced
this pull request
Jun 23, 2023
tlhunter
pushed a commit
that referenced
this pull request
Jun 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Check that the
store
object has value before use it.Motivation
We found logs with the catched error.